From: "Daniel P. Berrange" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>,
"Daniel P. Berrange" <berrange@redhat.com>
Subject: [Qemu-devel] [PATCH v1 6/9] ps2: fix scancodess sent for Pause key in AT set 1
Date: Thu, 19 Oct 2017 15:28:45 +0100 [thread overview]
Message-ID: <20171019142848.572-7-berrange@redhat.com> (raw)
In-Reply-To: <20171019142848.572-1-berrange@redhat.com>
The ps2 device was previously fixed to send the special Pause/Print
scancode sequences in:
commit 8c10e0baf0260b59a4e984744462a18016662e3e
Author: Hervé Poussineau <hpoussin@reactos.org>
Date: Thu Sep 15 22:06:26 2016 +0200
ps2: use QEMU qcodes instead of scancodes
The sequence used for Pause had a small typo in the AT set 1, with a 0xe1
accidentally changed to 0x91. This is not immediately visible with Linux
guests since they run the ps2 device with AT set 2 scancodes.
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
---
hw/input/ps2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/input/ps2.c b/hw/input/ps2.c
index c35b410e4d..133cc2aa64 100644
--- a/hw/input/ps2.c
+++ b/hw/input/ps2.c
@@ -645,7 +645,7 @@ static void ps2_keyboard_event(DeviceState *dev, QemuConsole *src,
ps2_put_keycode(s, 0xe1);
ps2_put_keycode(s, 0x1d);
ps2_put_keycode(s, 0x45);
- ps2_put_keycode(s, 0x91);
+ ps2_put_keycode(s, 0xe1);
ps2_put_keycode(s, 0x9d);
ps2_put_keycode(s, 0xc5);
}
--
2.13.6
next prev parent reply other threads:[~2017-10-19 14:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 14:28 [Qemu-devel] [PATCH v1 0/9] Various fixes for input/ps2 handling Daniel P. Berrange
2017-10-19 14:28 ` [Qemu-devel] [PATCH v1 1/9] input: use hex in ps2 keycode trace events Daniel P. Berrange
2017-10-19 15:17 ` Eric Blake
2017-10-19 14:28 ` [Qemu-devel] [PATCH v1 2/9] ui: fix crash with sendkey and raw key numbers Daniel P. Berrange
2017-10-19 15:18 ` Eric Blake
2017-10-19 14:28 ` [Qemu-devel] [PATCH v1 3/9] ui: use correct union field for key number Daniel P. Berrange
2017-10-19 15:19 ` Eric Blake
2017-10-19 14:28 ` [Qemu-devel] [PATCH v1 4/9] ps2: fix scancodes sent for Alt-Print key combination (aka SysRq) Daniel P. Berrange
2017-10-19 14:45 ` Daniel P. Berrange
2017-10-19 14:28 ` [Qemu-devel] [PATCH v1 5/9] ps2: fix scancodes sent for Shift/Ctrl+Print key combination Daniel P. Berrange
2017-10-19 14:28 ` Daniel P. Berrange [this message]
2017-10-19 14:28 ` [Qemu-devel] [PATCH v1 7/9] ps2: fix scancodes sent for Ctrl+Pause " Daniel P. Berrange
2017-10-19 14:28 ` [Qemu-devel] [PATCH v1 8/9] ui: normalize the 'sysrq' key into the 'print' key Daniel P. Berrange
2017-10-19 14:28 ` [Qemu-devel] [PATCH v1 9/9] ui: pull in latest keycodemapdb Daniel P. Berrange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171019142848.572-7-berrange@redhat.com \
--to=berrange@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.