From mboxrd@z Thu Jan 1 00:00:00 1970 From: hch@lst.de (Christoph Hellwig) Date: Thu, 19 Oct 2017 16:49:26 +0200 Subject: [PATCH 4.14-rc] nvme-rdma: Fix error status return in tagset allocation failure In-Reply-To: References: <1508396289-12237-1-git-send-email-sagi@grimberg.me> <20171019084926.GA14227@lst.de> <9604c4ac-0a0f-a029-1894-051e6de50072@grimberg.me> <20171019102022.GC17326@lst.de> <9cb7f448-f4a3-e3e6-e906-749a56daa943@grimberg.me> <20171019135522.GF21452@lst.de> Message-ID: <20171019144925.GA23650@lst.de> On Thu, Oct 19, 2017@05:44:57PM +0300, Sagi Grimberg wrote: > Oh, double indirection... I confused the ctrl structures in your > suggestion... Actually, let's skip the idea - I just noticed nvme_rdma_alloc_tagset does way too many different things for the admin vs io taget. I'm fine with your original version, but once we refactor things in this area I have a few ideas how to improve things.