Re: [Qemu-devel] [PULL 07/11] tools: add qemu-keymap

[Fam Zheng <famz@redhat.com>]

On Fri, 10/20 08:52, Thomas Huth wrote:
> On 20.10.2017 00:12, Eric Blake wrote:
> > On 10/19/2017 05:09 PM, Eric Blake wrote:
> >> On 10/16/2017 08:16 AM, Gerd Hoffmann wrote:
> >>> qemu-keymap generates qemu reverse keymaps from xkb keymaps,
> >>> which can be used with the qemu "-k" command line switch.
> >>>
> >>> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> >>> Message-id: 20171005153330.19210-2-kraxel@redhat.com
> >>> ---
> >>>  configure     |  23 ++++++
> >>>  Makefile      |   5 ++
> >>>  qemu-keymap.c | 258 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >>>  3 files changed, 286 insertions(+)
> >>>  create mode 100644 qemu-keymap.c
> >>
> >> For in-tree builds, this forgot to update .gitignore so that
> >> 'qemu-keymap' isn't accidentally checked in via 'git add -a'.
> > 
> > And on a related note, commit 2e1d70b pollutes the tree with a new
> > ui/shader/texture-blit-flip-vert.h, that should also be mentioned in
> > .gitignore.
> 
> Since this seems to happen regularly: I wonder whether we could add a
> check to patchew that tests whether the output of "git status" is clean
> at the end of an in-tree compilation process?

Sounds good, I'll try to write a $QEMU_SRC/tests/docker/test-cleanness patch
first.

Fam