From: Christoph Hellwig <hch@lst.de>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Dongdong Liu <liudongdong3@huawei.com>,
Charles Chenxin <charles.chenxin@huawei.com>,
linuxarm@huawei.com, Christoph Hellwig <hch@lst.de>,
Gabriele Paoloni <gabriele.paoloni@huawei.com>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH v5 3/3] PCI/portdrv: Compute MSI/MSI-X IRQ vectors after final allocation
Date: Fri, 20 Oct 2017 09:15:50 +0200 [thread overview]
Message-ID: <20171020071550.GE11101@lst.de> (raw)
In-Reply-To: <20171019230121.17806.11826.stgit@bhelgaas-glaptop.roam.corp.google.com>
> +/*
> + * Fill in *pme, *aer, *dpc with the relevant Interrupt Message Numbers if
> + * services are enabled in "mask". Return the number of MSI/MSI-X vectors
> + * required to accommodate the largest Message Number.
> + */
> +static int pcie_message_numbers(struct pci_dev *dev, int mask,
> + u32 *pme, u32 *aer, u32 *dpc)
> +{
Can you split factoring out this helper into a separate clean up patch
that goes before the actual change?
Otherwise this looks fine:
Reviewed-by: Christoph Hellwig <hch@lst.de>
Note that we should probably replace the irqs array with one storing
the relative vector number and use pci_request_irq(). In fact in that
case we could probably just pass said array to pcie_message_numbers()
to further simplify it.
next prev parent reply other threads:[~2017-10-20 7:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 23:01 [PATCH v5 0/3] PCI/portdrv: Fix MSI/MSI-X bug for PCIe port service drivers Bjorn Helgaas
2017-10-19 23:01 ` [PATCH v5 1/3] PCI/portdrv: Add #defines for AER and DPC Interrupt Message Number masks Bjorn Helgaas
2017-10-20 7:06 ` Christoph Hellwig
2017-10-19 23:01 ` [PATCH v5 2/3] PCI/portdrv: Remove excessive comments Bjorn Helgaas
2017-10-20 7:07 ` Christoph Hellwig
2017-10-20 13:31 ` Bjorn Helgaas
2017-10-20 13:37 ` Christoph Hellwig
2017-10-19 23:01 ` [PATCH v5 3/3] PCI/portdrv: Compute MSI/MSI-X IRQ vectors after final allocation Bjorn Helgaas
2017-10-20 7:15 ` Christoph Hellwig [this message]
2017-10-20 13:36 ` Bjorn Helgaas
2017-10-20 8:20 ` [PATCH v5 0/3] PCI/portdrv: Fix MSI/MSI-X bug for PCIe port service drivers Dongdong Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171020071550.GE11101@lst.de \
--to=hch@lst.de \
--cc=charles.chenxin@huawei.com \
--cc=gabriele.paoloni@huawei.com \
--cc=helgaas@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=liudongdong3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.