From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Pierre-Hugues Husson <phh@phh.me>
Cc: linux-rockchip@lists.infradead.org, linux-media@vger.kernel.org,
heiko@sntech.de, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] drm: bridge: synopsys/dw-hdmi: Enable cec clock
Date: Fri, 20 Oct 2017 09:12:04 +0100 [thread overview]
Message-ID: <20171020081203.GD20805@n2100.armlinux.org.uk> (raw)
In-Reply-To: <20171013225337.5196-2-phh@phh.me>
On Sat, Oct 14, 2017 at 12:53:35AM +0200, Pierre-Hugues Husson wrote:
> @@ -2382,6 +2383,18 @@ __dw_hdmi_probe(struct platform_device *pdev,
> goto err_isfr;
> }
>
> + hdmi->cec_clk = devm_clk_get(hdmi->dev, "cec");
> + if (IS_ERR(hdmi->cec_clk)) {
> + hdmi->cec_clk = NULL;
What if devm_clk_get() returns EPROBE_DEFER? Does that really mean the
clock does not exist?
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up
According to speedtest.net: 8.21Mbps down 510kbps up
WARNING: multiple messages have this Message-ID (diff)
From: linux@armlinux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] drm: bridge: synopsys/dw-hdmi: Enable cec clock
Date: Fri, 20 Oct 2017 09:12:04 +0100 [thread overview]
Message-ID: <20171020081203.GD20805@n2100.armlinux.org.uk> (raw)
In-Reply-To: <20171013225337.5196-2-phh@phh.me>
On Sat, Oct 14, 2017 at 12:53:35AM +0200, Pierre-Hugues Husson wrote:
> @@ -2382,6 +2383,18 @@ __dw_hdmi_probe(struct platform_device *pdev,
> goto err_isfr;
> }
>
> + hdmi->cec_clk = devm_clk_get(hdmi->dev, "cec");
> + if (IS_ERR(hdmi->cec_clk)) {
> + hdmi->cec_clk = NULL;
What if devm_clk_get() returns EPROBE_DEFER? Does that really mean the
clock does not exist?
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up
According to speedtest.net: 8.21Mbps down 510kbps up
next prev parent reply other threads:[~2017-10-20 8:12 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-13 22:53 [PATCH 0/3] Enable CEC on rk3399 Pierre-Hugues Husson
2017-10-13 22:53 ` Pierre-Hugues Husson
2017-10-13 22:53 ` [PATCH 1/3] drm: bridge: synopsys/dw-hdmi: Enable cec clock Pierre-Hugues Husson
2017-10-13 22:53 ` Pierre-Hugues Husson
2017-10-14 0:18 ` Fabio Estevam
2017-10-14 0:18 ` Fabio Estevam
2017-10-14 13:21 ` Pierre-Hugues Husson
2017-10-14 13:21 ` Pierre-Hugues Husson
2017-10-14 13:41 ` Fabio Estevam
2017-10-14 13:41 ` Fabio Estevam
2017-10-14 8:16 ` Hans Verkuil
2017-10-14 8:16 ` Hans Verkuil
2017-10-20 7:25 ` Hans Verkuil
2017-10-20 7:25 ` Hans Verkuil
2017-10-20 8:12 ` Russell King - ARM Linux [this message]
2017-10-20 8:12 ` Russell King - ARM Linux
2017-10-20 19:21 ` Pierre-Hugues Husson
2017-10-20 19:21 ` Pierre-Hugues Husson
2017-10-13 22:53 ` [PATCH 2/3] arm64: dts: rockchip: add the cec clk for dw-mipi-hdmi on rk3399 Pierre-Hugues Husson
2017-10-13 22:53 ` Pierre-Hugues Husson
2017-10-15 12:13 ` Heiko Stuebner
2017-10-15 12:13 ` Heiko Stuebner
2017-10-13 22:53 ` [PATCH 3/3] arm64: dts: rockchip: enable cec pin for rk3399 firefly Pierre-Hugues Husson
2017-10-13 22:53 ` Pierre-Hugues Husson
2017-10-15 12:13 ` Heiko Stuebner
2017-10-15 12:13 ` Heiko Stuebner
2017-10-14 8:23 ` [PATCH 0/3] Enable CEC on rk3399 Hans Verkuil
2017-10-14 8:23 ` Hans Verkuil
2017-10-14 13:14 ` Pierre-Hugues Husson
2017-10-14 13:14 ` Pierre-Hugues Husson
2017-10-14 14:52 ` Heiko Stuebner
2017-10-14 14:52 ` Heiko Stuebner
2017-10-14 15:39 ` [PATCH] pinctrl: rockchip: Add iomux-route switching support for rk3288 Heiko Stuebner
2017-10-14 15:39 ` Heiko Stuebner
2017-10-20 7:28 ` Hans Verkuil
2017-10-20 7:28 ` Hans Verkuil
2017-10-20 7:38 ` Heiko Stübner
2017-10-20 7:38 ` Heiko Stübner
2017-10-20 7:44 ` Hans Verkuil
2017-10-20 7:44 ` Hans Verkuil
[not found] ` <68b8765d-3d55-3fdd-e23e-776e978c38bd-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org>
2017-10-20 16:58 ` Heiko Stübner
2017-10-20 16:58 ` Heiko Stübner
2017-10-20 16:58 ` Heiko Stübner
2017-10-15 10:31 ` [PATCH 0/3] Enable CEC on rk3399 Hans Verkuil
2017-10-15 10:31 ` Hans Verkuil
[not found] ` <4592c26c-3aab-ba86-7e70-de0cac1e2e71-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org>
2017-10-15 11:13 ` Heiko Stuebner
2017-10-15 11:13 ` Heiko Stuebner
2017-10-15 11:13 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171020081203.GD20805@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=phh@phh.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.