From: Florian Westphal <fw@strlen.de>
To: Phil Sutter <phil@nwl.cc>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>, netfilter-devel@vger.kernel.org
Subject: Re: [iptables PATCH] libxt_recent: Remove ineffective checks for info->name
Date: Fri, 20 Oct 2017 13:54:52 +0200 [thread overview]
Message-ID: <20171020115452.GF16796@breakpoint.cc> (raw)
In-Reply-To: <20171020112436.17679-1-phil@nwl.cc>
Phil Sutter <phil@nwl.cc> wrote:
> In struct xt_recent_mtinfo{,_v1}, field 'name' is an array, not a
> pointer. So there is no point in comparing it against NULL. Changing the
> check to make sure it's content is not an empty string is pointless
> either, since a non-empty default string is used and the argument parser
> will refuse empty strings as --name argument. So simply get rid of the
> checks altogether.
Right, applied.
prev parent reply other threads:[~2017-10-20 11:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-20 11:24 [iptables PATCH] libxt_recent: Remove ineffective checks for info->name Phil Sutter
2017-10-20 11:54 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171020115452.GF16796@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.