From mboxrd@z Thu Jan 1 00:00:00 1970 From: Petr Mladek Date: Fri, 20 Oct 2017 13:25:44 +0000 Subject: Re: [PATCHv3 1/7] switch dereference_function_descriptor() to `unsigned long' Message-Id: <20171020132544.GA13783@pathway.suse.cz> List-Id: References: <20170930025319.987-1-sergey.senozhatsky@gmail.com> <20170930025319.987-2-sergey.senozhatsky@gmail.com> <20171004082414.GC20084@pathway.suse.cz> <20171019065004.GF449@jagdpanzerIV> In-Reply-To: <20171019065004.GF449@jagdpanzerIV> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Sergey Senozhatsky Cc: Sergey Senozhatsky , Steven Rostedt , Tony Luck , Fenghua Yu , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , James Bottomley , Helge Deller , Andrew Morton , Jessica Yu , Alexei Starovoitov , linux-ia64@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org On Thu 2017-10-19 15:50:04, Sergey Senozhatsky wrote: > On (10/04/17 10:24), Petr Mladek wrote: > [..] > > To make it clear. All these comments are not a big deal and I do > > not want to invalidate all the acked-by and tested-by just because > > of them. > > > > But please, consider removing this change if we need to do > > another iteration of this patchset. IMHO, there is no real win > > and it would just pollute the git history. > > I tend to rather keep it. would that cause any problems on your side? > it saves a ton of ugly casts later in the patch set and lets us to drop > some casts from the modules code/etc. the patch is here because otherwise > I had to add a bunch of new casts. OK, let's keep it. Best Regards, Petr From mboxrd@z Thu Jan 1 00:00:00 1970 From: Petr Mladek Subject: Re: [PATCHv3 1/7] switch dereference_function_descriptor() to `unsigned long' Date: Fri, 20 Oct 2017 15:25:44 +0200 Message-ID: <20171020132544.GA13783@pathway.suse.cz> References: <20170930025319.987-1-sergey.senozhatsky@gmail.com> <20170930025319.987-2-sergey.senozhatsky@gmail.com> <20171004082414.GC20084@pathway.suse.cz> <20171019065004.GF449@jagdpanzerIV> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Sergey Senozhatsky , Steven Rostedt , Tony Luck , Fenghua Yu , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , James Bottomley , Helge Deller , Andrew Morton , Jessica Yu , Alexei Starovoitov , linux-ia64@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org To: Sergey Senozhatsky Return-path: In-Reply-To: <20171019065004.GF449@jagdpanzerIV> List-ID: List-Id: linux-parisc.vger.kernel.org On Thu 2017-10-19 15:50:04, Sergey Senozhatsky wrote: > On (10/04/17 10:24), Petr Mladek wrote: > [..] > > To make it clear. All these comments are not a big deal and I do > > not want to invalidate all the acked-by and tested-by just because > > of them. > > > > But please, consider removing this change if we need to do > > another iteration of this patchset. IMHO, there is no real win > > and it would just pollute the git history. > > I tend to rather keep it. would that cause any problems on your side? > it saves a ton of ugly casts later in the patch set and lets us to drop > some casts from the modules code/etc. the patch is here because otherwise > I had to add a bunch of new casts. OK, let's keep it. Best Regards, Petr