All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Sherry Yang <sherryy@android.com>
Cc: linux-kernel@vger.kernel.org,
	"open list:ANDROID DRIVERS" <devel@driverdev.osuosl.org>,
	"Arve Hjønnevåg" <arve@android.com>,
	"Riley Andrews" <riandrews@android.com>,
	maco@google.com, tkjos@google.com
Subject: Re: [PATCH 2/2] android: binder: Don't get mm from task
Date: Fri, 20 Oct 2017 15:41:53 +0200	[thread overview]
Message-ID: <20171020134153.GA4120@kroah.com> (raw)
In-Reply-To: <20170916051158.96588-3-sherryy@android.com>

On Sat, Sep 16, 2017 at 01:11:57AM -0400, Sherry Yang wrote:
> Use binder_alloc struct's mm_struct rather than getting
> a reference to the mm struct through get_task_mm to
> avoid a potential deadlock between lru lock, task lock and
> dentry lock, since a thread can be holding the task lock
> and the dentry lock while trying to acquire the lru lock.
> 
> Acked-by: Arve Hjønnevåg <arve@android.com>
> Signed-off-by: Sherry Yang <sherryy@android.com>
> ---
>  drivers/android/binder_alloc.c | 22 +++++++++-------------
>  drivers/android/binder_alloc.h |  1 -
>  2 files changed, 9 insertions(+), 14 deletions(-)

This seems to be needed for 4.14-final, so can you refresh it against my
char-misc-linus branch and resend it?

thanks,

greg k-h

      parent reply	other threads:[~2017-10-20 13:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-16  5:11 [PATCH 0/2] android: binder: resolve lru, dentry and task deadlock Sherry Yang
2017-09-16  5:11 ` [PATCH 1/2] android: binder: Remove unused vma argument Sherry Yang
2017-09-16  5:11 ` [PATCH 2/2] android: binder: Don't get mm from task Sherry Yang
2017-10-06 20:12   ` Make binder shrinker static and fix null dereference Sherry Yang
2017-10-06 20:12     ` [PATCH 1/2] android: binder: Change binder_shrinker to static Sherry Yang
2017-10-06 20:12     ` [PATCH 2/2] android: binder: Fix null ptr dereference in debug msg Sherry Yang
2017-10-20 13:42       ` Greg Kroah-Hartman
2017-10-20 13:41   ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171020134153.GA4120@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arve@android.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maco@google.com \
    --cc=riandrews@android.com \
    --cc=sherryy@android.com \
    --cc=tkjos@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.