From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753235AbdJTQvV (ORCPT ); Fri, 20 Oct 2017 12:51:21 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:39850 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752838AbdJTQvU (ORCPT ); Fri, 20 Oct 2017 12:51:20 -0400 Date: Fri, 20 Oct 2017 09:51:15 -0700 From: "Paul E. McKenney" To: Will Deacon Cc: kbuild test robot , kbuild-all@01.org, linux-kernel@vger.kernel.org Subject: Re: [rcu:rcu/alpha 1/19] arch/sparc/include/asm/ptrace.h:102:6: error: implicit declaration of function 'unlikely' Reply-To: paulmck@linux.vnet.ibm.com References: <201710200544.b2SdiflF%fengguang.wu@intel.com> <20171020093636.GB18282@arm.com> <20171020163907.GH3521@linux.vnet.ibm.com> <20171020164321.GB7287@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171020164321.GB7287@arm.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-GCONF: 00 x-cbid: 17102016-0056-0000-0000-000003DCA5E8 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00007925; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000239; SDB=6.00933936; UDB=6.00470456; IPR=6.00714224; BA=6.00005651; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00017629; XFM=3.00000015; UTC=2017-10-20 16:51:17 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17102016-0057-0000-0000-00000813AEA1 Message-Id: <20171020165115.GL3521@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-10-20_09:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1710200234 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 20, 2017 at 05:43:22PM +0100, Will Deacon wrote: > On Fri, Oct 20, 2017 at 09:39:07AM -0700, Paul E. McKenney wrote: > > On Fri, Oct 20, 2017 at 10:36:37AM +0100, Will Deacon wrote: > > > On Fri, Oct 20, 2017 at 05:17:54AM +0800, kbuild test robot wrote: > > > > In file included from arch/sparc/include/asm/processor_64.h:18:0, > > > > from arch/sparc/include/asm/processor.h:4, > > > > from include/linux/prefetch.h:14, > > > > from drivers/net/ethernet/emulex/benet/be_main.c:18: > > > > arch/sparc/include/asm/ptrace.h: In function 'regs_get_register': > > > > >> arch/sparc/include/asm/ptrace.h:102:6: error: implicit declaration of function 'unlikely' [-Werror=implicit-function-declaration] > > > > if (unlikely(offset >= MAX_REG_OFFSET)) > > > > ^~~~~~~~ > > > > cc1: some warnings being treated as errors > > > > > > I'm not sure why I didn't get these reports from my tree, but there's a > > > fixup patch below. > > > > There is some RANDCONFIG action in kbuild test robot, so your mileage > > can vary. Thank you for the fix, please see below. > > True, I forgot about that. > > > > --->8 > > > > > > >From db5984f0878a013857299acd7e0fa406905d973c Mon Sep 17 00:00:00 2001 > > > From: Will Deacon > > > Date: Fri, 20 Oct 2017 10:21:18 +0100 > > > Subject: [PATCH] sparc64: ptrace: Include linux/compiler.h for unlikely() > > > > > > Compiler.g is no longer implicitly included in asm/ptrace.h so pull it > > > in explicitly to get a definition for the unlikely() macro. > > > > > > Reported-by: kbuild test robot > > > Signed-off-by: Will Deacon > > > --- > > > arch/sparc/include/asm/ptrace.h | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/arch/sparc/include/asm/ptrace.h b/arch/sparc/include/asm/ptrace.h > > > index d73428e4333c..b383484edcd3 100644 > > > --- a/arch/sparc/include/asm/ptrace.h > > > +++ b/arch/sparc/include/asm/ptrace.h > > > @@ -6,6 +6,7 @@ > > > #if defined(__sparc__) && defined(__arch64__) > > > #ifndef __ASSEMBLY__ > > > > > > +#include > > > #include > > > #include > > > > I folded this into your first commit ("linux/compiler.h: Split into > > compiler.h and compiler-types.h") like so. Does that work for you? > > Yes, thanks! There's another fix for arch/um/ too (I replied to it this > morning). Apologies, I did apply them out of order. One of those mornings, I guess! Thanx, Paul