* [PATCH] mm: list_lru: mark expected switch fall-through
@ 2017-10-20 19:07 ` Gustavo A. R. Silva
0 siblings, 0 replies; 2+ messages in thread
From: Gustavo A. R. Silva @ 2017-10-20 19:07 UTC (permalink / raw)
To: linux-mm; +Cc: linux-kernel, Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
This code was tested by compilation only (GCC 7.2.0 was used).
Please, verify if the actual intention of the code is to fall through.
mm/list_lru.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/mm/list_lru.c b/mm/list_lru.c
index f8c7de8..278db98 100644
--- a/mm/list_lru.c
+++ b/mm/list_lru.c
@@ -222,6 +222,7 @@ __list_lru_walk_one(struct list_lru *lru, int nid, int memcg_idx,
switch (ret) {
case LRU_REMOVED_RETRY:
assert_spin_locked(&nlru->lock);
+ /* fall through */
case LRU_REMOVED:
isolated++;
nlru->nr_items--;
--
2.7.4
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 2+ messages in thread* [PATCH] mm: list_lru: mark expected switch fall-through
@ 2017-10-20 19:07 ` Gustavo A. R. Silva
0 siblings, 0 replies; 2+ messages in thread
From: Gustavo A. R. Silva @ 2017-10-20 19:07 UTC (permalink / raw)
To: linux-mm; +Cc: linux-kernel, Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
This code was tested by compilation only (GCC 7.2.0 was used).
Please, verify if the actual intention of the code is to fall through.
mm/list_lru.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/mm/list_lru.c b/mm/list_lru.c
index f8c7de8..278db98 100644
--- a/mm/list_lru.c
+++ b/mm/list_lru.c
@@ -222,6 +222,7 @@ __list_lru_walk_one(struct list_lru *lru, int nid, int memcg_idx,
switch (ret) {
case LRU_REMOVED_RETRY:
assert_spin_locked(&nlru->lock);
+ /* fall through */
case LRU_REMOVED:
isolated++;
nlru->nr_items--;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-20 19:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-20 19:07 [PATCH] mm: list_lru: mark expected switch fall-through Gustavo A. R. Silva
2017-10-20 19:07 ` Gustavo A. R. Silva
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.