All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Akira Yokosawa <akiyks@gmail.com>
Cc: perfbook@vger.kernel.org
Subject: Re: [PATCH] styleguide: Reflect recent conversion of code snippets to listing
Date: Fri, 20 Oct 2017 16:55:24 -0700	[thread overview]
Message-ID: <20171020235524.GJ3521@linux.vnet.ibm.com> (raw)
In-Reply-To: <253df301-c11e-ca4d-9187-81aef7ee641c@gmail.com>

On Sat, Oct 21, 2017 at 01:31:51AM +0900, Akira Yokosawa wrote:
> On 2017/10/19 16:59:15 -0700, Paul E. McKenney wrote:
> > On Fri, Oct 20, 2017 at 07:46:16AM +0900, Akira Yokosawa wrote:
> >> >From cf16d20dff9bf4cf2832c1fdd1fe00b39c4836fd Mon Sep 17 00:00:00 2001
> >> From: Akira Yokosawa <akiyks@gmail.com>
> >> Date: Fri, 20 Oct 2017 07:16:48 +0900
> >> Subject: [PATCH] styleguide: Reflect recent conversion of code snippets to listing
> >>
> >> Also use a different approach to reduce skips of table captions.
> >> By setting a smaller value to \abovecaptionskip, captions of tables
> >> and figures can be made closer to the body regardless of their
> >> positions and avoid ambiguity of them to look like captions
> >> to other nearby tables/figures.
> >>
> >> In the experimental tables, a negative value is still set
> >> to \abovetopsep to further reduce the skips.
> >>
> >> As options of \captionsetup{} related to vertical spacing are
> >> ignored in captions controlled by the "float" package, remove them.
> >>
> >> Signed-off-by: Akira Yokosawa <akiyks@gmail.com>
> > 
> > Applied and pushed, thank you!
> 
> So, looks like you are almost ready for the upcoming release.
> I'm preparing a patch to add a make target to move table captions to the top
> throughout perfbook.
> Would you like to see such a patch before the upcoming release?

That would be very good!

> And I have a reminder for you.
> 
> You might want to update the "Roadmap" section in Chapter 1 to mention
> new Chapter 15. Style Guide can be ignored for the moment.

Good catch, you know me too well!  ;-)

I am also merging the "rt" chapter into the "advsync" chapter, but I
do not believe that there are any tables there, so that should not
conflict with your work.

							Thanx, Paul

> Thoughts?
> 
>      Thanks, Akira
> 
> > 
> > 							Thanx, Paul
> > 
> [...]
> 


  reply	other threads:[~2017-10-20 23:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-19 22:46 [PATCH] styleguide: Reflect recent conversion of code snippets to listing Akira Yokosawa
2017-10-19 23:59 ` Paul E. McKenney
2017-10-20 16:31   ` Akira Yokosawa
2017-10-20 23:55     ` Paul E. McKenney [this message]
2017-10-21  0:05       ` Akira Yokosawa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171020235524.GJ3521@linux.vnet.ibm.com \
    --to=paulmck@linux.vnet.ibm.com \
    --cc=akiyks@gmail.com \
    --cc=perfbook@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.