From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] linux: Deselect all unconfigured compression options
Date: Sat, 21 Oct 2017 22:40:23 +0200 [thread overview]
Message-ID: <20171021204023.GH7022@scaer> (raw)
In-Reply-To: <20171021193848.ca2hamhrfoowntke@xdna.net>
Cam, All,
On 2017-10-22 06:38 +1100, Cam Hutchison spake thusly:
> Yann E. MORIN wrote:
> > On 2017-10-19 21:59 +1100, Cam Hutchison spake thusly:
[--SNIP--]
> > > @@ -252,7 +252,7 @@ endif
> > > define LINUX_KCONFIG_FIXUP_CMDS
> > > $(if $(LINUX_NEEDS_MODULES),
> > > $(call KCONFIG_ENABLE_OPT,CONFIG_MODULES,$(@D)/.config))
> > > - $(call KCONFIG_ENABLE_OPT,$(LINUX_COMPRESSION_OPT_y),$(@D)/.config)
> > > + $(call KCONFIG_ENABLE_OPT,$(strip $(LINUX_COMPRESSION_OPT_y)),$(@D)/.config)
> > I think the strip is not needed, because leading spaces in arguments to
> > a call are anyway stripped.
> Actually, that's not true. I did need the strip, otherwise the var had a
> space in the output.
>
> The GNU make docs have this to say about $(call):
>
> A final caution: be careful when adding whitespace to the arguments
> to call. As with other functions, any whitespace contained in the
> second and subsequent arguments is kept; this can cause strange
> effects. It?s generally safest to remove all extraneous whitespace
> when providing parameters to call.
Right, I forgot about that one. Thanks!
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2017-10-21 20:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 10:59 [Buildroot] [PATCH 1/1] linux: Deselect all unconfigured compression options Cam Hutchison
2017-10-21 18:18 ` Yann E. MORIN
2017-10-21 19:38 ` Cam Hutchison
2017-10-21 20:40 ` Yann E. MORIN [this message]
2017-10-21 18:22 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171021204023.GH7022@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.