From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout4.zoneedit.com (mailout4.zoneedit.com [64.68.198.17]) by mail.openembedded.org (Postfix) with ESMTP id 3C086605BA for ; Sun, 22 Oct 2017 09:56:09 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mailout4.zoneedit.com (Postfix) with ESMTP id 37C8D209AE; Sun, 22 Oct 2017 09:56:11 +0000 (UTC) Received: from mailout4.zoneedit.com ([127.0.0.1]) by localhost (zmo03-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mQmhhhJiZKLH; Sun, 22 Oct 2017 09:56:11 +0000 (UTC) Received: from mail.denix.org (pool-100-15-85-143.washdc.fios.verizon.net [100.15.85.143]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mailout4.zoneedit.com (Postfix) with ESMTPSA id 0D6BB2088D; Sun, 22 Oct 2017 09:56:09 +0000 (UTC) Received: by mail.denix.org (Postfix, from userid 1000) id 86C58162706; Sun, 22 Oct 2017 05:56:08 -0400 (EDT) Date: Sun, 22 Oct 2017 05:56:08 -0400 From: Denys Dmytriyenko To: Martin Jansa Message-ID: <20171022095608.GS9221@denix.org> References: <1508352164-79210-1-git-send-email-denis@denix.org> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Cc: openembedded-devel , Denys Dmytriyenko Subject: Re: [meta-qt5][PATCH v2] qt5-ptest.inc: fix qtxmlpatterns:do_install_ptest out-of-order call X-BeenThere: openembedded-devel@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Using the OpenEmbedded metadata to build Distributions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Oct 2017 09:56:10 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline I've seen some breakage, not exactly this one, when trying to build with this change - had to clean sstate for some reason, then it worked... On Sat, Oct 21, 2017 at 12:54:41AM +0200, Martin Jansa wrote: > Either this or the objcopy change seems to cause: > http://errors.yoctoproject.org/Errors/Details/157417/ > > On Wed, Oct 18, 2017 at 8:42 PM, Denys Dmytriyenko wrote: > > > From: Denys Dmytriyenko > > > > ptest.bbclass provides a set of standard do_*_ptest_base tasks. Each of > > them calls a corresponding regular do_*_ptest task, that components are > > supposed to override for own implementation. When PTEST_ENABLED is not > > set, an anonymous python function removes all do_*_ptest_base tasks from > > the queue. qt5-ptest.inc adds a special case for do_populate_sysroot and > > re-arranges the order or ptest tasks due to that. But, unfortunately, > > do_install_ptest was added directly, not do_install_ptest_base, hence when > > "ptest" is disabled and all other do_*_ptest_base tasks are removed, this > > one do_install_ptest task is left w/o dependencies and gets scheduled for > > execution very early on, even before pseudo-native gets built and stages > > "fakeroot" functionality. The fix is to add do_install_ptest_base task, > > which calls do_install_ptest only when "ptest" is enabled. > > > > Signed-off-by: Denys Dmytriyenko > > --- > > v2 - fix circular dependencies, delete default do_install_ptest_base > > > > recipes-qt/qt5/qt5-ptest.inc | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/recipes-qt/qt5/qt5-ptest.inc b/recipes-qt/qt5/qt5-ptest.inc > > index 4844878..97bce88 100644 > > --- a/recipes-qt/qt5/qt5-ptest.inc > > +++ b/recipes-qt/qt5/qt5-ptest.inc > > @@ -4,8 +4,9 @@ inherit ptest > > > > addtask do_populate_sysroot after do_install before do_compile_ptest_base > > deltask do_compile_ptest_base > > -addtask do_compile_ptest_base after do_populate_sysroot before > > do_install_ptest > > -addtask do_install_ptest after do_compile_ptest_base before do_package > > +addtask do_compile_ptest_base after do_populate_sysroot before > > do_install_ptest_base > > +deltask do_install_ptest_base > > +addtask do_install_ptest_base after do_compile_ptest_base before > > do_package > > > > do_compile_ptest() { > > cd ${S}/tests > > -- > > 2.7.4 > > > > -- > > _______________________________________________ > > Openembedded-devel mailing list > > Openembedded-devel@lists.openembedded.org > > http://lists.openembedded.org/mailman/listinfo/openembedded-devel > >