From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/4] grub2: introduce BR2_TARGET_GRUB2_CFG
Date: Sun, 22 Oct 2017 11:59:01 +0200 [thread overview]
Message-ID: <20171022115901.44ab9855@windsurf> (raw)
In-Reply-To: <20171022093842.21788-3-nunes.erico@gmail.com>
Hello,
On Sun, 22 Oct 2017 11:38:40 +0200, Erico Nunes wrote:
> This config can be used to provide a custom Grub 2 configuration file
> containing menu entries. Previously, this had to be always done by an
> external script which would overwrite the default file.
> This is backwards compatible for existing configs as the default value
> is the previously hardcoded value.
>
> Signed-off-by: Erico Nunes <nunes.erico@gmail.com>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
I think we had similar proposals in the past (but perhaps it was for
grub legacy, not grub2), and I believe our answer was that this config
file can be trivially replaced in a post-build hook or rootfs overlay,
because it is not used during the grub2 build process.
Hence a separate option is not really needed because you can already do
that easily with a post-build or a rootfs overlay.
So, I'm not saying no entirely, but I'm not sure there is really a huge
benefit in having a separate option for this.
Peter? Arnout?
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-10-22 9:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-22 9:38 [Buildroot] [PATCH 0/4] Refactor in pc defconfigs Erico Nunes
2017-10-22 9:38 ` [Buildroot] [PATCH 1/4] configs/pc: bump kernel version Erico Nunes
2017-10-22 10:30 ` Thomas Petazzoni
2017-10-22 9:38 ` [Buildroot] [PATCH 2/4] grub2: introduce BR2_TARGET_GRUB2_CFG Erico Nunes
2017-10-22 9:59 ` Thomas Petazzoni [this message]
2017-10-22 10:43 ` Arnout Vandecappelle
2017-10-22 9:38 ` [Buildroot] [PATCH 3/4] configs/pc: refactor to use genimage and grub.cfg Erico Nunes
2017-10-22 9:38 ` [Buildroot] [PATCH 4/4] board/pc: add documentation for testing with qemu Erico Nunes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171022115901.44ab9855@windsurf \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.