All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejaswi Tanikella <tejaswit@codeaurora.org>
To: netfilter-devel@vger.kernel.org, pablo@netfilter.org
Subject: [PATCH] netfilter: ipv4: Fix use-after-free in send_reset
Date: Mon, 23 Oct 2017 11:46:03 +0530	[thread overview]
Message-ID: <20171023061559.GA25493@tejaswit-linux.qualcomm.com> (raw)

niph is not updated after pskb_expand_head changes the skb head.
It still points to the freed data, which is then used to update
tot_len and checksum. This could cause use-after-free poison crash.

Update niph, if ip_route_me_harder does not fail.

Signed-off-by: Tejaswi Tanikella <tejaswit@codeaurora.org>
---
 net/ipv4/netfilter/nf_reject_ipv4.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/net/ipv4/netfilter/nf_reject_ipv4.c b/net/ipv4/netfilter/nf_reject_ipv4.c
index eeacbda..b2e0f90 100644
--- a/net/ipv4/netfilter/nf_reject_ipv4.c
+++ b/net/ipv4/netfilter/nf_reject_ipv4.c
@@ -131,6 +131,8 @@ void nf_send_reset(struct net *net, struct sk_buff *oldskb, int hook)
 
 	if (ip_route_me_harder(net, nskb, RTN_UNSPEC))
 		goto free_nskb;
+	else
+		niph = ip_hdr(nskb);
 
 	/* "Never happens" */
 	if (nskb->len > dst_mtu(skb_dst(nskb)))
-- 
1.9.1


             reply	other threads:[~2017-10-23  6:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-23  6:16 Tejaswi Tanikella [this message]
2017-11-01  0:36 ` [PATCH] netfilter: ipv4: Fix use-after-free in send_reset Pablo Neira Ayuso
2017-11-01 16:59   ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171023061559.GA25493@tejaswit-linux.qualcomm.com \
    --to=tejaswit@codeaurora.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.