All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] mpv: add support for Raspberry Pi "rpi" output
Date: Mon, 23 Oct 2017 07:44:31 +0200	[thread overview]
Message-ID: <20171023074431.75d478ed@windsurf> (raw)
In-Reply-To: <20171022172126.21775-1-mahyar.koshkouei@gmail.com>

Hello,

Thanks for this new iteration.

On Sun, 22 Oct 2017 18:21:26 +0100, Mahyar Koshkouei wrote:
> mpv now compiles with the "rpi" video driver that provides hardware
> acceleration on the Raspberry Pi.
> 
> Tested working on a Raspberry Pi 1 Model B+ and Zero.
> 
> Signed-off-by: Mahyar Koshkouei <mahyar.koshkouei@gmail.com>
> 
> ---
> Changes v1 -> v2:
>   - Changed patch to use pkgconfig (thanks to github.com/Coacher)
> ---
>  .../mpv/0003-rpi-build-Fix-linking-errors.patch    | 72 ++++++++++++++++++++++
>  package/mpv/mpv.mk                                 |  9 ++-
>  2 files changed, 80 insertions(+), 1 deletion(-)
>  create mode 100644 package/mpv/0003-rpi-build-Fix-linking-errors.patch
> 
> diff --git a/package/mpv/0003-rpi-build-Fix-linking-errors.patch b/package/mpv/0003-rpi-build-Fix-linking-errors.patch
> new file mode 100644
> index 0000000000..d1db6a51fa
> --- /dev/null
> +++ b/package/mpv/0003-rpi-build-Fix-linking-errors.patch
> @@ -0,0 +1,72 @@
> +diff --git a/waftools/checks/custom.py b/waftools/checks/custom.py

Patches must have a description and be Signed-off-by by you. Also,
since this patch has been contributed by someone else, a reference to
where the patch was found should be included.

Finally, it should be a Git formatted patch, because the upstream
project uses Git.

Could you rework this? It should then be fine to be merged.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

      reply	other threads:[~2017-10-23  5:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-22 17:21 [Buildroot] [PATCH v2] mpv: add support for Raspberry Pi "rpi" output Mahyar Koshkouei
2017-10-23  5:44 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171023074431.75d478ed@windsurf \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.