From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH] nvme-rdma: fix possible hang when issuing commands during ctrl removal
Date: Mon, 23 Oct 2017 10:23:45 +0200 [thread overview]
Message-ID: <20171023082345.GA19156@lst.de> (raw)
In-Reply-To: <1508697771-3552-1-git-send-email-sagi@grimberg.me>
On Sun, Oct 22, 2017@09:42:51PM +0300, Sagi Grimberg wrote:
> /*
> + * deleting state means that the ctrl will never accept
> + * commands again, fail it permanently.
> + */
> + if (queue->ctrl->ctrl.state == NVME_CTRL_DELETING) {
> + nvme_req(rq)->status = NVME_SC_ABORT_REQ;
> + return BLK_STS_IOERR;
What does the NVME_SC_ABORT_REQ buy us here compared to just returning
BLK_STS_IOERR as in the reconnecting case? Why can't we just merge the
two cases?
next prev parent reply other threads:[~2017-10-23 8:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-22 18:42 [PATCH] nvme-rdma: fix possible hang when issuing commands during ctrl removal Sagi Grimberg
2017-10-22 18:54 ` Sagi Grimberg
2017-10-23 8:23 ` Christoph Hellwig [this message]
2017-10-23 9:04 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171023082345.GA19156@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.