From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steffen Klassert Date: Mon, 23 Oct 2017 11:21:07 +0000 Subject: Re: [PATCH] esp6: remove redundant initialization of esph Message-Id: <20171023112107.GG3323@secunet.com> List-Id: References: <20171019130947.30950-1-colin.king@canonical.com> In-Reply-To: <20171019130947.30950-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Colin King Cc: Herbert Xu , "David S . Miller" , Alexey Kuznetsov , Hideaki YOSHIFUJI , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org On Thu, Oct 19, 2017 at 03:09:47PM +0200, Colin King wrote: > From: Colin Ian King > > The pointer esph is being initialized with a value that is never > read and then being updated. Remove the redundant initialization > and move the declaration and initializtion of esph to the local > code block. > > Cleans up clang warning: > net/ipv6/esp6.c:562:21: warning: Value stored to 'esph' during its > initialization is never read > > Signed-off-by: Colin Ian King Applied to ipsec-next, thanks! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751562AbdJWLVM (ORCPT ); Mon, 23 Oct 2017 07:21:12 -0400 Received: from a.mx.secunet.com ([62.96.220.36]:55704 "EHLO a.mx.secunet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751388AbdJWLVK (ORCPT ); Mon, 23 Oct 2017 07:21:10 -0400 Date: Mon, 23 Oct 2017 13:21:07 +0200 From: Steffen Klassert To: Colin King CC: Herbert Xu , "David S . Miller" , Alexey Kuznetsov , "Hideaki YOSHIFUJI" , , , Subject: Re: [PATCH] esp6: remove redundant initialization of esph Message-ID: <20171023112107.GG3323@secunet.com> References: <20171019130947.30950-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20171019130947.30950-1-colin.king@canonical.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-G-Data-MailSecurity-for-Exchange-State: 0 X-G-Data-MailSecurity-for-Exchange-Error: 0 X-G-Data-MailSecurity-for-Exchange-Sender: 23 X-G-Data-MailSecurity-for-Exchange-Server: d65e63f7-5c15-413f-8f63-c0d707471c93 X-EXCLAIMER-MD-CONFIG: 2c86f778-e09b-4440-8b15-867914633a10 X-G-Data-MailSecurity-for-Exchange-Guid: 3094528B-A97E-4DB7-8E6E-E1FBAA5AE9B3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 19, 2017 at 03:09:47PM +0200, Colin King wrote: > From: Colin Ian King > > The pointer esph is being initialized with a value that is never > read and then being updated. Remove the redundant initialization > and move the declaration and initializtion of esph to the local > code block. > > Cleans up clang warning: > net/ipv6/esp6.c:562:21: warning: Value stored to 'esph' during its > initialization is never read > > Signed-off-by: Colin Ian King Applied to ipsec-next, thanks!