From: Wei Liu <wei.liu2@citrix.com>
To: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Wei Liu <wei.liu2@citrix.com>,
KonradRzeszutek Wilk <konrad.wilk@oracle.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Tim Deegan <tim@xen.org>, Julien Grall <julien.grall@arm.com>,
Jan Beulich <JBeulich@suse.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH for-4.10] scripts: add a script for build testing
Date: Mon, 23 Oct 2017 13:03:59 +0100 [thread overview]
Message-ID: <20171023120359.meq2tqthj77eilpv@citrix.com> (raw)
In-Reply-To: <23021.55864.773762.856009@mariner.uk.xensource.com>
On Mon, Oct 23, 2017 at 01:02:00PM +0100, Ian Jackson wrote:
> Wei Liu writes ("Re: [PATCH for-4.10] scripts: add a script for build testing"):
> > On Mon, Oct 23, 2017 at 02:24:40AM -0600, Jan Beulich wrote:
> > > What is this startup delay intended for?
> >
> > To give user a chance to check the command -- git-rebase can be
> > destructive after all.
>
> I can't resist this bikeshed. This kind of thing is quite annoying.
> If your command might be destructive, why not fix it so that it's not
> destructive.
>
> In particular, if you:
> * check that the tree is not dirty
> * detach HEAD
I think these two checks are good.
> * reattach HEAD afterwards at least on success
This is already the case for git-rebase on success.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-10-23 12:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-20 17:32 [PATCH for-4.10] scripts: add a script for build testing Wei Liu
2017-10-23 8:24 ` Jan Beulich
2017-10-23 11:41 ` Wei Liu
2017-10-23 12:02 ` Ian Jackson
2017-10-23 12:03 ` Wei Liu [this message]
2017-10-23 12:07 ` Ian Jackson
2017-10-23 12:20 ` Wei Liu
2017-10-23 12:09 ` Jan Beulich
2017-10-23 12:15 ` Ian Jackson
2017-10-23 11:12 ` Julien Grall
2017-10-23 11:30 ` Anthony PERARD
2017-10-23 11:37 ` Anthony PERARD
2017-10-23 11:50 ` Wei Liu
2017-10-23 13:02 ` George Dunlap
2017-10-23 14:50 ` Anthony PERARD
2017-10-23 15:04 ` Wei Liu
2017-10-23 15:09 ` Ian Jackson
2017-10-23 15:11 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171023120359.meq2tqthj77eilpv@citrix.com \
--to=wei.liu2@citrix.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=julien.grall@arm.com \
--cc=konrad.wilk@oracle.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.