From: Jiri Olsa <jolsa@redhat.com>
To: "Liang, Kan" <kan.liang@intel.com>
Cc: "acme@kernel.org" <acme@kernel.org>,
"mingo@redhat.com" <mingo@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"peterz@infradead.org" <peterz@infradead.org>,
"jolsa@kernel.org" <jolsa@kernel.org>,
"wangnan0@huawei.com" <wangnan0@huawei.com>,
"hekuang@huawei.com" <hekuang@huawei.com>,
"namhyung@kernel.org" <namhyung@kernel.org>,
"alexander.shishkin@linux.intel.com"
<alexander.shishkin@linux.intel.com>,
"Hunter, Adrian" <adrian.hunter@intel.com>,
"ak@linux.intel.com" <ak@linux.intel.com>
Subject: Re: [PATCH V3 4/6] perf tools: add perf_data_file__open_tmp
Date: Mon, 23 Oct 2017 18:26:58 +0200 [thread overview]
Message-ID: <20171023162658.GA13620@krava> (raw)
In-Reply-To: <37D7C6CF3E00A74B8858931C1DB2F077537D8814@SHSMSX103.ccr.corp.intel.com>
On Mon, Oct 23, 2017 at 04:19:19PM +0000, Liang, Kan wrote:
SNIP
> > > ssize_t perf_data_file__write(struct perf_data_file *file, diff --git
> > > a/tools/perf/util/data.h b/tools/perf/util/data.h index
> > > ae510ce..892b3d5 100644
> > > --- a/tools/perf/util/data.h
> > > +++ b/tools/perf/util/data.h
> > > @@ -10,6 +10,7 @@ enum perf_data_mode {
> > >
> > > struct perf_data_file {
> > > const char *path;
> > > + char *tmp_path;
> >
> > could we add is_tmp instead of new path pointer and keep the path for the
> > name..?
>
> The 'path' is const char. I think it's not good for tmp file which
> generate the file name in real time.
then change path to 'char *' ? I just dont think having
2 name pointers for path will keep this simple
jirka
next prev parent reply other threads:[~2017-10-23 16:27 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-20 20:05 [PATCH V3 0/6] event synthesization multithreading for perf record kan.liang
2017-10-20 20:05 ` [PATCH V3 1/6] perf tools: pass thread info to process function kan.liang
2017-10-20 20:05 ` [PATCH V3 2/6] perf tools: pass thread info in event synthesization kan.liang
2017-10-20 20:05 ` [PATCH V3 3/6] perf tools: expose copyfile_offset() kan.liang
2017-10-20 20:05 ` [PATCH V3 4/6] perf tools: add perf_data_file__open_tmp kan.liang
2017-10-23 16:13 ` Jiri Olsa
2017-10-23 16:19 ` Liang, Kan
2017-10-23 16:26 ` Jiri Olsa [this message]
2017-10-23 18:05 ` Liang, Kan
2017-10-24 7:26 ` Jiri Olsa
2017-10-24 7:26 ` Jiri Olsa
2017-10-20 20:05 ` [PATCH V3 5/6] perf record: synthesize event multithreading support kan.liang
2017-10-20 20:05 ` [PATCH V3 6/6] perf record: add option to set the number of thread for event synthesize kan.liang
2017-10-23 11:48 ` [PATCH V3 0/6] event synthesization multithreading for perf record Ingo Molnar
2017-10-23 13:43 ` Liang, Kan
2017-10-23 14:25 ` acme
2017-10-23 18:45 ` Liang, Kan
2017-10-24 9:22 ` Ingo Molnar
2017-10-24 11:47 ` Jiri Olsa
2017-10-24 12:47 ` Liang, Kan
2017-10-24 12:59 ` Ingo Molnar
2017-10-24 13:08 ` Arnaldo Carvalho de Melo
2017-10-24 13:25 ` Ingo Molnar
2017-10-25 2:35 ` Namhyung Kim
2017-10-25 9:02 ` Jiri Olsa
2017-10-25 9:00 ` Jiri Olsa
2017-10-25 9:07 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171023162658.GA13620@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=hekuang@huawei.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.