From mboxrd@z Thu Jan 1 00:00:00 1970 From: will.deacon@arm.com (Will Deacon) Date: Tue, 24 Oct 2017 14:35:35 +0100 Subject: [RFC 1/3] perf tool: Introduce arch-specific supplemental perf open strerror capability In-Reply-To: <20171024030404.ec366ec2d9c38910ccd84ba5@arm.com> References: <20171024030404.ec366ec2d9c38910ccd84ba5@arm.com> Message-ID: <20171024133535.GC13445@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Oct 24, 2017 at 03:04:04AM -0500, Kim Phillips wrote: > Introduce new tools/perf/arch/*/util/evsel.c:perf_evsel__suppl_strerror() > so each arch can start to customize usability for its h/w PMU drivers. > > Signed-off-by: Kim Phillips > --- > tools/perf/arch/x86/util/Build | 1 + > tools/perf/arch/x86/util/evsel.c | 24 ++++++++++++++++++++++++ > tools/perf/util/evsel.c | 21 +++++++++++++++------ > tools/perf/util/evsel.h | 2 ++ > 4 files changed, 42 insertions(+), 6 deletions(-) > create mode 100644 tools/perf/arch/x86/util/evsel.c This looks sensible to me, although it's difficult to justify all of the parameters to perf_evsel__suppl_strerror judging by this patch alone. Will From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933280AbdJXNfh (ORCPT ); Tue, 24 Oct 2017 09:35:37 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:54964 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932321AbdJXNff (ORCPT ); Tue, 24 Oct 2017 09:35:35 -0400 Date: Tue, 24 Oct 2017 14:35:35 +0100 From: Will Deacon To: Kim Phillips Cc: Arnaldo Carvalho de Melo , linux-arm-kernel@lists.infradead.org, marc.zyngier@arm.com, mark.rutland@arm.com, tglx@linutronix.de, peterz@infradead.org, alexander.shishkin@linux.intel.com, robh@kernel.org, suzuki.poulose@arm.com, pawel.moll@arm.com, mathieu.poirier@linaro.org, mingo@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [RFC 1/3] perf tool: Introduce arch-specific supplemental perf open strerror capability Message-ID: <20171024133535.GC13445@arm.com> References: <20171024030404.ec366ec2d9c38910ccd84ba5@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171024030404.ec366ec2d9c38910ccd84ba5@arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 24, 2017 at 03:04:04AM -0500, Kim Phillips wrote: > Introduce new tools/perf/arch/*/util/evsel.c:perf_evsel__suppl_strerror() > so each arch can start to customize usability for its h/w PMU drivers. > > Signed-off-by: Kim Phillips > --- > tools/perf/arch/x86/util/Build | 1 + > tools/perf/arch/x86/util/evsel.c | 24 ++++++++++++++++++++++++ > tools/perf/util/evsel.c | 21 +++++++++++++++------ > tools/perf/util/evsel.h | 2 ++ > 4 files changed, 42 insertions(+), 6 deletions(-) > create mode 100644 tools/perf/arch/x86/util/evsel.c This looks sensible to me, although it's difficult to justify all of the parameters to perf_evsel__suppl_strerror judging by this patch alone. Will