diff for duplicates of <20171024135123.uqail7olnespun4k@linux.intel.com> diff --git a/a/1.txt b/N1/1.txt index f55069c..c47941e 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,13 +1,13 @@ On Mon, Oct 23, 2017 at 06:45:15AM -0700, Jerry Snitselaar wrote: > On Mon Oct 23 17, Jarkko Sakkinen wrote: > > On Sat, Oct 21, 2017 at 10:53:55AM +0200, Laurent Bigonville wrote: -> > > Le 14/10/17 a 10:13, Jerry Snitselaar a ecrit : +> > > Le 14/10/17 à 10:13, Jerry Snitselaar a écrit : > > > > On Wed Sep 06 17, Jarkko Sakkinen wrote: > > > > > On Fri, Sep 01, 2017 at 02:10:18PM +0200, Laurent Bigonville wrote: -> > > > > > Le 31/08/17 a 18:40, Jerry Snitselaar a ecrit : -> > > > > > > On Thu Aug 31 17, Alexander.Steffen@infineon.com wrote: -> > > > > > > > > Le 29/08/17 a 18:35, Laurent Bigonville a ecrit : -> > > > > > > > > > Le 29/08/17 a 18:00, Alexander.Steffen@infineon.com a ecrit : +> > > > > > Le 31/08/17 à 18:40, Jerry Snitselaar a écrit : +> > > > > > > On Thu Aug 31 17, Alexander.Steffen-d0qZbvYSIPpWk0Htik3J/w@public.gmane.org wrote: +> > > > > > > > > Le 29/08/17 à 18:35, Laurent Bigonville a écrit : +> > > > > > > > > > Le 29/08/17 à 18:00, Alexander.Steffen-d0qZbvYSIPpWk0Htik3J/w@public.gmane.org a écrit : > > > > > > > > > >>> An idea how to troubleshoot this? > > > > > > > > > >> Can you run git bisect on the changes between 4.11 and > > > > > > 4.12, so that @@ -21,47 +21,47 @@ On Mon, Oct 23, 2017 at 06:45:15AM -0700, Jerry Snitselaar wrote: > > > > > > > > > > > > > > > > > > e6aef069b6e97790cb127d5eeb86ae9ff0b7b0e3 is the first bad commit > > > > > > > > > commit e6aef069b6e97790cb127d5eeb86ae9ff0b7b0e3 -> > > > > > > > > Author: Jerry Snitselaar <jsnitsel@redhat.com> -> > > > > > > > > Date: Mon Mar 27 08:46:04 2017 -0700 +> > > > > > > > > Author: Jerry Snitselaar <jsnitsel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> +> > > > > > > > > Date: Mon Mar 27 08:46:04 2017 -0700 > > > > > > > > > -> > > > > > > > > tpm_tis: convert to using locality callbacks +> > > > > > > > > tpm_tis: convert to using locality callbacks > > > > > > > > > -> > > > > > > > > This patch converts tpm_tis to use of the new tpm class ops -> > > > > > > > > request_locality, and relinquish_locality. +> > > > > > > > > This patch converts tpm_tis to use of the new tpm class ops +> > > > > > > > > request_locality, and relinquish_locality. > > > > > > > > > -> > > > > > > > > With the move to using the callbacks, release_locality is +> > > > > > > > > With the move to using the callbacks, release_locality is > > > > > > > > > changed so -> > > > > > > > > that we now release the locality even if there is no +> > > > > > > > > that we now release the locality even if there is no > > > > > > > > > request pending. > > > > > > > > > -> > > > > > > > > This required some changes to the tpm_tis_core_init +> > > > > > > > > This required some changes to the tpm_tis_core_init > > > > > > code path to -> > > > > > > > > make sure locality is requested when needed: +> > > > > > > > > make sure locality is requested when needed: > > > > > > > > > -> > > > > > > > > - tpm2_probe code path will end up calling +> > > > > > > > > - tpm2_probe code path will end up calling > > > > > > > > > request/release through -> > > > > > > > > callbacks, so request_locality prior to +> > > > > > > > > callbacks, so request_locality prior to > > > > > > tpm2_probe not needed. > > > > > > > > > -> > > > > > > > > - probe_itpm makes calls to tpm_tis_send_data which no +> > > > > > > > > - probe_itpm makes calls to tpm_tis_send_data which no > > > > > > > > > longer calls -> > > > > > > > > request_locality, so add request_locality prior to +> > > > > > > > > request_locality, so add request_locality prior to > > > > > > > > > tpm_tis_send_data -> > > > > > > > > calls. Also drop release_locality call in middleof +> > > > > > > > > calls. Also drop release_locality call in middleof > > > > > > > > > probe_itpm, and -> > > > > > > > > keep locality until release_locality called at end of +> > > > > > > > > keep locality until release_locality called at end of > > > > > > > > > probe_itpm. > > > > > > > > > -> > > > > > > > > Cc: Peter Huewe <peterhuewe@gmx.de> -> > > > > > > > > Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> -> > > > > > > > > Cc: Jason Gunthorpe <jgunthorpe@obsidianresearch.com> -> > > > > > > > > Cc: Marcel Selhorst <tpmdd@selhorst.net> -> > > > > > > > > Signed-off-by: Jerry Snitselaar <jsnitsel@redhat.com> -> > > > > > > > > Reviewed-by: Jarkko Sakkinen -> > > > > > <jarkko.sakkinen@linux.intel.com> -> > > > > > > > > Tested-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> -> > > > > > > > > Signed-off-by: Jarkko Sakkinen -> > > > > > <jarkko.sakkinen@linux.intel.com> +> > > > > > > > > Cc: Peter Huewe <peterhuewe-Mmb7MZpHnFY@public.gmane.org> +> > > > > > > > > Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> +> > > > > > > > > Cc: Jason Gunthorpe <jgunthorpe@obsidianresearch.com> +> > > > > > > > > Cc: Marcel Selhorst <tpmdd-yWjUBOtONefk1uMJSBkQmQ@public.gmane.org> +> > > > > > > > > Signed-off-by: Jerry Snitselaar <jsnitsel@redhat.com> +> > > > > > > > > Reviewed-by: Jarkko Sakkinen +> > > > > > <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> +> > > > > > > > > Tested-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> +> > > > > > > > > Signed-off-by: Jarkko Sakkinen +> > > > > > <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> > > > > > > > > > > > > > > > > > > :040000 040000 70234365da69959d47076ebb40c8d17f520c3e44 > > > > > > > > > 72f21b446e45ea1003de75902b0553deb99157fd M drivers @@ -113,44 +113,44 @@ On Mon, Oct 23, 2017 at 06:45:15AM -0700, Jerry Snitselaar wrote: > > > > +++ b/drivers/char/tpm/tpm_tis_core.c > > > > @@ -258,6 +258,7 @@ static int tpm_tis_send_data(struct tpm_chip *chip, > > > > const u8 *buf, size_t len) -> > > > int rc, status, burstcnt; -> > > > size_t count = 0; -> > > > bool itpm = priv->flags & TPM_TIS_ITPM_WORKAROUND; -> > > > + u8 access; +> > > > int rc, status, burstcnt; +> > > > size_t count = 0; +> > > > bool itpm = priv->flags & TPM_TIS_ITPM_WORKAROUND; +> > > > + u8 access; > > > > -> > > > status = tpm_tis_status(chip); -> > > > if ((status & TPM_STS_COMMAND_READY) == 0) { +> > > > status = tpm_tis_status(chip); +> > > > if ((status & TPM_STS_COMMAND_READY) == 0) { > > > > @@ -292,6 +293,11 @@ static int tpm_tis_send_data(struct tpm_chip *chip, > > > > const u8 *buf, size_t len) -> > > > } -> > > > status = tpm_tis_status(chip); -> > > > if (!itpm && (status & TPM_STS_DATA_EXPECT) == 0) { -> > > > + rc = tpm_tis_read8(priv, TPM_ACCESS(priv->locality), +> > > > } +> > > > status = tpm_tis_status(chip); +> > > > if (!itpm && (status & TPM_STS_DATA_EXPECT) == 0) { +> > > > + rc = tpm_tis_read8(priv, TPM_ACCESS(priv->locality), > > > > &access); -> > > > + if (rc < 0) -> > > > + dev_info(&chip->dev, "TPM_STS_DATA_EXPECT == 0: read +> > > > + if (rc < 0) +> > > > + dev_info(&chip->dev, "TPM_STS_DATA_EXPECT == 0: read > > > > failure TPM_ACCESS(%d)\n", priv->locality); -> > > > + else -> > > > + dev_info(&chip->dev, "TPM_STS_DATA_EXPECT == 0: +> > > > + else +> > > > + dev_info(&chip->dev, "TPM_STS_DATA_EXPECT == 0: > > > > locality: %d status: %x access: %x\n", priv->locality, status, access); -> > > > rc = -EIO; -> > > > goto out_err; -> > > > } +> > > > rc = -EIO; +> > > > goto out_err; +> > > > } > > > > @@ -309,6 +315,11 @@ static int tpm_tis_send_data(struct tpm_chip *chip, > > > > const u8 *buf, size_t len) -> > > > } -> > > > status = tpm_tis_status(chip); -> > > > if (!itpm && (status & TPM_STS_DATA_EXPECT) != 0) { -> > > > + rc = tpm_tis_read8(priv, TPM_ACCESS(priv->locality), &access); -> > > > + if (rc < 0) -> > > > + dev_info(&chip->dev, "TPM_STS_DATA_EXPECT != 0: read +> > > > } +> > > > status = tpm_tis_status(chip); +> > > > if (!itpm && (status & TPM_STS_DATA_EXPECT) != 0) { +> > > > + rc = tpm_tis_read8(priv, TPM_ACCESS(priv->locality), &access); +> > > > + if (rc < 0) +> > > > + dev_info(&chip->dev, "TPM_STS_DATA_EXPECT != 0: read > > > > failure TPM_ACCESS(%d)\n", priv->locality); -> > > > + else -> > > > + dev_info(&chip->dev, "TPM_STS_DATA_EXPECT != 0: locality: +> > > > + else +> > > > + dev_info(&chip->dev, "TPM_STS_DATA_EXPECT != 0: locality: > > > > %d status: %x access: %x\n", priv->locality, status, access); -> > > > rc = -EIO; -> > > > goto out_err; -> > > > } +> > > > rc = -EIO; +> > > > goto out_err; +> > > > } > > > > > > Please find here the dmesg output of the patched kernel > > @@ -176,3 +176,7 @@ should never be set. So we can conclude that TPM might be either 2. In some transition state? /Jarkko + +------------------------------------------------------------------------------ +Check out the vibrant tech community on one of the world's most +engaging tech sites, Slashdot.org! http://sdm.link/slashdot diff --git a/a/content_digest b/N1/content_digest index 6361195..985dfab 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -8,26 +8,24 @@ "ref\0b63b765d-2477-d9fe-9d80-c2ea7e582bce@debian.org\0" "ref\020171023132346.jbqgokwv3ah2oqjo@linux.intel.com\0" "ref\020171023134515.56siz3m6lhrhnovv@rhwork\0" - "From\0Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>\0" - "Subject\0Re: [tpmdd-devel] tpm device not showing up in /dev anymore\0" + "From\0Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>\0" + "Subject\0Re: tpm device not showing up in /dev anymore\0" "Date\0Tue, 24 Oct 2017 15:51:23 +0200\0" - "To\0Jerry Snitselaar <jsnitsel@redhat.com>\0" - "Cc\0Laurent Bigonville <bigon@debian.org>" - Alexander.Steffen@infineon.com - tpmdd-devel@lists.sourceforge.net - " linux-integrity@vger.kernel.org\0" + "To\0Jerry Snitselaar <jsnitsel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>\0" + "Cc\0linux-integrity-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" + " tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org\0" "\00:1\0" "b\0" "On Mon, Oct 23, 2017 at 06:45:15AM -0700, Jerry Snitselaar wrote:\n" "> On Mon Oct 23 17, Jarkko Sakkinen wrote:\n" "> > On Sat, Oct 21, 2017 at 10:53:55AM +0200, Laurent Bigonville wrote:\n" - "> > > Le 14/10/17 a 10:13, Jerry Snitselaar a ecrit :\n" + "> > > Le 14/10/17 \303\240 10:13, Jerry Snitselaar a \303\251crit\302\240:\n" "> > > > On Wed Sep 06 17, Jarkko Sakkinen wrote:\n" "> > > > > On Fri, Sep 01, 2017 at 02:10:18PM +0200, Laurent Bigonville wrote:\n" - "> > > > > > Le 31/08/17 a 18:40, Jerry Snitselaar a ecrit :\n" - "> > > > > > > On Thu Aug 31 17, Alexander.Steffen@infineon.com wrote:\n" - "> > > > > > > > > Le 29/08/17 a 18:35, Laurent Bigonville a ecrit :\n" - "> > > > > > > > > > Le 29/08/17 a 18:00, Alexander.Steffen@infineon.com a ecrit :\n" + "> > > > > > Le 31/08/17 \303\240 18:40, Jerry Snitselaar a \303\251crit\302\240:\n" + "> > > > > > > On Thu Aug 31 17, Alexander.Steffen-d0qZbvYSIPpWk0Htik3J/w@public.gmane.org wrote:\n" + "> > > > > > > > > Le 29/08/17 \303\240 18:35, Laurent Bigonville a \303\251crit\302\240:\n" + "> > > > > > > > > > Le 29/08/17 \303\240 18:00, Alexander.Steffen-d0qZbvYSIPpWk0Htik3J/w@public.gmane.org a \303\251crit\302\240:\n" "> > > > > > > > > >>> An idea how to troubleshoot this?\n" "> > > > > > > > > >> Can you run git bisect on the changes between 4.11 and\n" "> > > > > > 4.12, so that\n" @@ -41,47 +39,47 @@ "> > > > > > > > >\n" "> > > > > > > > > e6aef069b6e97790cb127d5eeb86ae9ff0b7b0e3 is the first bad commit\n" "> > > > > > > > > commit e6aef069b6e97790cb127d5eeb86ae9ff0b7b0e3\n" - "> > > > > > > > > Author: Jerry Snitselaar <jsnitsel@redhat.com>\n" - "> > > > > > > > > Date: Mon Mar 27 08:46:04 2017 -0700\n" + "> > > > > > > > > Author: Jerry Snitselaar <jsnitsel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>\n" + "> > > > > > > > > Date:\302\240\302\240 Mon Mar 27 08:46:04 2017 -0700\n" "> > > > > > > > >\n" - "> > > > > > > > > tpm_tis: convert to using locality callbacks\n" + "> > > > > > > > > \302\240\302\240\302\240\302\240 tpm_tis: convert to using locality callbacks\n" "> > > > > > > > >\n" - "> > > > > > > > > This patch converts tpm_tis to use of the new tpm class ops\n" - "> > > > > > > > > request_locality, and relinquish_locality.\n" + "> > > > > > > > > \302\240\302\240\302\240\302\240 This patch converts tpm_tis to use of the new tpm class ops\n" + "> > > > > > > > > \302\240\302\240\302\240\302\240 request_locality, and relinquish_locality.\n" "> > > > > > > > >\n" - "> > > > > > > > > With the move to using the callbacks, release_locality is\n" + "> > > > > > > > > \302\240\302\240\302\240\302\240 With the move to using the callbacks, release_locality is\n" "> > > > > > > > > changed so\n" - "> > > > > > > > > that we now release the locality even if there is no\n" + "> > > > > > > > > \302\240\302\240\302\240\302\240 that we now release the locality even if there is no\n" "> > > > > > > > > request pending.\n" "> > > > > > > > >\n" - "> > > > > > > > > This required some changes to the tpm_tis_core_init\n" + "> > > > > > > > > \302\240\302\240\302\240\302\240 This required some changes to the tpm_tis_core_init\n" "> > > > > > code path to\n" - "> > > > > > > > > make sure locality is requested when needed:\n" + "> > > > > > > > > \302\240\302\240\302\240\302\240 make sure locality is requested when needed:\n" "> > > > > > > > >\n" - "> > > > > > > > > - tpm2_probe code path will end up calling\n" + "> > > > > > > > > \302\240\302\240\302\240\302\240\302\240\302\240 - tpm2_probe code path will end up calling\n" "> > > > > > > > > request/release through\n" - "> > > > > > > > > callbacks, so request_locality prior to\n" + "> > > > > > > > > \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240 callbacks, so request_locality prior to\n" "> > > > > > tpm2_probe not needed.\n" "> > > > > > > > >\n" - "> > > > > > > > > - probe_itpm makes calls to tpm_tis_send_data which no\n" + "> > > > > > > > > \302\240\302\240\302\240\302\240\302\240\302\240 - probe_itpm makes calls to tpm_tis_send_data which no\n" "> > > > > > > > > longer calls\n" - "> > > > > > > > > request_locality, so add request_locality prior to\n" + "> > > > > > > > > \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240 request_locality, so add request_locality prior to\n" "> > > > > > > > > tpm_tis_send_data\n" - "> > > > > > > > > calls. Also drop release_locality call in middleof\n" + "> > > > > > > > > \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240 calls. Also drop release_locality call in middleof\n" "> > > > > > > > > probe_itpm, and\n" - "> > > > > > > > > keep locality until release_locality called at end of\n" + "> > > > > > > > > \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240 keep locality until release_locality called at end of\n" "> > > > > > > > > probe_itpm.\n" "> > > > > > > > >\n" - "> > > > > > > > > Cc: Peter Huewe <peterhuewe@gmx.de>\n" - "> > > > > > > > > Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>\n" - "> > > > > > > > > Cc: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>\n" - "> > > > > > > > > Cc: Marcel Selhorst <tpmdd@selhorst.net>\n" - "> > > > > > > > > Signed-off-by: Jerry Snitselaar <jsnitsel@redhat.com>\n" - "> > > > > > > > > Reviewed-by: Jarkko Sakkinen\n" - "> > > > > > <jarkko.sakkinen@linux.intel.com>\n" - "> > > > > > > > > Tested-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>\n" - "> > > > > > > > > Signed-off-by: Jarkko Sakkinen\n" - "> > > > > > <jarkko.sakkinen@linux.intel.com>\n" + "> > > > > > > > > \302\240\302\240\302\240\302\240 Cc: Peter Huewe <peterhuewe-Mmb7MZpHnFY@public.gmane.org>\n" + "> > > > > > > > > \302\240\302\240\302\240\302\240 Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>\n" + "> > > > > > > > > \302\240\302\240\302\240\302\240 Cc: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>\n" + "> > > > > > > > > \302\240\302\240\302\240\302\240 Cc: Marcel Selhorst <tpmdd-yWjUBOtONefk1uMJSBkQmQ@public.gmane.org>\n" + "> > > > > > > > > \302\240\302\240\302\240\302\240 Signed-off-by: Jerry Snitselaar <jsnitsel@redhat.com>\n" + "> > > > > > > > > \302\240\302\240\302\240\302\240 Reviewed-by: Jarkko Sakkinen\n" + "> > > > > > <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>\n" + "> > > > > > > > > \302\240\302\240\302\240\302\240 Tested-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>\n" + "> > > > > > > > > \302\240\302\240\302\240\302\240 Signed-off-by: Jarkko Sakkinen\n" + "> > > > > > <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>\n" "> > > > > > > > >\n" "> > > > > > > > > :040000 040000 70234365da69959d47076ebb40c8d17f520c3e44\n" "> > > > > > > > > 72f21b446e45ea1003de75902b0553deb99157fd M drivers\n" @@ -133,44 +131,44 @@ "> > > > +++ b/drivers/char/tpm/tpm_tis_core.c\n" "> > > > @@ -258,6 +258,7 @@ static int tpm_tis_send_data(struct tpm_chip *chip,\n" "> > > > const u8 *buf, size_t len)\n" - "> > > > int rc, status, burstcnt;\n" - "> > > > size_t count = 0;\n" - "> > > > bool itpm = priv->flags & TPM_TIS_ITPM_WORKAROUND;\n" - "> > > > + u8 access;\n" + "> > > > \302\240\302\240\302\240\302\240int rc, status, burstcnt;\n" + "> > > > \302\240\302\240\302\240\302\240size_t count = 0;\n" + "> > > > \302\240\302\240\302\240\302\240bool itpm = priv->flags & TPM_TIS_ITPM_WORKAROUND;\n" + "> > > > +\302\240\302\240\302\240 u8 access;\n" "> > > >\n" - "> > > > status = tpm_tis_status(chip);\n" - "> > > > if ((status & TPM_STS_COMMAND_READY) == 0) {\n" + "> > > > \302\240\302\240\302\240\302\240status = tpm_tis_status(chip);\n" + "> > > > \302\240\302\240\302\240\302\240if ((status & TPM_STS_COMMAND_READY) == 0) {\n" "> > > > @@ -292,6 +293,11 @@ static int tpm_tis_send_data(struct tpm_chip *chip,\n" "> > > > const u8 *buf, size_t len)\n" - "> > > > }\n" - "> > > > status = tpm_tis_status(chip);\n" - "> > > > if (!itpm && (status & TPM_STS_DATA_EXPECT) == 0) {\n" - "> > > > + rc = tpm_tis_read8(priv, TPM_ACCESS(priv->locality),\n" + "> > > > \302\240\302\240\302\240\302\240\302\240\302\240\302\240 }\n" + "> > > > \302\240\302\240\302\240\302\240\302\240\302\240\302\240 status = tpm_tis_status(chip);\n" + "> > > > \302\240\302\240\302\240\302\240\302\240\302\240\302\240 if (!itpm && (status & TPM_STS_DATA_EXPECT) == 0) {\n" + "> > > > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240 rc = tpm_tis_read8(priv, TPM_ACCESS(priv->locality),\n" "> > > > &access);\n" - "> > > > + if (rc < 0)\n" - "> > > > + dev_info(&chip->dev, \"TPM_STS_DATA_EXPECT == 0: read\n" + "> > > > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240 if (rc < 0)\n" + "> > > > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240 dev_info(&chip->dev, \"TPM_STS_DATA_EXPECT == 0: read\n" "> > > > failure TPM_ACCESS(%d)\\n\", priv->locality);\n" - "> > > > + else\n" - "> > > > + dev_info(&chip->dev, \"TPM_STS_DATA_EXPECT == 0:\n" + "> > > > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240 else\n" + "> > > > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240 dev_info(&chip->dev, \"TPM_STS_DATA_EXPECT == 0:\n" "> > > > locality: %d status: %x access: %x\\n\", priv->locality, status, access);\n" - "> > > > rc = -EIO;\n" - "> > > > goto out_err;\n" - "> > > > }\n" + "> > > > \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240 rc = -EIO;\n" + "> > > > \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240 goto out_err;\n" + "> > > > \302\240\302\240\302\240\302\240\302\240\302\240\302\240 }\n" "> > > > @@ -309,6 +315,11 @@ static int tpm_tis_send_data(struct tpm_chip *chip,\n" "> > > > const u8 *buf, size_t len)\n" - "> > > > }\n" - "> > > > status = tpm_tis_status(chip);\n" - "> > > > if (!itpm && (status & TPM_STS_DATA_EXPECT) != 0) {\n" - "> > > > + rc = tpm_tis_read8(priv, TPM_ACCESS(priv->locality), &access);\n" - "> > > > + if (rc < 0)\n" - "> > > > + dev_info(&chip->dev, \"TPM_STS_DATA_EXPECT != 0: read\n" + "> > > > \302\240\302\240\302\240\302\240}\n" + "> > > > \302\240\302\240\302\240\302\240status = tpm_tis_status(chip);\n" + "> > > > \302\240\302\240\302\240\302\240if (!itpm && (status & TPM_STS_DATA_EXPECT) != 0) {\n" + "> > > > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240 rc = tpm_tis_read8(priv, TPM_ACCESS(priv->locality), &access);\n" + "> > > > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240 if (rc < 0)\n" + "> > > > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240 dev_info(&chip->dev, \"TPM_STS_DATA_EXPECT != 0: read\n" "> > > > failure TPM_ACCESS(%d)\\n\", priv->locality);\n" - "> > > > + else\n" - "> > > > + dev_info(&chip->dev, \"TPM_STS_DATA_EXPECT != 0: locality:\n" + "> > > > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240 else\n" + "> > > > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240 dev_info(&chip->dev, \"TPM_STS_DATA_EXPECT != 0: locality:\n" "> > > > %d status: %x access: %x\\n\", priv->locality, status, access);\n" - "> > > > rc = -EIO;\n" - "> > > > goto out_err;\n" - "> > > > }\n" + "> > > > \302\240\302\240\302\240\302\240\302\240\302\240\302\240 rc = -EIO;\n" + "> > > > \302\240\302\240\302\240\302\240\302\240\302\240\302\240 goto out_err;\n" + "> > > > \302\240\302\240\302\240\302\240}\n" "> > > \n" "> > > Please find here the dmesg output of the patched kernel\n" "> > \n" @@ -195,6 +193,10 @@ "1. Powered off\n" "2. In some transition state?\n" "\n" - /Jarkko + "/Jarkko\n" + "\n" + "------------------------------------------------------------------------------\n" + "Check out the vibrant tech community on one of the world's most\n" + engaging tech sites, Slashdot.org! http://sdm.link/slashdot -00e08e05a2daf02be0bf53d214c29a8b9220c29452014beaf25e94ff16c7ad87 +eb295822c7f6080cd673d44f2bb53f1ccb7839b04c350aa0b59927d8585a0989
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.