All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony PERARD <anthony.perard@citrix.com>
To: Alistair Francis <alistair.francis@xilinx.com>
Cc: qemu-devel@nongnu.org, alistair23@gmail.com, armbru@redhat.com,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [Qemu-devel] [PATCH v3 41/46] hw/xen*: Replace fprintf(stderr, "*\n" with error_report()
Date: Tue, 24 Oct 2017 15:26:55 +0100	[thread overview]
Message-ID: <20171024142655.GF1885@perard.uk.xensource.com> (raw)
In-Reply-To: <55afe994ca32715382326d5d250231bdaa836f08.1508390588.git.alistair.francis@xilinx.com>

On Thu, Oct 19, 2017 at 09:18:14AM -0700, Alistair Francis wrote:
> Replace a large number of the fprintf(stderr, "*\n" calls with
> error_report(). The functions were renamed with these commands and then
> compiler issues where manually fixed.
> 
> find ./* -type f -exec sed -i \
>     'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
>     {} +
> find ./* -type f -exec sed -i \
>     'N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
>     {} +
> find ./* -type f -exec sed -i \
>     'N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
>     {} +
> find ./* -type f -exec sed -i \
>     'N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
>     {} +
> find ./* -type f -exec sed -i \
>     'N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
>     {} +
> find ./* -type f -exec sed -i \
>     'N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
>     {} +
> find ./* -type f -exec sed -i \
>     'N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
>     {} +
> find ./* -type f -exec sed -i \
>     'N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
>     {} +
> find ./* -type f -exec sed -i \
>     'N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
>     {} +
> find ./* -type f -exec sed -i \
>     'N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
>     {} +
> find ./* -type f -exec sed -i \
>     'N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
>     {} +
> 
> Some lines where then manually tweaked to pass checkpatch.
> 
> xen_pt_log() was left with an fprintf(stderr,
> 
> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
> Cc: Stefano Stabellini <sstabellini@kernel.org>
> Cc: Anthony Perard <anthony.perard@citrix.com>

Acked-by: Anthony PERARD <anthony.perard@citrix.com>

-- 
Anthony PERARD

  reply	other threads:[~2017-10-24 14:31 UTC|newest]

Thread overview: 94+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-19 16:15 [Qemu-devel] [PATCH v3 00/46] Remove some of the fprintf(stderr, "* Alistair Francis
2017-10-19 16:15 ` [Qemu-arm] [PATCH v3 01/46] Replace all occurances of __FUNCTION__ with __func__ Alistair Francis
2017-10-19 16:15   ` Alistair Francis
2017-10-19 16:15   ` [Qemu-devel] " Alistair Francis
2017-10-24 16:15   ` Anthony PERARD
2017-10-24 16:15     ` Anthony PERARD
2017-10-24 16:15   ` Anthony PERARD
2017-10-29 13:16   ` [Qemu-arm] " Juan Quintela
2017-10-29 13:16     ` [Qemu-devel] " Juan Quintela
2017-11-07 10:12     ` Markus Armbruster
2017-11-07 10:12     ` [Qemu-arm] " Markus Armbruster
2017-11-07 10:12       ` Markus Armbruster
2017-11-07 19:41       ` Eric Blake
2017-11-07 19:41       ` [Qemu-arm] " Eric Blake
2017-11-07 19:41         ` Eric Blake
2017-11-08  7:52         ` [Qemu-arm] " Markus Armbruster
2017-11-08  7:52           ` Markus Armbruster
2017-11-08 14:51           ` Alistair Francis
2017-11-08 14:51             ` Alistair Francis
2017-11-08 15:00             ` [Qemu-arm] " Eric Blake
2017-11-08 15:00               ` Eric Blake
2017-11-08 15:26               ` [Qemu-arm] " Alistair Francis
2017-11-08 15:26                 ` Alistair Francis
2017-11-08 15:26               ` Alistair Francis
2017-11-08 15:00             ` Eric Blake
2017-11-08 14:51           ` Alistair Francis
2017-11-08  7:52         ` Markus Armbruster
2017-10-29 13:16   ` Juan Quintela
2017-10-19 16:15 ` [Qemu-devel] [PATCH v3 02/46] Fixes after renaming __FUNCTION__ to __func__ Alistair Francis
2017-10-19 16:15 ` [Qemu-devel] [PATCH v3 03/46] audio: Replace AUDIO_FUNC with __func__ Alistair Francis
2017-10-19 16:15 ` [Qemu-devel] [PATCH v3 04/46] tests: Replace fprintf(stderr, "*\n" with error_report() Alistair Francis
2017-10-19 16:15 ` [Qemu-arm] [PATCH v3 05/46] hw/arm: " Alistair Francis
2017-10-19 16:15   ` [Qemu-devel] " Alistair Francis
2017-10-19 16:15 ` [Qemu-devel] [PATCH v3 06/46] hw/block: " Alistair Francis
2017-10-19 16:16 ` [Qemu-devel] [PATCH v3 07/46] hw/bt: " Alistair Francis
2017-10-19 16:16 ` [Qemu-devel] [PATCH v3 08/46] hw/char: " Alistair Francis
2017-10-20  3:30   ` Philippe Mathieu-Daudé
2017-10-19 16:16 ` [Qemu-devel] [PATCH v3 09/46] hw/core: " Alistair Francis
2017-10-19 16:16 ` [Qemu-devel] [PATCH v3 10/46] hw/cris: " Alistair Francis
2017-10-20  3:19   ` Philippe Mathieu-Daudé
2017-10-19 16:16 ` [Qemu-devel] [PATCH v3 11/46] hw/display: " Alistair Francis
2017-10-19 16:16 ` [Qemu-devel] [PATCH v3 12/46] hw/dma: " Alistair Francis
2017-10-19 16:16 ` [Qemu-devel] [PATCH v3 13/46] hw/gpio: " Alistair Francis
2017-10-19 16:16 ` [Qemu-devel] [PATCH v3 14/46] hw/i2c: " Alistair Francis
2017-10-19 16:16 ` [Qemu-devel] [PATCH v3 16/46] hw/ide: " Alistair Francis
2017-10-24 15:56   ` Philippe Mathieu-Daudé
2017-11-01 21:10     ` [Qemu-devel] [Qemu-block] " John Snow
2017-10-19 16:16 ` [Qemu-devel] [PATCH v3 17/46] hw/input: " Alistair Francis
2017-10-19 16:16 ` [Qemu-devel] [PATCH v3 18/46] hw/intc: " Alistair Francis
2017-10-19 16:16 ` [Qemu-devel] [PATCH v3 19/46] hw/ipmi: " Alistair Francis
2017-10-19 16:16 ` [Qemu-devel] [PATCH v3 20/46] hw/isa: " Alistair Francis
2017-10-19 16:16 ` [Qemu-devel] [PATCH v3 21/46] hw/lm32: " Alistair Francis
2017-10-19 16:16 ` [Qemu-devel] [PATCH v3 22/46] hw/microblaze: " Alistair Francis
2017-10-19 16:16 ` [Qemu-devel] [PATCH v3 23/46] hw/mips: " Alistair Francis
2017-10-19 16:17 ` [Qemu-devel] [PATCH v3 24/46] hw/misc: " Alistair Francis
2017-10-19 16:17 ` [Qemu-devel] [PATCH v3 25/46] hw/moxie: " Alistair Francis
2017-10-19 16:17 ` [Qemu-devel] [PATCH v3 26/46] hw/net: " Alistair Francis
2017-10-19 16:17 ` [Qemu-devel] [PATCH v3 27/46] hw/nios2: " Alistair Francis
2017-10-19 16:17 ` [Qemu-devel] [PATCH v3 28/46] hw/nvram: " Alistair Francis
2017-10-19 16:17 ` [Qemu-devel] [PATCH v3 29/46] hw/openrisc: " Alistair Francis
2017-10-19 16:17 ` [Qemu-devel] [PATCH v3 30/46] hw/pci*: " Alistair Francis
2017-10-19 16:17 ` [Qemu-devel] [PATCH v3 31/46] hw/ppc: " Alistair Francis
2017-10-19 16:17 ` [Qemu-devel] [PATCH v3 32/46] hw/s390x: " Alistair Francis
2017-10-19 16:58   ` Thomas Huth
2017-10-19 16:17 ` [Qemu-devel] [PATCH v3 33/46] hw/scsi: " Alistair Francis
2017-10-19 23:50   ` David Gibson
2017-10-19 16:17 ` [Qemu-devel] [PATCH v3 34/46] hw/sd: " Alistair Francis
2017-10-24 16:02   ` Philippe Mathieu-Daudé
2017-10-19 16:17 ` [Qemu-devel] [PATCH v3 35/46] hw/sh4: " Alistair Francis
2017-10-19 16:17 ` [Qemu-devel] [PATCH v3 36/46] hw/sparc*: " Alistair Francis
2017-10-19 16:18 ` [Qemu-devel] [PATCH v3 37/46] hw/ssi: " Alistair Francis
2017-10-19 16:18 ` [Qemu-devel] [PATCH v3 38/46] hw/timer: " Alistair Francis
2017-10-19 16:18 ` [Qemu-devel] [PATCH v3 39/46] hw/usb: " Alistair Francis
2017-10-19 16:18 ` [Qemu-devel] [PATCH v3 40/46] hw/watchdog: " Alistair Francis
2017-10-24 16:12   ` Philippe Mathieu-Daudé
2017-10-19 16:18 ` [Qemu-devel] [PATCH v3 41/46] hw/xen*: " Alistair Francis
2017-10-24 14:26   ` Anthony PERARD [this message]
2017-10-19 16:18 ` [Qemu-devel] [PATCH v3 42/46] util: " Alistair Francis
2017-10-19 17:53   ` Thomas Huth
2017-10-19 19:47     ` Stefan Weil
2017-10-20  6:27       ` Thomas Huth
2017-10-20 10:47         ` Stefan Hajnoczi
2017-10-20 16:38           ` Alistair Francis
2017-10-19 16:18 ` [Qemu-devel] [PATCH v3 43/46] ui: " Alistair Francis
2017-10-19 16:18 ` [Qemu-devel] [PATCH v3 44/46] tcg: " Alistair Francis
2017-10-19 16:18 ` [Qemu-devel] [PATCH v3 45/46] target: Use qemu_log() instead of fprintf(stderr, ...) Alistair Francis
2017-10-19 16:18 ` [Qemu-devel] [PATCH v3 46/46] target: Replace fprintf(stderr, "*\n" with error_report() Alistair Francis
2017-10-19 16:18   ` Alistair Francis
2017-10-20  3:25   ` [Qemu-arm] " Philippe Mathieu-Daudé
2017-10-20  3:25     ` Philippe Mathieu-Daudé
2017-10-20  7:34   ` [Qemu-arm] " Thomas Huth
2017-10-20  7:34     ` Thomas Huth
2017-10-23  7:41     ` [Qemu-arm] " Alistair Francis
2017-10-23  7:41       ` Alistair Francis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171024142655.GF1885@perard.uk.xensource.com \
    --to=anthony.perard@citrix.com \
    --cc=alistair.francis@xilinx.com \
    --cc=alistair23@gmail.com \
    --cc=armbru@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=sstabellini@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.