From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932283AbdJYG4v (ORCPT <rfc822;w@1wt.eu>);
        Wed, 25 Oct 2017 02:56:51 -0400
Received: from mail.linuxfoundation.org ([140.211.169.12]:59344 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932221AbdJYG4t (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 25 Oct 2017 02:56:49 -0400
Date: Wed, 25 Oct 2017 08:56:46 +0200
From: Greg KH <gregkh@linuxfoundation.org>
To: Chen Feng <puck.chen@hisilicon.com>
Cc: "Theodore Ts'o" <tytso@mit.edu>, zhaoyukun@huawei.com, arnd@arndb.de,
        linux-kernel@vger.kernel.org, suzhuangluan@hisilicon.com,
        dan.zhao@hisilicon.com
Subject: Re: [PATCH RFC] random: fix syzkaller fuzzer test int overflow
Message-ID: <20171025065646.GA13386@kroah.com>
References: <1508831057-64195-1-git-send-email-puck.chen@hisilicon.com>
 <20171024090927.GA20625@kroah.com>
 <20171024102528.7oywdwjriesoh3mk@thunk.org>
 <59F02FA0.7090605@hisilicon.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <59F02FA0.7090605@hisilicon.com>
User-Agent: Mutt/1.9.1 (2017-09-22)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Oct 25, 2017 at 02:30:56PM +0800, Chen Feng wrote:
> Hi Ted,
> 
> On 2017/10/24 18:25, Theodore Ts'o wrote:
> > On Tue, Oct 24, 2017 at 11:09:27AM +0200, Greg KH wrote:
> >> On Tue, Oct 24, 2017 at 03:44:17PM +0800, Chen Feng wrote:
> >>> [pid:11940,cpu6,syz-executor][flp_ioctl]cmd[0x1]
> >>> Restart is not permit
> >>> =================================================================
> >>> UBSAN: Undefined behaviour in
> >>> kernel/linux-4.4/drivers/char/random.c:676:19
> >>> signed integer overflow:
> >>> 2147483645 + 268435455 cannot be represented in type 'int'
> >>> CPU: 4 PID: 11941 Comm: syz-executor Not tainted 4.4.76+ #2
> >>
> >> Does this also happen on 4.14-rc6?
> > 
> > No.  It was fixed in 4.8, by commit 86a574de4590: "random: strengthen
> > input validation for RNDADDTOENTCNT".
> 
> 
> I see my kernel has already merged this patch. So I don't think this patch
> can resolve the issue above.

Do you have a reproducer for this issue that we can use to test?

thanks,

greg k-h