From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] ltp: keep the .tid hidden in the test library
Date: Wed, 25 Oct 2017 11:05:41 +0200 [thread overview]
Message-ID: <20171025090541.GD4244@rei> (raw)
In-Reply-To: <CAEemH2ekrPr8OJAwKP4Zog+M1xNCR7wqW-QBt-6AOUiCxbMWPQ@mail.gmail.com>
Hi!
> Attaching a new patch to achieve the same target in another way. It
> just remove the .tid from test struct and take use of TCID to replace.
>
> Which one do you think is better?
I think that removing it from the test structure is better, but reusing
the oldlib TCID seems to be a bit messy solution to me. We may get rid
of that one in the future, if we happen to convert all the oldlib
testcases. I would be a bit happier if we decleared static char *tid in
the tst_test.c instead.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2017-10-25 9:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-25 8:11 [LTP] [PATCH] ltp: keep the .tid hidden in the test library Li Wang
2017-10-25 9:01 ` Li Wang
2017-10-25 9:05 ` Cyril Hrubis [this message]
2017-10-25 9:15 ` Li Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171025090541.GD4244@rei \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.