From: Peter Zijlstra <peterz@infradead.org>
To: Prateek Sood <prsood@codeaurora.org>
Cc: tj@kernel.org, lizefan@huawei.com, cgroups@vger.kernel.org,
mingo@kernel.org, longman@redhat.com, boqun.feng@gmail.com,
tglx@linutronix.de, linux-kernel@vger.kernel.org,
sramana@codeaurora.org
Subject: Re: [PATCH] cgroup/cpuset: remove circular dependency deadlock
Date: Wed, 25 Oct 2017 11:30:41 +0200 [thread overview]
Message-ID: <20171025093041.GO3165@worktop.lehotels.local> (raw)
In-Reply-To: <00043e79-3647-3979-07bb-27039921efb4@codeaurora.org>
On Wed, Oct 25, 2017 at 02:09:54PM +0530, Prateek Sood wrote:
> > void cpuset_update_active_cpus(void)
> > {
> > + mutex_lock(&cpuset_mutex);
> > + rebuild_sched_domains_cpuslocked();
> > + mutex_unlock(&cpuset_mutex);
> > }
>
> In the above patch rebuild_sched_domains_cpuslocked() has been
> used directly. Earlier cpuset_hotplug_update_tasks() was also
> called from cpuset_hotplug_workfn(). So migration of tasks
> related to cgroup which has empty cpuset would not happen
> during cpu hotplug.
>
>
> Could you please help in understanding more on this.
>
That was me being lazy...
next prev parent reply other threads:[~2017-10-25 9:30 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-07 13:56 [PATCH] cgroup/cpuset: remove circular dependency deadlock Prateek Sood
2017-09-07 17:45 ` Peter Zijlstra
2017-09-08 2:13 ` Prateek Sood
[not found] ` <1504792583-10424-1-git-send-email-prsood-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-09-07 17:51 ` Peter Zijlstra
2017-09-07 17:51 ` Peter Zijlstra
2017-10-09 13:27 ` Prateek Sood
[not found] ` <4668d1ec-dc43-8a9c-4f94-a421683d3c17-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-10-09 13:32 ` Prateek Sood
2017-10-11 9:48 ` Peter Zijlstra
2017-10-11 9:48 ` Peter Zijlstra
[not found] ` <20171011094833.pdp4torvotvjdmkt-Nxj+rRp3nVydTX5a5knrm8zTDFooKrT+cvkQGrU6aU0@public.gmane.org>
2017-10-25 8:39 ` Prateek Sood
2017-10-25 8:39 ` Prateek Sood
2017-10-25 9:30 ` Peter Zijlstra [this message]
[not found] ` <20171025093041.GO3165-IIpfhp3q70x9+YH6RuovlLjjLBE8jN/0@public.gmane.org>
2017-10-26 11:52 ` Prateek Sood
2017-10-26 11:52 ` Prateek Sood
2017-10-26 14:05 ` Waiman Long
[not found] ` <dc80ad9d-5b3d-b991-76c8-35630bc139c5-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-10-27 8:03 ` Prateek Sood
2017-10-27 8:03 ` Prateek Sood
[not found] ` <45cdac2f-4462-e5b5-d724-8cca58e3932a-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-10-30 7:16 ` [PATCH v2] " Prateek Sood
2017-10-30 7:16 ` Prateek Sood
[not found] ` <1509347805-23491-1-git-send-email-prsood-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-11-06 4:01 ` Prateek Sood
2017-11-06 4:01 ` Prateek Sood
2017-11-15 10:26 ` Prateek Sood
2017-11-15 10:26 ` Prateek Sood
[not found] ` <6f8b194f-05ec-05d4-3df6-e9eadc7f68bf-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-11-15 10:37 ` Peter Zijlstra
2017-11-15 10:37 ` Peter Zijlstra
[not found] ` <20171115103742.xt7muaq2dfrs2cyd-Nxj+rRp3nVydTX5a5knrm8zTDFooKrT+cvkQGrU6aU0@public.gmane.org>
2017-11-15 14:20 ` [PATCH v3 0/2] Invert cpu_hotplug_lock and cpuset_mutex locking order Prateek Sood
2017-11-15 14:20 ` Prateek Sood
[not found] ` <1510755615-25906-1-git-send-email-prsood-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-11-15 14:20 ` [PATCH v3 1/2] cgroup/cpuset: remove circular dependency deadlock Prateek Sood
2017-11-15 14:20 ` Prateek Sood
2017-11-15 14:20 ` [PATCH v3 2/2] cpuset: Make cpuset hotplug synchronous Prateek Sood
2017-11-15 14:20 ` Prateek Sood
2017-11-27 16:48 ` [PATCH v3 0/2] Invert cpu_hotplug_lock and cpuset_mutex locking order Tejun Heo
2017-11-15 17:05 ` [PATCH v2] cgroup/cpuset: remove circular dependency deadlock Tejun Heo
2017-11-15 17:05 ` Tejun Heo
[not found] ` <20171115170524.GU983427-4dN5La/x3IkLX0oZNxdnEQ2O0Ztt9esIQQ4Iyu8u01E@public.gmane.org>
2017-11-15 17:18 ` Prateek Sood
2017-11-15 17:18 ` Prateek Sood
-- strict thread matches above, loose matches on Subject: below --
2017-09-07 6:04 [PATCH] " Prateek Sood
[not found] ` <1504764252-29091-1-git-send-email-prsood-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-09-07 7:28 ` Peter Zijlstra
2017-09-07 7:28 ` Peter Zijlstra
2017-09-07 8:56 ` Boqun Feng
2017-09-07 9:07 ` Prateek Sood
2017-09-07 9:05 ` Prateek Sood
2017-09-06 11:48 Prateek Sood
2017-09-06 11:48 ` Prateek Sood
2017-09-06 12:56 ` Waiman Long
2017-09-06 14:23 ` Prateek Sood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171025093041.GO3165@worktop.lehotels.local \
--to=peterz@infradead.org \
--cc=boqun.feng@gmail.com \
--cc=cgroups@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=longman@redhat.com \
--cc=mingo@kernel.org \
--cc=prsood@codeaurora.org \
--cc=sramana@codeaurora.org \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.