From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: "Michał Kępień" <kernel@kempniu.pl>
Cc: Darren Hart <dvhart@infradead.org>,
Andy Shevchenko <andy@infradead.org>,
Jonathan Woithe <jwoithe@just42.net>,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH] platform/x86: fujitsu-laptop: Don't oops when FUJ02E3 is not presnt
Date: Wed, 25 Oct 2017 13:05:15 +0300 [thread overview]
Message-ID: <20171025100515.GI10981@intel.com> (raw)
In-Reply-To: <20171025045131.GB13202@kmp-mobile.hq.kempniu.pl>
On Wed, Oct 25, 2017 at 06:51:31AM +0200, Michał Kępień wrote:
> > > Finally, it seems the S6120 also has a row of "application panel"
> > > hotkeys above the keyboard, but lacks the FUJ02E3 ACPI device, so I am
> > > wondering whether these hotkeys work in Linux. Ville, do they?
> >
> > They work via the apanel driver.
>
> Oops, then it looks like we have two drivers which poke the same
> hardware at the same time using different methods: apanel uses SMBus,
> fujitsu-laptop uses ACPI (the former is inferior as it resorts to
> polling, which causes key presses to be reported with a delay). I just
> loaded both drivers on my Fujitsu Lifebook S7020 and it results in
> duplicate events being passed to userspace. We should probably prevent
> this, but I am not quite sure how to achieve that.
Maybe in apanel probe?
#if ENABLED(FUJITSU_LAPTOP)
if (ACPI thing available)
fail;
#endif
--
Ville Syrjälä
Intel OTC
next prev parent reply other threads:[~2017-10-25 10:05 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-18 20:00 [PATCH] platform/x86: fujitsu-laptop: Don't oops when FUJ02E3 is not presnt Ville Syrjala
2017-09-19 4:06 ` Michał Kępień
2017-09-19 4:21 ` Jonathan Woithe
2017-09-19 4:42 ` Michał Kępień
2017-09-19 8:20 ` Jonathan Woithe
2017-09-19 13:25 ` Ville Syrjälä
2018-02-10 21:33 ` Michał Kępień
2017-09-23 0:00 ` Darren Hart
2017-09-23 2:03 ` Jonathan Woithe
2017-09-23 9:08 ` Jonathan Woithe
2017-09-25 12:14 ` Ville Syrjälä
2017-09-25 13:16 ` Jonathan Woithe
2017-09-26 4:49 ` Michał Kępień
2017-09-26 5:32 ` Jonathan Woithe
[not found] ` <20171018151058.GL10981@intel.com>
2017-10-20 17:29 ` Ville Syrjälä
2017-10-25 4:51 ` Michał Kępień
2017-10-25 10:05 ` Ville Syrjälä [this message]
2017-10-29 22:57 ` Jonathan Woithe
2018-02-11 21:33 ` Michał Kępień
2017-09-27 6:56 ` Darren Hart
2017-09-27 7:27 ` Jonathan Woithe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171025100515.GI10981@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=andy@infradead.org \
--cc=dvhart@infradead.org \
--cc=jwoithe@just42.net \
--cc=kernel@kempniu.pl \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.