diff for duplicates of <20171025193452.d4qa4dhacfgqejk7@linux.intel.com> diff --git a/a/1.txt b/N1/1.txt index 8dfcb0a..2978c81 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -9,7 +9,7 @@ On Wed, Oct 25, 2017 at 08:40:26PM +0530, PrasannaKumar Muralidharan wrote: > > > > mutex_lock(&idr_lock); > > -> > - if (chip_num = TPM_ANY_NUM) { +> > - if (chip_num == TPM_ANY_NUM) { > > - chip_num = 0; > > + if (!chip) { > > do { @@ -50,7 +50,7 @@ struct tpm_chip *tpm_chip_find_get(u64 id) chip = idr_get_next(&dev_nums_idr, &chip_num); - if (chip && (!id || id = chip->id) && !tpm_try_get_ops(chip)) { + if (chip && (!id || id == chip->id) && !tpm_try_get_ops(chip)) { res = chip; break; } diff --git a/a/content_digest b/N1/content_digest index 1dd1db6..dae4ac7 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,7 +2,7 @@ "ref\0CANc+2y46q85+G1=9cXKW0R8FpGBqCuzkLnJzvSYFQ1S=ztKGew@mail.gmail.com\0" "From\0Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>\0" "Subject\0Re: [PATCH v2] tpm: use struct tpm_chip for tpm_chip_find_get()\0" - "Date\0Wed, 25 Oct 2017 19:34:52 +0000\0" + "Date\0Wed, 25 Oct 2017 21:34:52 +0200\0" "To\0PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com>\0" "Cc\0linux-integrity@vger.kernel.org" linux-security-module@vger.kernel.org @@ -20,7 +20,8 @@ Jerry Snitselaar <jsnitsel@redhat.com> open list:HARDWARE RANDOM NUMBER GENERATOR CORE <linux-crypto@vger.kernel.org> open list <linux-kernel@vger.kernel.org> - " moderated list:TPM DEVICE DRIVER <tpmdd-devel@lists.sourceforge.net>\0" + moderated list:TPM DEVICE DRIVER <tpmdd-devel@lists.sourceforge.net> + " \0" "\00:1\0" "b\0" "On Wed, Oct 25, 2017 at 08:40:26PM +0530, PrasannaKumar Muralidharan wrote:\n" @@ -34,7 +35,7 @@ "> >\n" "> > mutex_lock(&idr_lock);\n" "> >\n" - "> > - if (chip_num = TPM_ANY_NUM) {\n" + "> > - if (chip_num == TPM_ANY_NUM) {\n" "> > - chip_num = 0;\n" "> > + if (!chip) {\n" "> > do {\n" @@ -75,7 +76,7 @@ "\n" "\t\tchip = idr_get_next(&dev_nums_idr, &chip_num);\n" "\n" - "\t\tif (chip && (!id || id = chip->id) && !tpm_try_get_ops(chip)) {\n" + "\t\tif (chip && (!id || id == chip->id) && !tpm_try_get_ops(chip)) {\n" "\t\t\tres = chip;\n" "\t\t\tbreak;\n" "\t\t}\n" @@ -90,4 +91,4 @@ "\n" /Jarkko -b1542942f50bb4fd5ed47356c200647edebec6abf86713be999767fd2be15440 +a787b59a47cfc5cbb7417ad44c557d98981efe97035ad90883eb4a307bf05516
diff --git a/a/1.txt b/N2/1.txt index 8dfcb0a..2978c81 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -9,7 +9,7 @@ On Wed, Oct 25, 2017 at 08:40:26PM +0530, PrasannaKumar Muralidharan wrote: > > > > mutex_lock(&idr_lock); > > -> > - if (chip_num = TPM_ANY_NUM) { +> > - if (chip_num == TPM_ANY_NUM) { > > - chip_num = 0; > > + if (!chip) { > > do { @@ -50,7 +50,7 @@ struct tpm_chip *tpm_chip_find_get(u64 id) chip = idr_get_next(&dev_nums_idr, &chip_num); - if (chip && (!id || id = chip->id) && !tpm_try_get_ops(chip)) { + if (chip && (!id || id == chip->id) && !tpm_try_get_ops(chip)) { res = chip; break; } diff --git a/a/content_digest b/N2/content_digest index 1dd1db6..9245157 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -2,7 +2,7 @@ "ref\0CANc+2y46q85+G1=9cXKW0R8FpGBqCuzkLnJzvSYFQ1S=ztKGew@mail.gmail.com\0" "From\0Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>\0" "Subject\0Re: [PATCH v2] tpm: use struct tpm_chip for tpm_chip_find_get()\0" - "Date\0Wed, 25 Oct 2017 19:34:52 +0000\0" + "Date\0Wed, 25 Oct 2017 21:34:52 +0200\0" "To\0PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com>\0" "Cc\0linux-integrity@vger.kernel.org" linux-security-module@vger.kernel.org @@ -20,7 +20,10 @@ Jerry Snitselaar <jsnitsel@redhat.com> open list:HARDWARE RANDOM NUMBER GENERATOR CORE <linux-crypto@vger.kernel.org> open list <linux-kernel@vger.kernel.org> - " moderated list:TPM DEVICE DRIVER <tpmdd-devel@lists.sourceforge.net>\0" + moderated list:TPM DEVICE DRIVER <tpmdd-devel@lists.sourceforge.net> + open list:INTEGRITY MEASUREMENT ARCHITECTURE (IMA) <linux-ima-devel@lists.sourceforge.net> + open list:INTEGRITY MEASUREMENT ARCHITECTURE (IMA) <linux-ima-user@lists.sourceforge.net> + " open list:KEYS-TRUSTED <keyrings@vger.kernel.org>\0" "\00:1\0" "b\0" "On Wed, Oct 25, 2017 at 08:40:26PM +0530, PrasannaKumar Muralidharan wrote:\n" @@ -34,7 +37,7 @@ "> >\n" "> > mutex_lock(&idr_lock);\n" "> >\n" - "> > - if (chip_num = TPM_ANY_NUM) {\n" + "> > - if (chip_num == TPM_ANY_NUM) {\n" "> > - chip_num = 0;\n" "> > + if (!chip) {\n" "> > do {\n" @@ -75,7 +78,7 @@ "\n" "\t\tchip = idr_get_next(&dev_nums_idr, &chip_num);\n" "\n" - "\t\tif (chip && (!id || id = chip->id) && !tpm_try_get_ops(chip)) {\n" + "\t\tif (chip && (!id || id == chip->id) && !tpm_try_get_ops(chip)) {\n" "\t\t\tres = chip;\n" "\t\t\tbreak;\n" "\t\t}\n" @@ -90,4 +93,4 @@ "\n" /Jarkko -b1542942f50bb4fd5ed47356c200647edebec6abf86713be999767fd2be15440 +42781800dcd039f35dbabbad83233e2f006e875e3063d23f49dd03ef2afa0caa
diff --git a/a/1.txt b/N3/1.txt index 8dfcb0a..09b664e 100644 --- a/a/1.txt +++ b/N3/1.txt @@ -9,7 +9,7 @@ On Wed, Oct 25, 2017 at 08:40:26PM +0530, PrasannaKumar Muralidharan wrote: > > > > mutex_lock(&idr_lock); > > -> > - if (chip_num = TPM_ANY_NUM) { +> > - if (chip_num == TPM_ANY_NUM) { > > - chip_num = 0; > > + if (!chip) { > > do { @@ -50,7 +50,7 @@ struct tpm_chip *tpm_chip_find_get(u64 id) chip = idr_get_next(&dev_nums_idr, &chip_num); - if (chip && (!id || id = chip->id) && !tpm_try_get_ops(chip)) { + if (chip && (!id || id == chip->id) && !tpm_try_get_ops(chip)) { res = chip; break; } @@ -64,3 +64,7 @@ struct tpm_chip *tpm_chip_find_get(u64 id) Thanks for spotting this out. I'll refine the patch. /Jarkko +-- +To unsubscribe from this list: send the line "unsubscribe linux-security-module" in +the body of a message to majordomo at vger.kernel.org +More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N3/content_digest index 1dd1db6..12678a5 100644 --- a/a/content_digest +++ b/N3/content_digest @@ -1,26 +1,9 @@ "ref\020171025115508.5682-1-jarkko.sakkinen@linux.intel.com\0" "ref\0CANc+2y46q85+G1=9cXKW0R8FpGBqCuzkLnJzvSYFQ1S=ztKGew@mail.gmail.com\0" - "From\0Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>\0" - "Subject\0Re: [PATCH v2] tpm: use struct tpm_chip for tpm_chip_find_get()\0" - "Date\0Wed, 25 Oct 2017 19:34:52 +0000\0" - "To\0PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com>\0" - "Cc\0linux-integrity@vger.kernel.org" - linux-security-module@vger.kernel.org - Matt Mackall <mpm@selenic.com> - Herbert Xu <herbert@gondor.apana.org.au> - Peter Huewe <peterhuewe@gmx.de> - Marcel Selhorst <tpmdd@selhorst.net> - Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - Mimi Zohar <zohar@linux.vnet.ibm.com> - Dmitry Kasatkin <dmitry.kasatkin@gmail.com> - James Morris <james.l.morris@oracle.com> - Serge E. Hallyn <serge@hallyn.com> - David Safford <safford@us.ibm.com> - David Howells <dhowells@redhat.com> - Jerry Snitselaar <jsnitsel@redhat.com> - open list:HARDWARE RANDOM NUMBER GENERATOR CORE <linux-crypto@vger.kernel.org> - open list <linux-kernel@vger.kernel.org> - " moderated list:TPM DEVICE DRIVER <tpmdd-devel@lists.sourceforge.net>\0" + "From\0jarkko.sakkinen@linux.intel.com (Jarkko Sakkinen)\0" + "Subject\0[PATCH v2] tpm: use struct tpm_chip for tpm_chip_find_get()\0" + "Date\0Wed, 25 Oct 2017 21:34:52 +0200\0" + "To\0linux-security-module@vger.kernel.org\0" "\00:1\0" "b\0" "On Wed, Oct 25, 2017 at 08:40:26PM +0530, PrasannaKumar Muralidharan wrote:\n" @@ -34,7 +17,7 @@ "> >\n" "> > mutex_lock(&idr_lock);\n" "> >\n" - "> > - if (chip_num = TPM_ANY_NUM) {\n" + "> > - if (chip_num == TPM_ANY_NUM) {\n" "> > - chip_num = 0;\n" "> > + if (!chip) {\n" "> > do {\n" @@ -75,7 +58,7 @@ "\n" "\t\tchip = idr_get_next(&dev_nums_idr, &chip_num);\n" "\n" - "\t\tif (chip && (!id || id = chip->id) && !tpm_try_get_ops(chip)) {\n" + "\t\tif (chip && (!id || id == chip->id) && !tpm_try_get_ops(chip)) {\n" "\t\t\tres = chip;\n" "\t\t\tbreak;\n" "\t\t}\n" @@ -88,6 +71,10 @@ "\n" "Thanks for spotting this out. I'll refine the patch.\n" "\n" - /Jarkko + "/Jarkko\n" + "--\n" + "To unsubscribe from this list: send the line \"unsubscribe linux-security-module\" in\n" + "the body of a message to majordomo at vger.kernel.org\n" + More majordomo info at http://vger.kernel.org/majordomo-info.html -b1542942f50bb4fd5ed47356c200647edebec6abf86713be999767fd2be15440 +51b92b170ad6e415dc8ae8f88094297121e2fe94ca8ce81bcc991d384802d5bc
diff --git a/a/1.txt b/N4/1.txt index 8dfcb0a..2978c81 100644 --- a/a/1.txt +++ b/N4/1.txt @@ -9,7 +9,7 @@ On Wed, Oct 25, 2017 at 08:40:26PM +0530, PrasannaKumar Muralidharan wrote: > > > > mutex_lock(&idr_lock); > > -> > - if (chip_num = TPM_ANY_NUM) { +> > - if (chip_num == TPM_ANY_NUM) { > > - chip_num = 0; > > + if (!chip) { > > do { @@ -50,7 +50,7 @@ struct tpm_chip *tpm_chip_find_get(u64 id) chip = idr_get_next(&dev_nums_idr, &chip_num); - if (chip && (!id || id = chip->id) && !tpm_try_get_ops(chip)) { + if (chip && (!id || id == chip->id) && !tpm_try_get_ops(chip)) { res = chip; break; } diff --git a/a/content_digest b/N4/content_digest index 1dd1db6..d1c4fc6 100644 --- a/a/content_digest +++ b/N4/content_digest @@ -2,7 +2,7 @@ "ref\0CANc+2y46q85+G1=9cXKW0R8FpGBqCuzkLnJzvSYFQ1S=ztKGew@mail.gmail.com\0" "From\0Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>\0" "Subject\0Re: [PATCH v2] tpm: use struct tpm_chip for tpm_chip_find_get()\0" - "Date\0Wed, 25 Oct 2017 19:34:52 +0000\0" + "Date\0Wed, 25 Oct 2017 21:34:52 +0200\0" "To\0PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com>\0" "Cc\0linux-integrity@vger.kernel.org" linux-security-module@vger.kernel.org @@ -34,7 +34,7 @@ "> >\n" "> > mutex_lock(&idr_lock);\n" "> >\n" - "> > - if (chip_num = TPM_ANY_NUM) {\n" + "> > - if (chip_num == TPM_ANY_NUM) {\n" "> > - chip_num = 0;\n" "> > + if (!chip) {\n" "> > do {\n" @@ -75,7 +75,7 @@ "\n" "\t\tchip = idr_get_next(&dev_nums_idr, &chip_num);\n" "\n" - "\t\tif (chip && (!id || id = chip->id) && !tpm_try_get_ops(chip)) {\n" + "\t\tif (chip && (!id || id == chip->id) && !tpm_try_get_ops(chip)) {\n" "\t\t\tres = chip;\n" "\t\t\tbreak;\n" "\t\t}\n" @@ -90,4 +90,4 @@ "\n" /Jarkko -b1542942f50bb4fd5ed47356c200647edebec6abf86713be999767fd2be15440 +c1d6b05ce9463ad5af6ff1d44b6962daee96d29d4eb9b26cc34735c3ba25d7b6
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.