Re: [PATCH v2] locking: Update table layout

["Paul E. McKenney" <paulmck@linux.vnet.ibm.com>]

On Thu, Oct 26, 2017 at 06:58:44AM +0900, Akira Yokosawa wrote:
> >From aa7899ff624e41740f4ed22eb43abf856caa6940 Mon Sep 17 00:00:00 2001
> From: Akira Yokosawa <akiyks@gmail.com>
> Date: Tue, 26 Oct 2017 06:51:42 +0900
> Subject: [PATCH v2] locking: Update table layout
> 
> To imply vertical lines, instead of coloring alternate rows,
> put light gray boxes in blank cells.
> 
> Suggested-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> Signed-off-by: Akira Yokosawa <akiyks@gmail.com>
> ---
> Change after v1:
>   The definition of "\x" is moved to within the "table" environment
>   to make the macro local.

Applied, verified that adding a "\x" after the table gives an error,
and pushed it out, thank you!

							Thanx, Paul

> --
>  locking/locking.tex | 41 +++++++++++++++++++----------------------
>  1 file changed, 19 insertions(+), 22 deletions(-)
> 
> diff --git a/locking/locking.tex b/locking/locking.tex
> index 9cb0176..14db27d 100644
> --- a/locking/locking.tex
> +++ b/locking/locking.tex
> @@ -1312,43 +1312,40 @@ or even milliseconds.
>  \label{sec:locking:Beyond Reader-Writer Locks}
> 
>  \begin{table}
> +\renewcommand*{\arraystretch}{1.2}
> +\newcommand{\x}{\textcolor{gray!20}{\rule{7pt}{7pt}}}
>  \small
>  \centering
> -\begin{tabular}{l||c|c|c|c|c|c}
> -	~ ~ ~ ~ ~ ~ ~ ~ ~
> -	& \begin{picture}(6,70)(0,0)
> +\begin{tabular}{lcccccc}
> +	\toprule
> +	& \begin{picture}(6,65)(0,0)
>  		\rotatebox{90}{Null (Not Held)}
>  	  \end{picture}
> -	& \begin{picture}(6,70)(0,0)
> +	& \begin{picture}(6,65)(0,0)
>  		\rotatebox{90}{Concurrent Read}
>  	  \end{picture}
> -	& \begin{picture}(6,70)(0,0)
> +	& \begin{picture}(6,65)(0,0)
>  		\rotatebox{90}{Concurrent Write}
>  	  \end{picture}
> -	& \begin{picture}(6,70)(0,0)
> +	& \begin{picture}(6,65)(0,0)
>  		\rotatebox{90}{Protected Read}
>  	  \end{picture}
> -	& \begin{picture}(6,70)(0,0)
> +	& \begin{picture}(6,65)(0,0)
>  		\rotatebox{90}{Protected Write}
>  	  \end{picture}
> -	& \begin{picture}(6,70)(0,0)
> +	& \begin{picture}(6,65)(0,0)
>  		\rotatebox{90}{Exclusive}
>  	  \end{picture}
>  	\\
> -	\hline
> -%				 NL  CR  CW  PR    PW  EX
> -	\hline
> -	Null (Not Held)		& ~ & ~ & ~   & ~ & ~ & ~ \\
> -	\hline
> -	Concurrent Read		& ~ & ~ & ~   & ~ & ~ & X \\
> -	\hline
> -	Concurrent Write	& ~ & ~ & ~   & X & X & X \\
> -	\hline
> -	Protected Read		& ~ & ~ & X   & ~ & X & X \\
> -	\hline
> -	Protected Write		& ~ & ~ & X   & X & X & X \\
> -	\hline
> -	Exclusive		& ~ & X & X   & X & X & X \\
> +%				  NL   CR   CW     PR   PW   EX
> +	\cmidrule(r){1-1} \cmidrule{2-7}
> +	Null (Not Held)		& \x & \x & \x   & \x & \x & \x \\
> +	Concurrent Read		& \x & \x & \x   & \x & \x &  X \\
> +	Concurrent Write	& \x & \x & \x   &  X &  X &  X \\
> +	Protected Read		& \x & \x &  X   & \x &  X &  X \\
> +	Protected Write		& \x & \x &  X   &  X &  X &  X \\
> +	Exclusive		& \x &  X &  X   &  X &  X &  X \\
> +	\bottomrule
>  \end{tabular}
>  \caption{VAX/VMS Distributed Lock Manager Policy}
>  \label{tab:locking:VAX/VMS Distributed Lock Manager Policy}
> -- 
> 2.7.4
> 
>