From: Lukas Wunner <lukas@wunner.de>
To: =?UTF-8?q?Ronald=20Tschal=C3=A4r?= <ronald@innovation.ch>
Cc: Marcel Holtmann <marcel@holtmann.org>,
Gustavo Padovan <gustavo@padovan.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
Dean Jenkins <Dean_Jenkins@mentor.com>,
linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: hci_ldisc: Fix another race when closing the tty.
Date: Thu, 26 Oct 2017 08:52:02 +0200 [thread overview]
Message-ID: <20171026065202.GA6487@wunner.de> (raw)
In-Reply-To: <20171026051519.GA15958@innovation.ch>
On Wed, Oct 25, 2017 at 10:15:19PM -0700, =?UTF-8?q?Ronald=20Tschal=C3=A4r?= wrote:
> --- a/drivers/bluetooth/hci_ldisc.c
> +++ b/drivers/bluetooth/hci_ldisc.c
> @@ -523,13 +523,13 @@ static void hci_uart_tty_close(struct tty_struct *tty)
> if (hdev)
> hci_uart_close(hdev);
>
> - cancel_work_sync(&hu->write_work);
> -
> if (test_bit(HCI_UART_PROTO_READY, &hu->flags)) {
> percpu_down_write(&hu->proto_lock);
> clear_bit(HCI_UART_PROTO_READY, &hu->flags);
> percpu_up_write(&hu->proto_lock);
>
> + cancel_work_sync(&hu->write_work);
> +
Now the work is only cancelled if HCI_UART_PROTO_READY is set,
but that seems fine, so
Reviewed-by: Lukas Wunner <lukas@wunner.de>
It should be noted that this patch only applies cleanly if Ronald's
other patch is applied before.
next prev parent reply other threads:[~2017-10-26 6:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-26 5:15 [PATCH] Bluetooth: hci_ldisc: Fix another race when closing the tty =?UTF-8?q?Ronald=20Tschal=C3=A4r?=
2017-10-26 6:52 ` Lukas Wunner [this message]
2017-10-30 14:49 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171026065202.GA6487@wunner.de \
--to=lukas@wunner.de \
--cc=Dean_Jenkins@mentor.com \
--cc=gustavo@padovan.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=ronald@innovation.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.