From: Steffen Klassert <steffen.klassert@secunet.com>
To: David Miller <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>
Subject: Re: [RFC PATCH 07/12] xfrm: Move child route linkage into xfrm_dst.
Date: Thu, 26 Oct 2017 09:03:11 +0200 [thread overview]
Message-ID: <20171026070311.GS3323@secunet.com> (raw)
In-Reply-To: <20171025.230359.995821396512483745.davem@davemloft.net>
On Wed, Oct 25, 2017 at 11:03:59PM +0900, David Miller wrote:
>
> XFRM bundle child chains look like this:
>
> xdst1 --> xdst2 --> xdst3 --> path_dst
>
> All of xdstN are xfrm_dst objects and xdst->u.dst.xfrm is non-NULL.
> The final child pointer in the chain, here called 'path_dst', is some
> other kind of route such as an ipv4 or ipv6 one.
>
> The xfrm output path pops routes, one at a time, via the child
> pointer, until we hit one which has a dst->xfrm pointer which
> is NULL.
>
> We can easily preserve the above mechanisms with child sitting
> only in the xfrm_dst structure. All children in the chain
> before we break out of the xfrm_output() loop have dst->xfrm
> non-NULL and are therefore xfrm_dst objects.
>
> Since we break out of the loop when we find dst->xfrm NULL, we
> will not try to dereference 'dst' as if it were an xfrm_dst.
>
> Signed-off-by: David S. Miller <davem@davemloft.net>
This one seems to be somewhat screwed up, it does not apply.
Looks like your mail contains two patches, both have some overlap.
You have:
> ---
> include/net/dst.h | 12 +-----------
> include/net/xfrm.h | 14 ++++++++++++--
> net/core/dst.c | 2 +-
> net/core/pktgen.c | 12 ++++++------
> 4 files changed, 20 insertions(+), 20 deletions(-)
>
And:
> ---
> include/net/dst.h | 3 +--
> include/net/xfrm.h | 13 +++++++++----
> net/core/dst.c | 9 ++++++---
> net/core/pktgen.c | 12 ++++++------
> net/netfilter/xt_policy.c | 3 ++-
> net/xfrm/xfrm_device.c | 2 +-
> 6 files changed, 25 insertions(+), 17 deletions(-)
>
next prev parent reply other threads:[~2017-10-26 7:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-25 14:03 [RFC PATCH 07/12] xfrm: Move child route linkage into xfrm_dst David Miller
2017-10-26 7:03 ` Steffen Klassert [this message]
2017-10-26 7:44 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171026070311.GS3323@secunet.com \
--to=steffen.klassert@secunet.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.