From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Date: Thu, 26 Oct 2017 10:54:30 +0000 Subject: Re: [PATCH v2] tpm: use struct tpm_chip for tpm_chip_find_get() Message-Id: <20171026105430.t6khk6cekk3cyfrs@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit List-Id: References: <20171025115508.5682-1-jarkko.sakkinen@linux.intel.com> <20171025193452.d4qa4dhacfgqejk7@linux.intel.com> <20171025194633.GB998@obsidianresearch.com> <20171025200746.svsraubdotjyzt2i@linux.intel.com> <20171025201744.GB2815@obsidianresearch.com> In-Reply-To: <20171025201744.GB2815@obsidianresearch.com> To: Jason Gunthorpe Cc: PrasannaKumar Muralidharan , linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, Matt Mackall , Herbert Xu , Peter Huewe , Marcel Selhorst , Mimi Zohar , Dmitry Kasatkin , James Morris , "Serge E. Hallyn" , David Safford , David Howells , Jerry Snitselaar , "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , open list , "moderated list:TPM DEVICE DRIVER" On Wed, Oct 25, 2017 at 02:17:44PM -0600, Jason Gunthorpe wrote: > On Wed, Oct 25, 2017 at 10:07:46PM +0200, Jarkko Sakkinen wrote: > > > The id has a nice feature that it is unique for one boot cycle you can > > even try to get a chip that has been deleted. It has the most stable > > properties in the long run. > > It isn't unique, we can re-use ids them via idr_alloc(). We should > never use index inside the kernel. > > > Address is a reusable identifier in one boot cycle. > > It is invalid to pass in a chip for which the caller does not hold a > kref, so address is the safest argument. > > Jason I'll buy this too (sending update today). /Jarkko From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Subject: Re: [PATCH v2] tpm: use struct tpm_chip for tpm_chip_find_get() Date: Thu, 26 Oct 2017 12:54:30 +0200 Message-ID: <20171026105430.t6khk6cekk3cyfrs@linux.intel.com> References: <20171025115508.5682-1-jarkko.sakkinen@linux.intel.com> <20171025193452.d4qa4dhacfgqejk7@linux.intel.com> <20171025194633.GB998@obsidianresearch.com> <20171025200746.svsraubdotjyzt2i@linux.intel.com> <20171025201744.GB2815@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: PrasannaKumar Muralidharan , linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, Matt Mackall , Herbert Xu , Peter Huewe , Marcel Selhorst , Mimi Zohar , Dmitry Kasatkin , James Morris , "Serge E. Hallyn" , David Safford , David Howells , Jerry Snitselaar , "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , open list , "moderated list:TPM DEVICE DRIVER" , To: Jason Gunthorpe Return-path: Content-Disposition: inline In-Reply-To: <20171025201744.GB2815@obsidianresearch.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-crypto.vger.kernel.org On Wed, Oct 25, 2017 at 02:17:44PM -0600, Jason Gunthorpe wrote: > On Wed, Oct 25, 2017 at 10:07:46PM +0200, Jarkko Sakkinen wrote: > > > The id has a nice feature that it is unique for one boot cycle you can > > even try to get a chip that has been deleted. It has the most stable > > properties in the long run. > > It isn't unique, we can re-use ids them via idr_alloc(). We should > never use index inside the kernel. > > > Address is a reusable identifier in one boot cycle. > > It is invalid to pass in a chip for which the caller does not hold a > kref, so address is the safest argument. > > Jason I'll buy this too (sending update today). /Jarkko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com ([134.134.136.65]:11667 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932141AbdJZKyj (ORCPT ); Thu, 26 Oct 2017 06:54:39 -0400 Date: Thu, 26 Oct 2017 12:54:30 +0200 From: Jarkko Sakkinen To: Jason Gunthorpe Cc: PrasannaKumar Muralidharan , linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, Matt Mackall , Herbert Xu , Peter Huewe , Marcel Selhorst , Mimi Zohar , Dmitry Kasatkin , James Morris , "Serge E. Hallyn" , David Safford , David Howells , Jerry Snitselaar , "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , open list , "moderated list:TPM DEVICE DRIVER" , "open list:INTEGRITY MEASUREMENT ARCHITECTURE (IMA)" , "open list:INTEGRITY MEASUREMENT ARCHITECTURE (IMA)" , "open list:KEYS-TRUSTED" Subject: Re: [PATCH v2] tpm: use struct tpm_chip for tpm_chip_find_get() Message-ID: <20171026105430.t6khk6cekk3cyfrs@linux.intel.com> References: <20171025115508.5682-1-jarkko.sakkinen@linux.intel.com> <20171025193452.d4qa4dhacfgqejk7@linux.intel.com> <20171025194633.GB998@obsidianresearch.com> <20171025200746.svsraubdotjyzt2i@linux.intel.com> <20171025201744.GB2815@obsidianresearch.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20171025201744.GB2815@obsidianresearch.com> Sender: linux-integrity-owner@vger.kernel.org List-ID: On Wed, Oct 25, 2017 at 02:17:44PM -0600, Jason Gunthorpe wrote: > On Wed, Oct 25, 2017 at 10:07:46PM +0200, Jarkko Sakkinen wrote: > > > The id has a nice feature that it is unique for one boot cycle you can > > even try to get a chip that has been deleted. It has the most stable > > properties in the long run. > > It isn't unique, we can re-use ids them via idr_alloc(). We should > never use index inside the kernel. > > > Address is a reusable identifier in one boot cycle. > > It is invalid to pass in a chip for which the caller does not hold a > kref, so address is the safest argument. > > Jason I'll buy this too (sending update today). /Jarkko From mboxrd@z Thu Jan 1 00:00:00 1970 From: jarkko.sakkinen@linux.intel.com (Jarkko Sakkinen) Date: Thu, 26 Oct 2017 12:54:30 +0200 Subject: [PATCH v2] tpm: use struct tpm_chip for tpm_chip_find_get() In-Reply-To: <20171025201744.GB2815@obsidianresearch.com> References: <20171025115508.5682-1-jarkko.sakkinen@linux.intel.com> <20171025193452.d4qa4dhacfgqejk7@linux.intel.com> <20171025194633.GB998@obsidianresearch.com> <20171025200746.svsraubdotjyzt2i@linux.intel.com> <20171025201744.GB2815@obsidianresearch.com> Message-ID: <20171026105430.t6khk6cekk3cyfrs@linux.intel.com> To: linux-security-module@vger.kernel.org List-Id: linux-security-module.vger.kernel.org On Wed, Oct 25, 2017 at 02:17:44PM -0600, Jason Gunthorpe wrote: > On Wed, Oct 25, 2017 at 10:07:46PM +0200, Jarkko Sakkinen wrote: > > > The id has a nice feature that it is unique for one boot cycle you can > > even try to get a chip that has been deleted. It has the most stable > > properties in the long run. > > It isn't unique, we can re-use ids them via idr_alloc(). We should > never use index inside the kernel. > > > Address is a reusable identifier in one boot cycle. > > It is invalid to pass in a chip for which the caller does not hold a > kref, so address is the safest argument. > > Jason I'll buy this too (sending update today). /Jarkko -- To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Subject: Re: [PATCH v2] tpm: use struct tpm_chip for tpm_chip_find_get() Date: Thu, 26 Oct 2017 12:54:30 +0200 Message-ID: <20171026105430.t6khk6cekk3cyfrs@linux.intel.com> References: <20171025115508.5682-1-jarkko.sakkinen@linux.intel.com> <20171025193452.d4qa4dhacfgqejk7@linux.intel.com> <20171025194633.GB998@obsidianresearch.com> <20171025200746.svsraubdotjyzt2i@linux.intel.com> <20171025201744.GB2815@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20171025201744.GB2815@obsidianresearch.com> Sender: linux-kernel-owner@vger.kernel.org To: Jason Gunthorpe Cc: PrasannaKumar Muralidharan , linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, Matt Mackall , Herbert Xu , Peter Huewe , Marcel Selhorst , Mimi Zohar , Dmitry Kasatkin , James Morris , "Serge E. Hallyn" , David Safford , David Howells , Jerry Snitselaar , "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , open list , "moderated list:TPM DEVICE DRIVER" List-Id: tpmdd-devel@lists.sourceforge.net On Wed, Oct 25, 2017 at 02:17:44PM -0600, Jason Gunthorpe wrote: > On Wed, Oct 25, 2017 at 10:07:46PM +0200, Jarkko Sakkinen wrote: > > > The id has a nice feature that it is unique for one boot cycle you can > > even try to get a chip that has been deleted. It has the most stable > > properties in the long run. > > It isn't unique, we can re-use ids them via idr_alloc(). We should > never use index inside the kernel. > > > Address is a reusable identifier in one boot cycle. > > It is invalid to pass in a chip for which the caller does not hold a > kref, so address is the safest argument. > > Jason I'll buy this too (sending update today). /Jarkko