Re: [Qemu-devel] [PATCH v3 3/5] migration: No need to return the size of the cache

["Dr. David Alan Gilbert" <dgilbert@redhat.com>]

* Juan Quintela (quintela@redhat.com) wrote:
> "Dr. David Alan Gilbert" <dgilbert@redhat.com> wrote:
> > * Juan Quintela (quintela@redhat.com) wrote:
> >> After the previous commits, we make sure that the value passed is
> >> right, or we just drop an error.  So now we return if there is one
> >> error or we have setup correctly the value passed.
> >> 
> >> Signed-off-by: Juan Quintela <quintela@redhat.com>
> 
> > OK, this shares the same oddity as the original which is
> >   XBZRLE.cache = NULL    is not an error.
> >
> > but, since that is the same as the original;
> 
> Hi
> 
> It is a normal case.  You can change the cache size in the middle of
> migration or outside migration.
> 
> If we are not in the middle of migration, cache is NULL.

Ah OK, so yes,


Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

> Later, Juan.
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK