All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Abandon the reset if we fail to stop the engines
Date: Thu, 26 Oct 2017 16:30:29 +0300	[thread overview]
Message-ID: <20171026133029.GQ10981@intel.com> (raw)
In-Reply-To: <150902348291.2864.8393293182276333747@mail.alporthouse.com>

On Thu, Oct 26, 2017 at 02:11:22PM +0100, Chris Wilson wrote:
> Quoting Ville Syrjälä (2017-10-26 13:59:05)
> > On Thu, Oct 26, 2017 at 01:12:12PM +0100, Chris Wilson wrote:
> > > Some machines, *cough* snb *cough*, fail catastrophically if asked to
> > > reset the GPU under certain conditions.
> > 
> > Did we try skipping the gen6_rps_disable() already?
> 
> I had thought we had taken that out a while ago... 
> 
> commit f2a91d1a6f5960c08f1ca60bd076f4dc020c50c6
> Author: Chris Wilson <chris@chris-wilson.co.uk>
> Date:   Wed Sep 21 14:51:06 2016 +0100
> 
>     drm/i915: Restore current RPS state after reset
> 
> removes the frobbing inside i915_reset() itself, but still talks about
> RPS needing to be restored... Ok, that's the post-reset stuff to make
> sure that the hw/sw tracking align.

Hmm. Right. It looks like we do the disable+re-enable back to back after
the reset. I guess at that point it should be safe, assuming the reset
actually worked. 

> 
> We are not touching rc6/rps prior to hitting GDRST. Maybe we should?

Based on what I remember that would be more dangerous if the engined is
stuck in a bad way.

So I guess these reset problems are something else then.

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

      reply	other threads:[~2017-10-26 13:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-26 12:12 [PATCH] drm/i915: Abandon the reset if we fail to stop the engines Chris Wilson
2017-10-26 12:33 ` ✗ Fi.CI.BAT: failure for " Patchwork
2017-10-26 12:46   ` Chris Wilson
2017-10-26 12:59 ` [PATCH] " Ville Syrjälä
2017-10-26 13:11   ` Chris Wilson
2017-10-26 13:30     ` Ville Syrjälä [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171026133029.GQ10981@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.