From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Date: Thu, 26 Oct 2017 16:50:27 +0000 Subject: Re: [PATCH v3] tpm: use struct tpm_chip for tpm_chip_find_get() Message-Id: <20171026165027.GA5829@obsidianresearch.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit List-Id: References: <20171026135453.24672-1-jarkko.sakkinen@linux.intel.com> <20171026160759.bycrmywqqxtjzpqk@linux.intel.com> In-Reply-To: To: PrasannaKumar Muralidharan Cc: Jarkko Sakkinen , open list , Matt Mackall , Herbert Xu , Peter Huewe , Marcel Selhorst , Mimi Zohar , Dmitry Kasatkin , James Morris , "Serge E. Hallyn" , David Safford , David Howells , Jerry Snitselaar , "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , "moderated list:TPM DEVICE DRIVER" , "open list:INTEGRITY MEASUREMENT ARCHITECTURE (IMA)" On Thu, Oct 26, 2017 at 09:57:12PM +0530, PrasannaKumar Muralidharan wrote: > I do not what value my rb tag provides as I have not contributed code > to it before. Is it encouraged by kernel community? Yes. People will judge the quality of your rb tag based on other reviews they have seen you make, and here you found a bug, so very good. Got to start someplace. Jason From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH v3] tpm: use struct tpm_chip for tpm_chip_find_get() Date: Thu, 26 Oct 2017 10:50:27 -0600 Message-ID: <20171026165027.GA5829@obsidianresearch.com> References: <20171026135453.24672-1-jarkko.sakkinen@linux.intel.com> <20171026160759.bycrmywqqxtjzpqk@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jarkko Sakkinen , open list , Matt Mackall , Herbert Xu , Peter Huewe , Marcel Selhorst , Mimi Zohar , Dmitry Kasatkin , James Morris , "Serge E. Hallyn" , David Safford , David Howells , Jerry Snitselaar , "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , "moderated list:TPM DEVICE DRIVER" , "open list:INTEGRITY MEASUREMENT ARCHITECTURE (IMA)" Return-path: Content-Disposition: inline In-Reply-To: Sender: owner-linux-security-module@vger.kernel.org List-Id: linux-crypto.vger.kernel.org On Thu, Oct 26, 2017 at 09:57:12PM +0530, PrasannaKumar Muralidharan wrote: > I do not what value my rb tag provides as I have not contributed code > to it before. Is it encouraged by kernel community? Yes. People will judge the quality of your rb tag based on other reviews they have seen you make, and here you found a bug, so very good. Got to start someplace. Jason From mboxrd@z Thu Jan 1 00:00:00 1970 From: jgunthorpe@obsidianresearch.com (Jason Gunthorpe) Date: Thu, 26 Oct 2017 10:50:27 -0600 Subject: [PATCH v3] tpm: use struct tpm_chip for tpm_chip_find_get() In-Reply-To: References: <20171026135453.24672-1-jarkko.sakkinen@linux.intel.com> <20171026160759.bycrmywqqxtjzpqk@linux.intel.com> Message-ID: <20171026165027.GA5829@obsidianresearch.com> To: linux-security-module@vger.kernel.org List-Id: linux-security-module.vger.kernel.org On Thu, Oct 26, 2017 at 09:57:12PM +0530, PrasannaKumar Muralidharan wrote: > I do not what value my rb tag provides as I have not contributed code > to it before. Is it encouraged by kernel community? Yes. People will judge the quality of your rb tag based on other reviews they have seen you make, and here you found a bug, so very good. Got to start someplace. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH v3] tpm: use struct tpm_chip for tpm_chip_find_get() Date: Thu, 26 Oct 2017 10:50:27 -0600 Message-ID: <20171026165027.GA5829@obsidianresearch.com> References: <20171026135453.24672-1-jarkko.sakkinen@linux.intel.com> <20171026160759.bycrmywqqxtjzpqk@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: owner-linux-security-module@vger.kernel.org To: PrasannaKumar Muralidharan Cc: Jarkko Sakkinen , open list , Matt Mackall , Herbert Xu , Peter Huewe , Marcel Selhorst , Mimi Zohar , Dmitry Kasatkin , James Morris , "Serge E. Hallyn" , David Safford , David Howells , Jerry Snitselaar , "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , "moderated list:TPM DEVICE DRIVER" , "open list:INTEGRITY MEASUREMENT ARCHITECTURE (IMA)" List-Id: tpmdd-devel@lists.sourceforge.net On Thu, Oct 26, 2017 at 09:57:12PM +0530, PrasannaKumar Muralidharan wrote: > I do not what value my rb tag provides as I have not contributed code > to it before. Is it encouraged by kernel community? Yes. People will judge the quality of your rb tag based on other reviews they have seen you make, and here you found a bug, so very good. Got to start someplace. Jason From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932395AbdJZQvL (ORCPT ); Thu, 26 Oct 2017 12:51:11 -0400 Received: from quartz.orcorp.ca ([184.70.90.242]:44823 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932127AbdJZQvJ (ORCPT ); Thu, 26 Oct 2017 12:51:09 -0400 Date: Thu, 26 Oct 2017 10:50:27 -0600 From: Jason Gunthorpe To: PrasannaKumar Muralidharan Cc: Jarkko Sakkinen , open list , Matt Mackall , Herbert Xu , Peter Huewe , Marcel Selhorst , Mimi Zohar , Dmitry Kasatkin , James Morris , "Serge E. Hallyn" , David Safford , David Howells , Jerry Snitselaar , "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , "moderated list:TPM DEVICE DRIVER" , "open list:INTEGRITY MEASUREMENT ARCHITECTURE (IMA)" , "open list:INTEGRITY MEASUREMENT ARCHITECTURE (IMA)" , "open list:INTEGRITY MEASUREMENT ARCHITECTURE (IMA)" , "open list:KEYS-TRUSTED" Subject: Re: [PATCH v3] tpm: use struct tpm_chip for tpm_chip_find_get() Message-ID: <20171026165027.GA5829@obsidianresearch.com> References: <20171026135453.24672-1-jarkko.sakkinen@linux.intel.com> <20171026160759.bycrmywqqxtjzpqk@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 26, 2017 at 09:57:12PM +0530, PrasannaKumar Muralidharan wrote: > I do not what value my rb tag provides as I have not contributed code > to it before. Is it encouraged by kernel community? Yes. People will judge the quality of your rb tag based on other reviews they have seen you make, and here you found a bug, so very good. Got to start someplace. Jason