From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51937) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e7j8F-0006k3-Cj for qemu-devel@nongnu.org; Thu, 26 Oct 2017 10:27:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e7j8C-0008SO-LW for qemu-devel@nongnu.org; Thu, 26 Oct 2017 10:27:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49146) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e7j8C-0008R0-EA for qemu-devel@nongnu.org; Thu, 26 Oct 2017 10:27:36 -0400 Date: Thu, 26 Oct 2017 17:27:31 +0300 From: "Michael S. Tsirkin" Message-ID: <20171026172631-mutt-send-email-mst@kernel.org> References: <1502842933-8323-1-git-send-email-tianyu.lan@intel.com> <34042934-782b-6bcc-b9b2-de7a1816cfb7@redhat.com> <3ababa62-f055-5bbb-b9b9-c55ada8368dd@intel.com> <20170818163854.GY3108@localhost.localdomain> <471a4bdc-d381-4a70-0107-3150df6f5cf6@intel.com> <20171026121943.GB26955@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20171026121943.GB26955@localhost.localdomain> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] x86: Skip check apic_id_limit for Xen List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: Lan Tianyu , qemu-devel@nongnu.org, xen-devel@lists.xenproject.org, anthony.perard@citrix.com, Paolo Bonzini , rth@twiddle.net On Thu, Oct 26, 2017 at 02:19:43PM +0200, Eduardo Habkost wrote: > On Mon, Aug 21, 2017 at 10:22:15AM +0800, Lan Tianyu wrote: > > On 2017=E5=B9=B408=E6=9C=8819=E6=97=A5 00:38, Eduardo Habkost wrote: > > > On Thu, Aug 17, 2017 at 09:37:10AM +0800, Lan Tianyu wrote: > > >> On 2017=E5=B9=B408=E6=9C=8816=E6=97=A5 19:21, Paolo Bonzini wrote: > > >>> On 16/08/2017 02:22, Lan Tianyu wrote: > > >>>> Xen vIOMMU device model will be in Xen hypervisor. Skip vIOMMU > > >>>> check for Xen here when vcpu number is more than 255. > > >>> > > >>> I think you still need to do a check for vIOMMU being enabled. > > >> > > >> Yes, this will be done in the Xen tool stack and Qemu doesn't have= such > > >> knowledge. Operations of create, destroy Xen vIOMMU will be done i= n the > > >> Xen tool stack. > > >=20 > > > Shouldn't we make QEMU have knowledge of the vIOMMU device, then? > > > Won't QEMU need to know about it eventually? > > >=20 > >=20 > > Hi Eduardo: > > Thanks for your review. > > Xen has some guest modes which doesn't use Qemu and we tried to > > make Xen vIOMMU framework compatible with all guest modes. So far, we > > are adding interrupt remapping function for Xen vIOMMU and find qemu > > doesn't need to know Xen vIOMMU. The check of vcpu number > 255 here > > will be done in Xen side and so skip the check in Qemu to avoid block= ing > > Xen creating >255 vcpus. > > We may make Qemu have knowledge of the vIOMMU device if it's > > necessary when adding new function. >=20 > I was expecting it to go through the PC tree, but I will queue it > on x86-next instead. I was waiting for an ack from you or Paolo as you participated in the discussion. But sure, go ahead Acked-by: Michael S. Tsirkin > --=20 > Eduardo From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [Qemu-devel] [PATCH] x86: Skip check apic_id_limit for Xen Date: Thu, 26 Oct 2017 17:27:31 +0300 Message-ID: <20171026172631-mutt-send-email-mst@kernel.org> References: <1502842933-8323-1-git-send-email-tianyu.lan@intel.com> <34042934-782b-6bcc-b9b2-de7a1816cfb7@redhat.com> <3ababa62-f055-5bbb-b9b9-c55ada8368dd@intel.com> <20170818163854.GY3108@localhost.localdomain> <471a4bdc-d381-4a70-0107-3150df6f5cf6@intel.com> <20171026121943.GB26955@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e7j8D-0006KJ-8a for xen-devel@lists.xenproject.org; Thu, 26 Oct 2017 14:27:37 +0000 Content-Disposition: inline In-Reply-To: <20171026121943.GB26955@localhost.localdomain> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Eduardo Habkost Cc: Lan Tianyu , qemu-devel@nongnu.org, Paolo Bonzini , anthony.perard@citrix.com, xen-devel@lists.xenproject.org, rth@twiddle.net List-Id: xen-devel@lists.xenproject.org T24gVGh1LCBPY3QgMjYsIDIwMTcgYXQgMDI6MTk6NDNQTSArMDIwMCwgRWR1YXJkbyBIYWJrb3N0 IHdyb3RlOgo+IE9uIE1vbiwgQXVnIDIxLCAyMDE3IGF0IDEwOjIyOjE1QU0gKzA4MDAsIExhbiBU aWFueXUgd3JvdGU6Cj4gPiBPbiAyMDE35bm0MDjmnIgxOeaXpSAwMDozOCwgRWR1YXJkbyBIYWJr b3N0IHdyb3RlOgo+ID4gPiBPbiBUaHUsIEF1ZyAxNywgMjAxNyBhdCAwOTozNzoxMEFNICswODAw LCBMYW4gVGlhbnl1IHdyb3RlOgo+ID4gPj4gT24gMjAxN+W5tDA45pyIMTbml6UgMTk6MjEsIFBh b2xvIEJvbnppbmkgd3JvdGU6Cj4gPiA+Pj4gT24gMTYvMDgvMjAxNyAwMjoyMiwgTGFuIFRpYW55 dSB3cm90ZToKPiA+ID4+Pj4gWGVuIHZJT01NVSBkZXZpY2UgbW9kZWwgd2lsbCBiZSBpbiBYZW4g aHlwZXJ2aXNvci4gU2tpcCB2SU9NTVUKPiA+ID4+Pj4gY2hlY2sgZm9yIFhlbiBoZXJlIHdoZW4g dmNwdSBudW1iZXIgaXMgbW9yZSB0aGFuIDI1NS4KPiA+ID4+Pgo+ID4gPj4+IEkgdGhpbmsgeW91 IHN0aWxsIG5lZWQgdG8gZG8gYSBjaGVjayBmb3IgdklPTU1VIGJlaW5nIGVuYWJsZWQuCj4gPiA+ Pgo+ID4gPj4gWWVzLCB0aGlzIHdpbGwgYmUgZG9uZSBpbiB0aGUgWGVuIHRvb2wgc3RhY2sgYW5k IFFlbXUgZG9lc24ndCBoYXZlIHN1Y2gKPiA+ID4+IGtub3dsZWRnZS4gT3BlcmF0aW9ucyBvZiBj cmVhdGUsIGRlc3Ryb3kgWGVuIHZJT01NVSB3aWxsIGJlIGRvbmUgaW4gdGhlCj4gPiA+PiBYZW4g dG9vbCBzdGFjay4KPiA+ID4gCj4gPiA+IFNob3VsZG4ndCB3ZSBtYWtlIFFFTVUgaGF2ZSBrbm93 bGVkZ2Ugb2YgdGhlIHZJT01NVSBkZXZpY2UsIHRoZW4/Cj4gPiA+IFdvbid0IFFFTVUgbmVlZCB0 byBrbm93IGFib3V0IGl0IGV2ZW50dWFsbHk/Cj4gPiA+IAo+ID4gCj4gPiBIaSBFZHVhcmRvOgo+ ID4gICAgICBUaGFua3MgZm9yIHlvdXIgcmV2aWV3Lgo+ID4gICAgICBYZW4gaGFzIHNvbWUgZ3Vl c3QgbW9kZXMgd2hpY2ggZG9lc24ndCB1c2UgUWVtdSBhbmQgd2UgdHJpZWQgdG8KPiA+IG1ha2Ug WGVuIHZJT01NVSBmcmFtZXdvcmsgY29tcGF0aWJsZSB3aXRoIGFsbCBndWVzdCBtb2Rlcy4gU28g ZmFyLCB3ZQo+ID4gYXJlIGFkZGluZyBpbnRlcnJ1cHQgcmVtYXBwaW5nIGZ1bmN0aW9uIGZvciBY ZW4gdklPTU1VIGFuZCBmaW5kIHFlbXUKPiA+IGRvZXNuJ3QgbmVlZCB0byBrbm93IFhlbiB2SU9N TVUuIFRoZSBjaGVjayBvZiB2Y3B1IG51bWJlciA+IDI1NSBoZXJlCj4gPiB3aWxsIGJlIGRvbmUg aW4gWGVuIHNpZGUgYW5kIHNvIHNraXAgdGhlIGNoZWNrIGluIFFlbXUgdG8gYXZvaWQgYmxvY2tp bmcKPiA+IFhlbiBjcmVhdGluZyA+MjU1IHZjcHVzLgo+ID4gICAgICBXZSBtYXkgbWFrZSBRZW11 IGhhdmUga25vd2xlZGdlIG9mIHRoZSB2SU9NTVUgZGV2aWNlIGlmIGl0J3MKPiA+IG5lY2Vzc2Fy eSB3aGVuIGFkZGluZyBuZXcgZnVuY3Rpb24uCj4gCj4gSSB3YXMgZXhwZWN0aW5nIGl0IHRvIGdv IHRocm91Z2ggdGhlIFBDIHRyZWUsIGJ1dCBJIHdpbGwgcXVldWUgaXQKPiBvbiB4ODYtbmV4dCBp bnN0ZWFkLgoKSSB3YXMgd2FpdGluZyBmb3IgYW4gYWNrIGZyb20geW91IG9yIFBhb2xvIGFzIHlv dSBwYXJ0aWNpcGF0ZWQgaW4gdGhlCmRpc2N1c3Npb24uIEJ1dCBzdXJlLCBnbyBhaGVhZAoKQWNr ZWQtYnk6IE1pY2hhZWwgUy4gVHNpcmtpbiA8bXN0QHJlZGhhdC5jb20+CgoKCj4gLS0gCj4gRWR1 YXJkbwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVu LWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3Rz Lnhlbi5vcmcveGVuLWRldmVsCg==