From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932394AbdJZR4F (ORCPT <rfc822;w@1wt.eu>);
        Thu, 26 Oct 2017 13:56:05 -0400
Received: from mail-qt0-f193.google.com ([209.85.216.193]:44856 "EHLO
        mail-qt0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932309AbdJZR4C (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 26 Oct 2017 13:56:02 -0400
X-Google-Smtp-Source: ABhQp+S/D+ROK+QXAsFjf39J4K6WStYeI2lzEgLENFDS16o8WaF44MzN9KFHcDlMU5V5L1nm0zk5gA==
Date: Thu, 26 Oct 2017 10:55:58 -0700
From: Tejun Heo <tj@kernel.org>
To: Lai Jiangshan <jiangshanlai@gmail.com>
Cc: Li Bin <huawei.libin@huawei.com>, LKML <linux-kernel@vger.kernel.org>,
        tanxiaofei@huawei.com, guohanjun@huawei.com
Subject: Re: [PATCH] workqueue: Fix NULL pointer dereference
Message-ID: <20171026175558.GF59538@devbig577.frc2.facebook.com>
References: <1508807914-25402-1-git-send-email-huawei.libin@huawei.com>
 <CAJhGHyBT0xF8Exn21Mb37e_e1f+DqvuZC94qY8SY=ScsvPHG+w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAJhGHyBT0xF8Exn21Mb37e_e1f+DqvuZC94qY8SY=ScsvPHG+w@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello,

On Thu, Oct 26, 2017 at 11:55:00PM +0800, Lai Jiangshan wrote:
> I remember that softirq can be invoked when irq_eixt(),
> and in this case the current->current_pwq is also NULL
> if __queue_work() is called in the soft irq.
> 
> So in_task() might be better than !in_irq() for the fix?

Reverted the patch for now.  Li, what do you think?

Thanks.

-- 
tejun