From: Borislav Petkov <bp@suse.de>
To: zhouchengming <zhouchengming1@huawei.com>
Cc: mingo@redhat.com, tglx@linutronix.de, peterz@infradead.org,
hpa@zytor.com, jkosina@suse.cz, rostedt@goodmis.org,
mjurczyk@google.com, x86@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/alternatives: free smp_alt_modules when enable smp
Date: Fri, 27 Oct 2017 10:27:45 +0200 [thread overview]
Message-ID: <20171027082745.GC1305@nazgul.tnic> (raw)
In-Reply-To: <59F2EA25.1080903@huawei.com>
On Fri, Oct 27, 2017 at 04:11:17PM +0800, zhouchengming wrote:
> So why not take the quick way like we do in
> alternatives_smp_module_add() ?
Because
1. there's no real problem with the current state
2. the current way is cleaner as it keeps that code away in
module_arch_cleanup().
--
Regards/Gruss,
Boris.
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--
prev parent reply other threads:[~2017-10-27 8:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-27 7:18 [PATCH] x86/alternatives: free smp_alt_modules when enable smp Zhou Chengming
2017-10-27 7:49 ` Borislav Petkov
2017-10-27 8:11 ` zhouchengming
2017-10-27 8:27 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171027082745.GC1305@nazgul.tnic \
--to=bp@suse.de \
--cc=hpa@zytor.com \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mjurczyk@google.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=zhouchengming1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.