From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 09/10] drm/i915: Use intel_ddi_get_config() for MST
Date: Fri, 27 Oct 2017 14:55:31 +0300 [thread overview]
Message-ID: <20171027115531.GD10981@intel.com> (raw)
In-Reply-To: <85702f4b-05dd-1d6d-b65c-5d6c9b5aa6a6@linux.intel.com>
On Fri, Oct 27, 2017 at 01:43:03PM +0200, Maarten Lankhorst wrote:
> Op 19-10-17 om 15:37 schreef Ville Syrjala:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Eliminate the partially duplicated DDI readout code from MST, and
> > instead just call intel_ddi_get_config(). As a nice bonus we get
> > more cross checking as intel_ddi_get_config() will populate
> > output_types based on the actual mode of the DDI port.
> >
> > Additonally intel_ddi_get_config() must be changed to get the crtc
> > from the passed in crtc state rather than from the encoder->crtc link.
> > encoder->crtc really shouldn't be used anyway.
> >
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> I looked and noticed 2 small differences, one is the GEN9_LP part, the other is
> min_voltage_level. Is this also a bugfix because of this?
The min_voltage thing should be fine. We should have it in both DDI and
MST code (unless I made a mistake when adding it, but doesn't look like
I did).
The bxt lat_optim thing is a real issue. Looks like I need to add that to
the MST compute_config. Though as a whole it feels a bit overkill to
track that particular piece of state specifically. We don't do that on
CHV either, which has the exact same PHY.
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-10-27 11:55 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 13:37 [PATCH 00/10] drm/i915: Last part of DDI encoder->type cleanup Ville Syrjala
2017-10-19 13:37 ` [PATCH 01/10] drm/i915: Don't use encoder->type in intel_ddi_set_pipe_settings() Ville Syrjala
2017-10-19 13:37 ` [PATCH 02/10] drm/i915: Pass crtc state to intel_prepare_dp_ddi_buffers() Ville Syrjala
2017-10-19 13:37 ` [PATCH 03/10] drm/i915: Start using output_types for DPLL selection Ville Syrjala
2017-10-19 13:37 ` [PATCH 04/10] drm/i915: Stop using encoder->type in intel_ddi_enable_transcoder_func() Ville Syrjala
2017-10-19 13:37 ` [PATCH v5 05/10] drm/i915: Stop frobbing with DDI encoder->type Ville Syrjala
2017-10-27 12:05 ` Maarten Lankhorst
2017-10-27 12:44 ` Ville Syrjälä
2017-10-27 13:53 ` Maarten Lankhorst
2017-10-27 14:03 ` Ville Syrjälä
2017-10-27 14:05 ` Maarten Lankhorst
2017-10-27 19:32 ` Ville Syrjälä
2017-10-19 13:37 ` [PATCH 06/10] drm/i915: Nuke intel_ddi_get_encoder_port() Ville Syrjala
2017-10-19 13:37 ` [PATCH 07/10] drm/i915: Eliminate pll->state usage from bxt_calc_pll_link() Ville Syrjala
2017-10-19 13:37 ` [PATCH 08/10] drm/i915: Pass a crtc state to ddi post_disable from MST code Ville Syrjala
2017-10-27 11:39 ` Maarten Lankhorst
2017-10-27 11:49 ` Ville Syrjälä
2017-10-27 14:31 ` Maarten Lankhorst
2017-10-19 13:37 ` [PATCH 09/10] drm/i915: Use intel_ddi_get_config() for MST Ville Syrjala
2017-10-27 11:43 ` Maarten Lankhorst
2017-10-27 11:55 ` Ville Syrjälä [this message]
2017-10-19 13:37 ` [PATCH 10/10] drm/i915: Use intel_crtc_has_dp_encoder() for LPE audio Ville Syrjala
2017-10-27 11:43 ` Maarten Lankhorst
2017-10-27 11:53 ` Ville Syrjälä
2017-10-19 14:00 ` ✓ Fi.CI.BAT: success for drm/i915: Last part of DDI encoder->type cleanup Patchwork
2017-10-19 14:59 ` ✓ Fi.CI.IGT: " Patchwork
2017-10-27 16:39 ` ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171027115531.GD10981@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=maarten.lankhorst@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.