From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lorenzo Pieralisi Subject: Re: [PATCH V2] panic: add support to update panic_timeout via DT Date: Fri, 27 Oct 2017 13:00:06 +0100 Message-ID: <20171027115957.GA32605@red-moon> References: <1509097165-15695-1-git-send-email-jburman@nvidia.com> <20171027095314.GA724@tigerII.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20171027095314.GA724-doRD9GlggSwB9AHHLWeGtNQXobZC6xk2@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sergey Senozhatsky Cc: Jeetesh Burman , keescook-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, bbasu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, Andrew Morton , robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org [+devicetree, Rob, Frank] On Fri, Oct 27, 2017 at 06:53:14PM +0900, Sergey Senozhatsky wrote: > Cc-ing Andrew on this > > > v1: lkml.kernel.org/r/1509076662-22253-1-git-send-email-jburman-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org > lkml.kernel.org/r/20171027080006.GA609-doRD9GlggSwB9AHHLWeGtNQXobZC6xk2@public.gmane.org > > v2: lkml.kernel.org/r/1509097165-15695-1-git-send-email-jburman-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org > > -ss > > On (10/27/17 15:09), Jeetesh Burman wrote: > > Add support to set 'panic_timeout' value via dtb to have > > control from device tree. This makes sense when you have > > multiple platforms support from same defconfig and > > differentiated only through device tree blob. > > The patch will check for panic time out value coming > > from dtb if it exists, otherwise continues with > > defconfig provided option. I will let Rob and Frank chime in - as far as I am concerned you are (ab)using DT to configure a Linux kernel specific internal variable and that's certainly not what DT is there for. Lorenzo > > Signed-off-by: Jeetesh Burman > > --- > > kernel/panic.c | 11 +++++++++-- > > 1 file changed, 9 insertions(+), 2 deletions(-) > > > > diff --git a/kernel/panic.c b/kernel/panic.c > > index bdd18af..b487331 100644 > > --- a/kernel/panic.c > > +++ b/kernel/panic.c > > @@ -27,6 +27,7 @@ > > #include > > #include > > #include > > +#include > > > > #define PANIC_TIMER_STEP 100 > > #define PANIC_BLINK_SPD 18 > > @@ -482,9 +483,15 @@ static u64 oops_id; > > > > static int init_oops_id(void) > > { > > - if (!oops_id) > > + struct device_node *np; > > + > > + if (!oops_id) { > > + np = of_find_node_by_name(NULL, "panic_timeout"); > > + if (np) > > + of_property_read_u32(np, "panic-timeout-value", > > + &panic_timeout); > > get_random_bytes(&oops_id, sizeof(oops_id)); > > - else > > + } else > > oops_id++; > > > > return 0; > > -- > > 2.1.4 > > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752535AbdJ0MAL (ORCPT ); Fri, 27 Oct 2017 08:00:11 -0400 Received: from foss.arm.com ([217.140.101.70]:58084 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752190AbdJ0MAH (ORCPT ); Fri, 27 Oct 2017 08:00:07 -0400 Date: Fri, 27 Oct 2017 13:00:06 +0100 From: Lorenzo Pieralisi To: Sergey Senozhatsky Cc: Jeetesh Burman , keescook@chromium.org, linux-kernel@vger.kernel.org, bbasu@nvidia.com, Andrew Morton , robh+dt@kernel.org, frowand.list@gmail.com, devicetree@vger.kernel.org Subject: Re: [PATCH V2] panic: add support to update panic_timeout via DT Message-ID: <20171027115957.GA32605@red-moon> References: <1509097165-15695-1-git-send-email-jburman@nvidia.com> <20171027095314.GA724@tigerII.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171027095314.GA724@tigerII.localdomain> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [+devicetree, Rob, Frank] On Fri, Oct 27, 2017 at 06:53:14PM +0900, Sergey Senozhatsky wrote: > Cc-ing Andrew on this > > > v1: lkml.kernel.org/r/1509076662-22253-1-git-send-email-jburman@nvidia.com > lkml.kernel.org/r/20171027080006.GA609@tigerII.localdomain > > v2: lkml.kernel.org/r/1509097165-15695-1-git-send-email-jburman@nvidia.com > > -ss > > On (10/27/17 15:09), Jeetesh Burman wrote: > > Add support to set 'panic_timeout' value via dtb to have > > control from device tree. This makes sense when you have > > multiple platforms support from same defconfig and > > differentiated only through device tree blob. > > The patch will check for panic time out value coming > > from dtb if it exists, otherwise continues with > > defconfig provided option. I will let Rob and Frank chime in - as far as I am concerned you are (ab)using DT to configure a Linux kernel specific internal variable and that's certainly not what DT is there for. Lorenzo > > Signed-off-by: Jeetesh Burman > > --- > > kernel/panic.c | 11 +++++++++-- > > 1 file changed, 9 insertions(+), 2 deletions(-) > > > > diff --git a/kernel/panic.c b/kernel/panic.c > > index bdd18af..b487331 100644 > > --- a/kernel/panic.c > > +++ b/kernel/panic.c > > @@ -27,6 +27,7 @@ > > #include > > #include > > #include > > +#include > > > > #define PANIC_TIMER_STEP 100 > > #define PANIC_BLINK_SPD 18 > > @@ -482,9 +483,15 @@ static u64 oops_id; > > > > static int init_oops_id(void) > > { > > - if (!oops_id) > > + struct device_node *np; > > + > > + if (!oops_id) { > > + np = of_find_node_by_name(NULL, "panic_timeout"); > > + if (np) > > + of_property_read_u32(np, "panic-timeout-value", > > + &panic_timeout); > > get_random_bytes(&oops_id, sizeof(oops_id)); > > - else > > + } else > > oops_id++; > > > > return 0; > > -- > > 2.1.4 > >