From: Alice Michael <alice.michael@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [next PATCH S81-V3 6/9] i40e: update VFs of link state after GET_VF_RESOURCES
Date: Fri, 27 Oct 2017 11:06:53 -0400 [thread overview]
Message-ID: <20171027150656.68250-6-alice.michael@intel.com> (raw)
In-Reply-To: <20171027150656.68250-1-alice.michael@intel.com>
From: Jacob Keller <jacob.e.keller@intel.com>
We currently notify a VF of the link state after ENABLE_QUEUES, which is
the last thing a VF does after being configured. Guests may not actually
ENABLE_QUEUES until they get configured, and thus between driver load
and device configuration the VF may show inaccurate link status.
Fix this by also sending the link state after GET_VF_RESOURCES. Although
we could remove the message following ENABLE_QUEUES, it's not that
significant of a loss, so this patch just keeps both to ensure maximum
compatibility with guests on various OSes.
Specifically, without this patch guests running FreeBSD will display
inaccurate link state until the device is brought up. This is mostly
a cosmetic issue but can be confusing to system administrators.
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
---
drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
index 56dd1e8..5c5113c 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
@@ -2748,6 +2748,7 @@ int i40e_vc_process_vf_msg(struct i40e_pf *pf, s16 vf_id, u32 v_opcode,
break;
case VIRTCHNL_OP_GET_VF_RESOURCES:
ret = i40e_vc_get_vf_resources_msg(vf, msg);
+ i40e_vc_notify_vf_link_state(vf);
break;
case VIRTCHNL_OP_RESET_VF:
i40e_vc_reset_vf_msg(vf);
--
2.9.5
next prev parent reply other threads:[~2017-10-27 15:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-27 15:06 [Intel-wired-lan] [next PATCH S81-V3 1/9] i40e: display priority_xon and priority_xoff stats Alice Michael
2017-10-27 15:06 ` [Intel-wired-lan] [next PATCH S81-V3 2/9] i40evf: don't rely on netif_running() outside rtnl_lock() Alice Michael
2017-10-30 22:02 ` Bowers, AndrewX
2017-10-27 15:06 ` [Intel-wired-lan] [next PATCH S81-V3 3/9] i40evf: use spinlock to protect (mac|vlan)_filter_list Alice Michael
2017-10-31 19:04 ` Bowers, AndrewX
2017-10-27 15:06 ` [Intel-wired-lan] [next PATCH S81-V3 4/9] i40evf: release bit locks in reverse order Alice Michael
2017-10-31 19:05 ` Bowers, AndrewX
2017-10-27 15:06 ` [Intel-wired-lan] [next PATCH S81-V3 5/9] i40evf: hold the critical task bit lock while opening Alice Michael
2017-10-31 19:05 ` Bowers, AndrewX
2017-10-27 15:06 ` Alice Michael [this message]
2017-10-31 19:06 ` [Intel-wired-lan] [next PATCH S81-V3 6/9] i40e: update VFs of link state after GET_VF_RESOURCES Bowers, AndrewX
2017-10-27 15:06 ` [Intel-wired-lan] [next PATCH S81-V3 7/9] i40e: add helper conversion function for link_speed Alice Michael
2017-10-31 19:06 ` Bowers, AndrewX
2017-10-27 15:06 ` [Intel-wired-lan] [next PATCH S81-V3 8/9] i40e: Fix for NUP NVM image downgrade failure Alice Michael
2017-10-30 22:44 ` Keller, Jacob E
2017-10-31 19:07 ` Bowers, AndrewX
2017-10-27 15:06 ` [Intel-wired-lan] [next PATCH S81-V3 9/9] i40e/i40evf: Bump driver versions Alice Michael
2017-10-30 22:04 ` Bowers, AndrewX
2017-10-30 21:52 ` [Intel-wired-lan] [next PATCH S81-V3 1/9] i40e: display priority_xon and priority_xoff stats Bowers, AndrewX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171027150656.68250-6-alice.michael@intel.com \
--to=alice.michael@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.