From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Date: Fri, 27 Oct 2017 17:23:04 +0000 Subject: Re: [PATCH] misc: bh1770glc: Use common error handling code in bh1770_power_state_store() Message-Id: <20171027172304.GA18401@kroah.com> List-Id: References: <568ee0ee-8ff1-9739-fa6b-f2eeae53e11a@users.sourceforge.net> <9c0b957a-93b5-39c9-f9bd-cb754d009d62@grinta.net> In-Reply-To: <9c0b957a-93b5-39c9-f9bd-cb754d009d62@grinta.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Daniele Nicolodi Cc: SF Markus Elfring , kernel-janitors@vger.kernel.org, Andrew Morton , Arnd Bergmann , Dan Carpenter , LKML , Jonathan Cameron , Samu Onkalo On Fri, Oct 27, 2017 at 11:11:13AM -0600, Daniele Nicolodi wrote: > On 10/27/17 10:20 AM, SF Markus Elfring wrote: > > From: Markus Elfring > > Date: Fri, 27 Oct 2017 18:00:31 +0200 > > > > Adjust jump targets so that a bit of exception handling can be better > > reused in an if branch of this function. > > What is the benefit brought by this change? Please note, you are responding to someone who lots and lots of kernel maintainers/developers have blacklisted, myself included. It's just not worth your effort, I recommend doing the same, as I'm not applying any patches from this author, unless some other maintainer wants to take the time to validate and send them on to me. kill-files are a good thing, please use them :) good luck! greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932364AbdJ0RXC (ORCPT ); Fri, 27 Oct 2017 13:23:02 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:58364 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932190AbdJ0RXA (ORCPT ); Fri, 27 Oct 2017 13:23:00 -0400 Date: Fri, 27 Oct 2017 19:23:04 +0200 From: Greg Kroah-Hartman To: Daniele Nicolodi Cc: SF Markus Elfring , kernel-janitors@vger.kernel.org, Andrew Morton , Arnd Bergmann , Dan Carpenter , LKML , Jonathan Cameron , Samu Onkalo Subject: Re: [PATCH] misc: bh1770glc: Use common error handling code in bh1770_power_state_store() Message-ID: <20171027172304.GA18401@kroah.com> References: <568ee0ee-8ff1-9739-fa6b-f2eeae53e11a@users.sourceforge.net> <9c0b957a-93b5-39c9-f9bd-cb754d009d62@grinta.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9c0b957a-93b5-39c9-f9bd-cb754d009d62@grinta.net> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 27, 2017 at 11:11:13AM -0600, Daniele Nicolodi wrote: > On 10/27/17 10:20 AM, SF Markus Elfring wrote: > > From: Markus Elfring > > Date: Fri, 27 Oct 2017 18:00:31 +0200 > > > > Adjust jump targets so that a bit of exception handling can be better > > reused in an if branch of this function. > > What is the benefit brought by this change? Please note, you are responding to someone who lots and lots of kernel maintainers/developers have blacklisted, myself included. It's just not worth your effort, I recommend doing the same, as I'm not applying any patches from this author, unless some other maintainer wants to take the time to validate and send them on to me. kill-files are a good thing, please use them :) good luck! greg k-h