All of lore.kernel.org
 help / color / mirror / Atom feed
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH urgent-4.14] nvme: Fix setting logical block format when revalidating
Date: Sat, 28 Oct 2017 07:52:58 +0200	[thread overview]
Message-ID: <20171028055258.GA13348@lst.de> (raw)
In-Reply-To: <20171027195122.1810-1-keith.busch@intel.com>

On Fri, Oct 27, 2017@01:51:22PM -0600, Keith Busch wrote:
> Revalidating the disk needs to set the logical block format and capacity,
> otherwise it can't figure out if the users modified anything about
> the namespace.
> 
> Fixes: cdbff4f26bd9 ("nvme: remove nvme_revalidate_ns")
> 
> Signed-off-by: Keith Busch <keith.busch at intel.com>

Looks fine to me:

Reviewed-by: Christoph Hellwig <hch at lst.de>

Jens: can you pick this up directly before sending a block PR today?

  reply	other threads:[~2017-10-28  5:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-27 19:51 [PATCH urgent-4.14] nvme: Fix setting logical block format when revalidating Keith Busch
2017-10-28  5:52 ` Christoph Hellwig [this message]
2017-10-29 12:25 ` Sagi Grimberg
2017-10-30 14:23 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171028055258.GA13348@lst.de \
    --to=hch@lst.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.