From: Joel Fernandes <joelaf@google.com>
To: linux-kernel@vger.kernel.org
Cc: Joel Fernandes <joelaf@google.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
"Cc: Srinivas Pandruvada" <srinivas.pandruvada@linux.intel.com>,
"Cc: Len Brown" <lenb@kernel.org>,
"Cc: Juri Lelli" <juri.lelli@arm.com>,
"Cc: Patrick Bellasi" <patrick.bellasi@arm.com>,
"Cc: Steve Muckle" <smuckle@google.com>,
"Cc: Brendan Jackman" <brendan.jackman@arm.com>,
"Cc: Chris Redpath" <Chris.Redpath@arm.com>,
"Cc: Atish Patra" <atish.patra@oracle.com>,
"Cc: Dietmar Eggemann" <dietmar.eggemann@arm.com>,
"Cc: Vincent Guittot" <vincent.guittot@linaro.org>,
"Cc: Morten Ramussen" <morten.rasmussen@arm.com>,
"Cc: Frederic Weisbecker" <fweisbec@gmail.com>,
"Cc: Thomas Gleixner" <tglx@linutronix.de>,
"Cc: EAS Dev" <eas-dev@lists.linaro.org>,
"Cc: Android Kernel" <kernel-team@android.com>
Subject: [PATCH RFC 4/5] sched/fair: Correct obsolete comment about cpufreq_update_util
Date: Sat, 28 Oct 2017 02:59:40 -0700 [thread overview]
Message-ID: <20171028095941.4773-5-joelaf@google.com> (raw)
In-Reply-To: <20171028095941.4773-1-joelaf@google.com>
Since the remote cpufreq callback work, the cpufreq_update_util call can happen
from remote CPUs. The comment about local CPUs is thus obsolete. Update it
accordingly.
Cc: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Joel Fernandes <joelaf@google.com>
---
kernel/sched/fair.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 4c06e52935d3..5c49fdb4c508 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -3018,9 +3018,7 @@ static inline void cfs_rq_util_change(struct cfs_rq *cfs_rq)
/*
* There are a few boundary cases this might miss but it should
* get called often enough that that should (hopefully) not be
- * a real problem -- added to that it only calls on the local
- * CPU, so if we enqueue remotely we'll miss an update, but
- * the next tick/schedule should update.
+ * a real problem.
*
* It will not get called when we go idle, because the idle
* thread is a different class (!fair), nor will the utilization
--
2.15.0.rc2.357.g7e34df9404-goog
next prev parent reply other threads:[~2017-10-28 10:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-28 9:59 [PATCH RFC 0/5] sched and cpufreq fixes/cleanups Joel Fernandes
2017-10-28 9:59 ` [PATCH RFC 1/5] Revert "sched/fair: Drop always true parameter of update_cfs_rq_load_avg()" Joel Fernandes
2017-10-28 9:59 ` [PATCH RFC 2/5] sched/fair: Skip frequency update if CPU about to idle Joel Fernandes
2017-10-30 12:07 ` Viresh Kumar
2017-10-30 19:02 ` Joel Fernandes
2017-11-01 19:35 ` Steve Muckle
2017-11-04 5:44 ` Joel Fernandes
2017-11-06 8:00 ` Vincent Guittot
2017-11-06 9:29 ` Uladzislau Rezki
2017-11-08 5:11 ` Joel Fernandes
2017-10-28 9:59 ` [PATCH RFC 3/5] cpufreq: schedutil: Use idle_calls counter of the remote CPU Joel Fernandes
2017-10-30 9:18 ` Viresh Kumar
2017-10-28 9:59 ` Joel Fernandes [this message]
2017-10-30 9:22 ` [PATCH RFC 4/5] sched/fair: Correct obsolete comment about cpufreq_update_util Viresh Kumar
2017-10-30 19:16 ` Joel Fernandes
2017-10-28 9:59 ` [PATCH RFC 5/5] sched/fair: remove impossible condition from find_idlest_group_cpu Joel Fernandes
2017-10-30 15:41 ` Brendan Jackman
2017-10-30 16:00 ` Vincent Guittot
2017-10-30 16:19 ` Joel Fernandes
2017-10-30 16:26 ` Vincent Guittot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171028095941.4773-5-joelaf@google.com \
--to=joelaf@google.com \
--cc=Chris.Redpath@arm.com \
--cc=atish.patra@oracle.com \
--cc=brendan.jackman@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=eas-dev@lists.linaro.org \
--cc=fweisbec@gmail.com \
--cc=juri.lelli@arm.com \
--cc=kernel-team@android.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=morten.rasmussen@arm.com \
--cc=patrick.bellasi@arm.com \
--cc=peterz@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=smuckle@google.com \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.