All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Yonatan Cohen <yonatanc-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Subject: [PATCH rdma-next v1 3/6] IB/mlx5: Exposing modify CQ callback to uverbs layer
Date: Sun, 29 Oct 2017 15:51:37 +0200	[thread overview]
Message-ID: <20171029135140.32649-4-leon@kernel.org> (raw)
In-Reply-To: <20171029135140.32649-1-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>

From: Yonatan Cohen <yonatanc-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

Exposed mlx5_ib_modify_cq to be called from ib device
verb list.

Signed-off-by: Yonatan Cohen <yonatanc-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Reviewed-by: Majd Dibbiny <majd-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Signed-off-by: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
---
 drivers/infiniband/hw/mlx5/cq.c   | 3 +++
 drivers/infiniband/hw/mlx5/main.c | 3 ++-
 include/linux/mlx5/cq.h           | 3 +++
 3 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/mlx5/cq.c b/drivers/infiniband/hw/mlx5/cq.c
index 01b218a3c277..18705cbcdc8c 100644
--- a/drivers/infiniband/hw/mlx5/cq.c
+++ b/drivers/infiniband/hw/mlx5/cq.c
@@ -1149,6 +1149,9 @@ int mlx5_ib_modify_cq(struct ib_cq *cq, u16 cq_count, u16 cq_period)
 	if (!MLX5_CAP_GEN(dev->mdev, cq_moderation))
 		return -ENOSYS;
 
+	if (cq_period > MLX5_MAX_CQ_PERIOD)
+		return -EINVAL;
+
 	err = mlx5_core_modify_cq_moderation(dev->mdev, &mcq->mcq,
 					     cq_period, cq_count);
 	if (err)
diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/mlx5/main.c
index e5f8d5d1cd7e..838c47012388 100644
--- a/drivers/infiniband/hw/mlx5/main.c
+++ b/drivers/infiniband/hw/mlx5/main.c
@@ -4020,7 +4020,8 @@ static void *mlx5_ib_add(struct mlx5_core_dev *mdev)
 		(1ull << IB_USER_VERBS_EX_CMD_QUERY_DEVICE)	|
 		(1ull << IB_USER_VERBS_EX_CMD_CREATE_CQ)	|
 		(1ull << IB_USER_VERBS_EX_CMD_CREATE_QP)	|
-		(1ull << IB_USER_VERBS_EX_CMD_MODIFY_QP);
+		(1ull << IB_USER_VERBS_EX_CMD_MODIFY_QP)	|
+		(1ull << IB_USER_VERBS_EX_CMD_MODIFY_CQ);
 
 	dev->ib_dev.query_device	= mlx5_ib_query_device;
 	dev->ib_dev.query_port		= mlx5_ib_query_port;
diff --git a/include/linux/mlx5/cq.h b/include/linux/mlx5/cq.h
index cc718e245b1e..6be357b219ec 100644
--- a/include/linux/mlx5/cq.h
+++ b/include/linux/mlx5/cq.h
@@ -128,6 +128,9 @@ enum {
 	CQE_SIZE_128_PAD = 2,
 };
 
+#define MLX5_MAX_CQ_PERIOD (BIT(__mlx5_bit_sz(cqc, cq_period)) - 1)
+#define MLX5_MAX_CQ_COUNT (BIT(__mlx5_bit_sz(cqc, cq_max_count)) - 1)
+
 static inline int cqe_sz_to_mlx_sz(u8 size, int padding_128_en)
 {
 	return padding_128_en ? CQE_SIZE_128_PAD :
-- 
2.14.2

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2017-10-29 13:51 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-29 13:51 [PATCH rdma-next v1 0/6] Expose CQ moderation to user space Leon Romanovsky
     [not found] ` <20171029135140.32649-1-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-10-29 13:51   ` [PATCH rdma-next v1 1/6] IB/uverbs: Allow CQ moderation with modify CQ Leon Romanovsky
     [not found]     ` <20171029135140.32649-2-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-10-29 17:43       ` Jason Gunthorpe
     [not found]         ` <20171029174345.GC4488-uk2M96/98Pc@public.gmane.org>
2017-10-29 18:28           ` Leon Romanovsky
     [not found]             ` <20171029182808.GN16127-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-10-30 14:48               ` Jason Gunthorpe
     [not found]                 ` <20171030144807.GA12392-uk2M96/98Pc@public.gmane.org>
2017-10-30 15:28                   ` Leon Romanovsky
     [not found]                     ` <20171030152815.GA16127-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-10-30 15:52                       ` Jason Gunthorpe
     [not found]                         ` <20171030155236.GC12392-uk2M96/98Pc@public.gmane.org>
2017-10-30 19:09                           ` Leon Romanovsky
     [not found]                             ` <20171030190952.GC16127-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-10-30 23:07                               ` Jason Gunthorpe
     [not found]                                 ` <20171030230753.GB4081-uk2M96/98Pc@public.gmane.org>
2017-10-31  5:08                                   ` Leon Romanovsky
     [not found]                                     ` <20171031050802.GE16127-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-10-31 11:31                                       ` Yishai Hadas
     [not found]                                         ` <13d687d9-80b4-621e-87bf-c6045da98c0c-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2017-10-31 15:40                                           ` Jason Gunthorpe
     [not found]                                             ` <20171031154046.GB9852-uk2M96/98Pc@public.gmane.org>
2017-10-31 17:06                                               ` Yishai Hadas
     [not found]                                                 ` <6e7e94e2-9b50-bfa4-a06a-b2452e1bc8a5-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2017-11-01 18:06                                                   ` Jason Gunthorpe
     [not found]                                                     ` <20171101180616.GI1030-uk2M96/98Pc@public.gmane.org>
2017-11-01 18:41                                                       ` Yishai Hadas
2017-11-10 19:15                       ` Doug Ledford
     [not found]                         ` <1510341329.3735.19.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-11-10 21:16                           ` Jason Gunthorpe
2017-11-11  8:09                           ` Leon Romanovsky
     [not found]                             ` <20171111080943.GT18825-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-11-11 15:45                               ` Jason Gunthorpe
2017-10-29 13:51   ` [PATCH rdma-next v1 2/6] IB/mlx4: Exposing modify CQ callback to uverbs layer Leon Romanovsky
2017-10-29 13:51   ` Leon Romanovsky [this message]
2017-10-29 13:51   ` [PATCH rdma-next v1 4/6] IB/uverbs: Add CQ moderation capability to query_device Leon Romanovsky
2017-10-29 13:51   ` [PATCH rdma-next v1 5/6] IB/mlx4: " Leon Romanovsky
2017-10-29 13:51   ` [PATCH rdma-next v1 6/6] IB/mlx5: " Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171029135140.32649-4-leon@kernel.org \
    --to=leon-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=yonatanc-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.