From: Yi Sun <yi.y.sun@linux.intel.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: "Wei Liu" <wei.liu2@citrix.com>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Ian Jackson" <ian.jackson@eu.citrix.com>,
xen-devel@lists.xenproject.org,
"Chao Peng" <chao.p.peng@linux.intel.com>,
"Daniel De Graaf" <dgdegra@tycho.nsa.gov>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [PATCH v9.1 02/16] Rename PSR sysctl/domctl interfaces and xsm policy to make them be general
Date: Mon, 30 Oct 2017 15:59:02 +0800 [thread overview]
Message-ID: <20171030075902.GH11006@yi.y.sun> (raw)
In-Reply-To: <59EF4DCE02000078001899DD@prv-mh.provo.novell.com>
On 17-10-24 06:27:26, Jan Beulich wrote:
> >>> On 24.10.17 at 11:10, <yi.y.sun@linux.intel.com> wrote:
> > This patch renames PSR sysctl/domctl interfaces and related xsm policy to
> > make them be general for all resource allocation features but not only
> > for CAT. Then, we can resuse the interfaces for all allocation features.
> >
> > Basically, it changes 'psr_cat_op' to 'psr_alloc', and remove 'CAT_' from some
> > macros. E.g.:
> > 1. psr_cat_op -> psr_alloc
> > 2. XEN_DOMCTL_psr_cat_op -> XEN_DOMCTL_psr_alloc
> > 3. XEN_SYSCTL_psr_cat_op -> XEN_SYSCTL_psr_alloc
> > 4. XEN_DOMCTL_PSR_CAT_SET_L3_CBM -> XEN_DOMCTL_PSR_SET_L3_CBM
> > 5. XEN_SYSCTL_PSR_CAT_get_l3_info -> XEN_SYSCTL_PSR_get_l3_info
> >
> > Signed-off-by: Yi Sun <yi.y.sun@linux.intel.com>
> > Reviewed-by: Wei Liu <wei.liu2@citrix.com>
> > Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
> > Acked-by: Jan Beulich <jbeulich@suse.com>
> > Acked-by: Daniel De Graaf <dgdegra@tycho.nsa.gov>
> > ---
> > CC: Jan Beulich <jbeulich@suse.com>
> > CC: Andrew Cooper <andrew.cooper3@citrix.com>
> > CC: Wei Liu <wei.liu2@citrix.com>
> > CC: Ian Jackson <ian.jackson@eu.citrix.com>
> > CC: Daniel De Graaf <dgdegra@tycho.nsa.gov>
> > CC: Roger Pau Monné <roger.pau@citrix.com>
> > CC: Chao Peng <chao.p.peng@linux.intel.com>
> >
> > v9:
> > - rename 'psr_cat_op' to 'psr_alloc' in xen.if.
>
> Even if this was just a simple oversight and an easy rename, I think
> strictly speaking it invalidates Daniel's ack.
>
> Jan
Sorry for that.
Hi, Daniel,
Could you please review the change again? Thank you!
BRs,
Sun Yi
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-10-30 8:00 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-20 8:28 [PATCH v9 00/16] Enable Memory Bandwidth Allocation in Xen Yi Sun
2017-10-20 8:28 ` [PATCH v9 01/16] docs: create Memory Bandwidth Allocation (MBA) feature document Yi Sun
2017-10-20 8:28 ` [PATCH v9 02/16] Rename PSR sysctl/domctl interfaces and xsm policy to make them be general Yi Sun
2017-10-24 9:10 ` [PATCH v9.1 " Yi Sun
2017-10-24 12:27 ` Jan Beulich
2017-10-30 7:59 ` Yi Sun [this message]
2017-10-30 17:22 ` Daniel De Graaf
2017-10-20 8:28 ` [PATCH v9 03/16] x86: rename 'cbm_type' to 'psr_type' to make it general Yi Sun
2017-10-20 8:28 ` [PATCH v9 04/16] x86: a few optimizations to psr codes Yi Sun
2017-10-20 8:28 ` [PATCH v9 05/16] x86: implement data structure and CPU init flow for MBA Yi Sun
2017-10-20 8:28 ` [PATCH v9 06/16] x86: implement get hw info " Yi Sun
2017-12-15 10:09 ` Jan Beulich
2017-12-18 9:38 ` Yi Sun
2017-12-18 8:30 ` [PATCH v9.1 " Yi Sun
2017-12-18 10:21 ` Jan Beulich
2017-10-20 8:28 ` [PATCH v9 07/16] x86: implement get value interface " Yi Sun
2017-10-20 8:28 ` [PATCH v9 08/16] x86: implement set value flow " Yi Sun
2017-10-20 8:28 ` [PATCH v9 09/16] tools: create general interfaces to support psr allocation features Yi Sun
2017-10-20 8:28 ` [PATCH v9 10/16] tools: implement the new libxc get hw info interface Yi Sun
2017-10-20 8:28 ` [PATCH v9 11/16] tools: implement the new libxl " Yi Sun
2017-10-20 8:28 ` [PATCH v9 12/16] tools: implement the new xl " Yi Sun
2017-10-20 8:28 ` [PATCH v9 13/16] tools: rename 'xc_psr_cat_type' to 'xc_psr_type' Yi Sun
2017-10-20 8:28 ` [PATCH v9 14/16] tools: implement new generic get value interface and MBA get value command Yi Sun
2017-10-20 8:28 ` [PATCH v9 15/16] tools: implement new generic set value interface and MBA set " Yi Sun
2017-12-18 8:31 ` [PATCH v9.1 " Yi Sun
2017-10-20 8:28 ` [PATCH v9 16/16] docs: add MBA description in docs Yi Sun
2017-12-05 2:53 ` [PATCH v9 00/16] Enable Memory Bandwidth Allocation in Xen Yi Sun
2017-12-05 9:09 ` Jan Beulich
2017-12-05 9:21 ` Yi Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171030075902.GH11006@yi.y.sun \
--to=yi.y.sun@linux.intel.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=chao.p.peng@linux.intel.com \
--cc=dgdegra@tycho.nsa.gov \
--cc=ian.jackson@eu.citrix.com \
--cc=roger.pau@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.