From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Nicolas Pitre <nicolas.pitre@linaro.org>
Cc: Richard Weinberger <richard@nod.at>,
Chris Brandt <chris.brandt@renesas.com>,
linux-mtd@lists.infradead.org
Subject: Re: [PATCH v2 0/5] unconfuse get_unmapped_area and point/unpoint driver methods
Date: Mon, 30 Oct 2017 09:58:53 +0100 [thread overview]
Message-ID: <20171030095853.230d800f@bbrezillon> (raw)
In-Reply-To: <nycvar.YSQ.7.76.1710271120070.3238@knanqh.ubzr>
Hi Nicolas,
On Fri, 27 Oct 2017 11:27:46 -0400 (EDT)
Nicolas Pitre <nicolas.pitre@linaro.org> wrote:
> On Fri, 27 Oct 2017, Boris Brezillon wrote:
>
> > Hi Nicolas,
> >
> > Some of your commits do not have commit messages (just a subject and
> > that's all). I know you're an experimented kernel developer and you
> > might find this superfluous, but we try to push all MTD contributors to
> > write a commit message, even if it's just a one line description that
> > basically repeats what the subject line says. Would you mind adding a
> > short description to patch 2 and 3.
> >
> > Other than that, the changes look good to me, so
> >
> > Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
>
> No problem.
>
> I added a one-liner justification to those commits, and your ACK to the
> series.
>
> This has been pushed here if you wish to pull it:
>
> http://git.linaro.org/people/nicolas.pitre/linux mtd_point
>
> Or if you prefer that I repost the whole thing just say so and I'll
> oblige.
It's easier for us if you repost the whole series (we use patchwork to
track MTD patches, and I like to have the version that hits mainline
available on patchwork too).
Thanks,
Boris
next prev parent reply other threads:[~2017-10-30 8:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 15:28 [PATCH v2 0/5] unconfuse get_unmapped_area and point/unpoint driver methods Nicolas Pitre
2017-10-17 15:28 ` [PATCH v2 1/5] MTD: mtdram: properly handle the phys argument in the point method Nicolas Pitre
2017-10-17 15:28 ` [PATCH v2 2/5] MTD: chips/map_ram.c: implement point and unpoint methods Nicolas Pitre
2017-10-17 15:28 ` [PATCH v2 3/5] MTD: chips/map_rom.c: " Nicolas Pitre
2017-10-17 15:28 ` [PATCH v2 4/5] MTD: implement mtd_get_unmapped_area() using the point method Nicolas Pitre
2017-10-17 15:28 ` [PATCH v2 5/5] MTD: remove the get_unmapped_area method Nicolas Pitre
2017-10-24 17:22 ` [PATCH v2 0/5] unconfuse get_unmapped_area and point/unpoint driver methods Nicolas Pitre
2017-10-25 12:24 ` Richard Weinberger
2017-10-25 15:36 ` Nicolas Pitre
2017-10-27 12:06 ` Boris Brezillon
2017-10-27 15:27 ` Nicolas Pitre
2017-10-30 8:58 ` Boris Brezillon [this message]
2017-11-03 3:19 ` Nicolas Pitre
2017-10-30 18:12 ` Chris Brandt
2017-10-30 18:34 ` Nicolas Pitre
2017-10-30 18:41 ` Chris Brandt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171030095853.230d800f@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=chris.brandt@renesas.com \
--cc=linux-mtd@lists.infradead.org \
--cc=nicolas.pitre@linaro.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.