Re: [Qemu-devel] [PATCH] qemu-iotests: Use -nographic in 182

[Kevin Wolf <kwolf@redhat.com>]

Am 30.10.2017 um 09:39 hat Kashyap Chamarthy geschrieben:
> On Sun, Oct 29, 2017 at 01:53:38PM +0100, Kevin Wolf wrote:
> > This avoids that random UI frontend error messages end up in the output.
> > In particular, we were seeing this line in CI error logs:
> > 
> > +Unable to init server: Could not connect: Connection refused
> > 
> > Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> > ---
> >  tests/qemu-iotests/182 | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tests/qemu-iotests/182 b/tests/qemu-iotests/182
> > index 2e078ceed8..4b31592fb8 100755
> > --- a/tests/qemu-iotests/182
> > +++ b/tests/qemu-iotests/182
> > @@ -62,7 +62,7 @@ _launch_qemu -drive file=$TEST_IMG,if=none,id=drive0,file.locking=on \
> >  
> >  echo
> >  echo "Starting a second QEMU using the same image should fail"
> > -echo 'quit' | $QEMU -monitor stdio \
> > +echo 'quit' | $QEMU -nographic -monitor stdio \
> 
> Isn't "-display none" preferred instead of "-nographic"?
> 
> Assuming you'll change it to "-display none":
> 
>     Reviewed-by: Kashyap CHamarthy <kchamart@redhat.com>

It's not the same thing, -nographic does more than just that, like
redirecting the serial port to stdio. In this specific case, -display
none should actually be enough, but for consistency I just did the same
thing as other qemu-iotest cases are doing.

Kevin