From: Torsten Duwe <duwe@lst.de>
To: "Naveen N . Rao" <naveen.n.rao@linux.vnet.ibm.com>
Cc: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Balbir Singh <bsingharora@gmail.com>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Jessica Yu <jeyu@kernel.org>,
Ananth N Mavinakayanahalli <ananth@linux.vnet.ibm.com>,
Aravinda Prasad <aravinda@linux.vnet.ibm.com>,
linuxppc-dev@lists.ozlabs.org, live-patching@vger.kernel.org
Subject: Re: [PATCH v3] kernel/module_64.c: Add REL24 relocation support of livepatch symbols
Date: Tue, 31 Oct 2017 16:30:05 +0100 [thread overview]
Message-ID: <20171031153004.GA31864@lst.de> (raw)
In-Reply-To: <20171031141959.7pqnlncg2236yqqg@naverao1-tp.localdomain>
On Tue, Oct 31, 2017 at 07:49:59PM +0530, Naveen N . Rao wrote:
> Hi Kamalesh,
> Sorry for the late review. Overall, the patch looks good to me.
If you're good with a hammer...
Maybe I failed to express my views properly; I find the whole approach
mislead in the first place. I had asked questions previously because it
would have never come to my mind that someone would deliberately, without
a compelling reason, creates broken live patch modules and then tries
to fix them up with some ugly band-aid in the kernel. So for the record:
NAK'd-by: Torsten Duwe <duwe@suse.de>
Torsten
next prev parent reply other threads:[~2017-10-31 15:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 5:18 [PATCH v3] kernel/module_64.c: Add REL24 relocation support of livepatch symbols Kamalesh Babulal
2017-10-31 14:19 ` Naveen N . Rao
2017-10-31 15:30 ` Torsten Duwe [this message]
2017-10-31 16:23 ` Naveen N . Rao
2017-10-31 18:39 ` Torsten Duwe
2017-11-01 0:23 ` Balbir Singh
2017-11-07 4:54 ` Josh Poimboeuf
2017-11-07 8:34 ` Michael Ellerman
2017-11-07 11:31 ` Torsten Duwe
2017-11-07 14:52 ` Josh Poimboeuf
2017-11-09 10:55 ` Michael Ellerman
[not found] ` <20171107145233.lmlg5lkfcczkxj4d__32032.512050546$1510066460$gmane$org@treble>
[not found] ` <20171107145233.lmlg5lkfcczkxj4d__32032.512050546$1510066460$gmane$org@treble >
2017-11-09 11:19 ` Naveen N. Rao
2017-11-09 15:19 ` Josh Poimboeuf
2017-11-10 2:06 ` Balbir Singh
2017-11-10 3:28 ` Josh Poimboeuf
2017-11-10 9:47 ` Michael Ellerman
2017-11-13 8:38 ` Balbir Singh
2017-11-13 11:38 ` Kamalesh Babulal
2017-11-15 10:19 ` Michael Ellerman
2017-11-02 5:49 ` Kamalesh Babulal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171031153004.GA31864@lst.de \
--to=duwe@lst.de \
--cc=ananth@linux.vnet.ibm.com \
--cc=aravinda@linux.vnet.ibm.com \
--cc=bsingharora@gmail.com \
--cc=jeyu@kernel.org \
--cc=jpoimboe@redhat.com \
--cc=kamalesh@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=live-patching@vger.kernel.org \
--cc=mpe@ellerman.id.au \
--cc=naveen.n.rao@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.