From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: [PATCH 2/2] drm/panel: Enable DSI transactions on the RPi panel. Date: Tue, 31 Oct 2017 12:32:58 -0700 Message-ID: <20171031193258.17373-2-eric@anholt.net> References: <20171031193258.17373-1-eric@anholt.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from anholt.net (anholt.net [50.246.234.109]) by gabe.freedesktop.org (Postfix) with ESMTP id 849C26E064 for ; Tue, 31 Oct 2017 19:33:01 +0000 (UTC) In-Reply-To: <20171031193258.17373-1-eric@anholt.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org, Thierry Reding Cc: linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org SXQgdHVybnMgb3V0IHRoYXQgSSBoYWQganVzdCBtaXN0YWtlbiB3aGF0IHR5cGUgb2Ygd3JpdGUg dGhlIHJlZ2lzdGVyCndyaXRlcyB3ZXJlIHN1cHBvc2VkIHRvIGJlLCB1c2luZyBEQ1MgaW5zdGVh ZCBvZiBnZW5lcmljIGxvbmcgd3JpdGVzLgoKU3dpdGNoaW5nIHRvIHRyYW5zYWN0aW9ucyBpbnN0 ZWFkIG9mIHVzaW5nIHRoZSBhdG1lbCBhcyBhIGJyaWRnZSBhbHNvCnNlZW1zIHRvIHJlc29sdmUg dGhlIHNwYXJrbGluZyBwaXhlbHMgcHJvYmxlbSBJJ3ZlIGhhZC4KClNpZ25lZC1vZmYtYnk6IEVy aWMgQW5ob2x0IDxlcmljQGFuaG9sdC5uZXQ+CkZpeGVzOiAyZjczM2Q2MTk0YmQgKCJkcm0vcGFu ZWw6IEFkZCBzdXBwb3J0IGZvciB0aGUgUmFzcGJlcnJ5IFBpIDciIFRvdWNoc2NyZWVuLiIpCi0t LQogZHJpdmVycy9ncHUvZHJtL3BhbmVsL3BhbmVsLXJhc3BiZXJyeXBpLXRvdWNoc2NyZWVuLmMg fCAxNCArLS0tLS0tLS0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxMyBk ZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vcGFuZWwvcGFuZWwtcmFz cGJlcnJ5cGktdG91Y2hzY3JlZW4uYyBiL2RyaXZlcnMvZ3B1L2RybS9wYW5lbC9wYW5lbC1yYXNw YmVycnlwaS10b3VjaHNjcmVlbi5jCmluZGV4IGQ5NjRkNDU0ZTRhZS4uMmM5Yzk3MjI3MzRmIDEw MDY0NAotLS0gYS9kcml2ZXJzL2dwdS9kcm0vcGFuZWwvcGFuZWwtcmFzcGJlcnJ5cGktdG91Y2hz Y3JlZW4uYworKysgYi9kcml2ZXJzL2dwdS9kcm0vcGFuZWwvcGFuZWwtcmFzcGJlcnJ5cGktdG91 Y2hzY3JlZW4uYwpAQCAtMjM4LDEyICsyMzgsNiBAQCBzdGF0aWMgdm9pZCBycGlfdG91Y2hzY3Jl ZW5faTJjX3dyaXRlKHN0cnVjdCBycGlfdG91Y2hzY3JlZW4gKnRzLAogCiBzdGF0aWMgaW50IHJw aV90b3VjaHNjcmVlbl93cml0ZShzdHJ1Y3QgcnBpX3RvdWNoc2NyZWVuICp0cywgdTE2IHJlZywg dTMyIHZhbCkKIHsKLSNpZiAwCi0JLyogVGhlIGZpcm13YXJlIHVzZXMgTFAgRFNJIHRyYW5zYWN0 aW9ucyBsaWtlIHRoaXMgdG8gYnJpbmcgdXAKLQkgKiB0aGUgaGFyZHdhcmUsIHdoaWNoIHNob3Vs ZCBiZSBmYXN0ZXIgdGhhbiB1c2luZyBJMkMgdG8gdGhlbgotCSAqIHBhc3MgdG8gdGhlIFRvc2hp YmEuICBIb3dldmVyLCBJIHdhcyB1bmFibGUgdG8gZ2V0IGl0IHRvCi0JICogd29yay4KLQkgKi8K IAl1OCBtc2dbXSA9IHsKIAkJcmVnLAogCQlyZWcgPj4gOCwKQEAgLTI1MywxMyArMjQ3LDcgQEAg c3RhdGljIGludCBycGlfdG91Y2hzY3JlZW5fd3JpdGUoc3RydWN0IHJwaV90b3VjaHNjcmVlbiAq dHMsIHUxNiByZWcsIHUzMiB2YWwpCiAJCXZhbCA+PiAyNCwKIAl9OwogCi0JbWlwaV9kc2lfZGNz X3dyaXRlX2J1ZmZlcih0cy0+ZHNpLCBtc2csIHNpemVvZihtc2cpKTsKLSNlbHNlCi0JcnBpX3Rv dWNoc2NyZWVuX2kyY193cml0ZSh0cywgUkVHX1dSX0FERFJILCByZWcgPj4gOCk7Ci0JcnBpX3Rv dWNoc2NyZWVuX2kyY193cml0ZSh0cywgUkVHX1dSX0FERFJMLCByZWcpOwotCXJwaV90b3VjaHNj cmVlbl9pMmNfd3JpdGUodHMsIFJFR19XUklURUgsIHZhbCA+PiA4KTsKLQlycGlfdG91Y2hzY3Jl ZW5faTJjX3dyaXRlKHRzLCBSRUdfV1JJVEVMLCB2YWwpOwotI2VuZGlmCisJbWlwaV9kc2lfZ2Vu ZXJpY193cml0ZSh0cy0+ZHNpLCBtc2csIHNpemVvZihtc2cpKTsKIAogCXJldHVybiAwOwogfQot LSAKMi4xNS4wCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932921AbdJaTdS (ORCPT ); Tue, 31 Oct 2017 15:33:18 -0400 Received: from anholt.net ([50.246.234.109]:39880 "EHLO anholt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932674AbdJaTdB (ORCPT ); Tue, 31 Oct 2017 15:33:01 -0400 From: Eric Anholt To: dri-devel@lists.freedesktop.org, Thierry Reding Cc: linux-kernel@vger.kernel.org, Eric Anholt Subject: [PATCH 2/2] drm/panel: Enable DSI transactions on the RPi panel. Date: Tue, 31 Oct 2017 12:32:58 -0700 Message-Id: <20171031193258.17373-2-eric@anholt.net> X-Mailer: git-send-email 2.15.0 In-Reply-To: <20171031193258.17373-1-eric@anholt.net> References: <20171031193258.17373-1-eric@anholt.net> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It turns out that I had just mistaken what type of write the register writes were supposed to be, using DCS instead of generic long writes. Switching to transactions instead of using the atmel as a bridge also seems to resolve the sparkling pixels problem I've had. Signed-off-by: Eric Anholt Fixes: 2f733d6194bd ("drm/panel: Add support for the Raspberry Pi 7" Touchscreen.") --- drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c b/drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c index d964d454e4ae..2c9c9722734f 100644 --- a/drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c +++ b/drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c @@ -238,12 +238,6 @@ static void rpi_touchscreen_i2c_write(struct rpi_touchscreen *ts, static int rpi_touchscreen_write(struct rpi_touchscreen *ts, u16 reg, u32 val) { -#if 0 - /* The firmware uses LP DSI transactions like this to bring up - * the hardware, which should be faster than using I2C to then - * pass to the Toshiba. However, I was unable to get it to - * work. - */ u8 msg[] = { reg, reg >> 8, @@ -253,13 +247,7 @@ static int rpi_touchscreen_write(struct rpi_touchscreen *ts, u16 reg, u32 val) val >> 24, }; - mipi_dsi_dcs_write_buffer(ts->dsi, msg, sizeof(msg)); -#else - rpi_touchscreen_i2c_write(ts, REG_WR_ADDRH, reg >> 8); - rpi_touchscreen_i2c_write(ts, REG_WR_ADDRL, reg); - rpi_touchscreen_i2c_write(ts, REG_WRITEH, val >> 8); - rpi_touchscreen_i2c_write(ts, REG_WRITEL, val); -#endif + mipi_dsi_generic_write(ts->dsi, msg, sizeof(msg)); return 0; } -- 2.15.0